* [PATCH v4 23/23] gpio: Unify style of various *_device_id arrays
2026-10-27 10:48 [PATCH v4 00/23] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
@ 2026-10-27 10:49 ` Uwe Kleine-König (The Capable Hub)
2026-10-28 13:57 ` [PATCH v4 00/23] gpio: Improvements around device-id arrays Alan Borzeszkowski
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-10-27 10:49 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Lixu Zhang, Sakari Ailus, Enrico Weigelt, metux IT consult,
Viresh Kumar, Mika Westerberg, Andy Shevchenko, linux-gpio,
linux-kernel, virtualization, linux-acpi, Viresh Kumar
Update the various *_device_id arrays to conform to the most used and
generally recommended coding style. That is:
- no comma after the list terminator;
- a comma after an initializer if (and only if) the closing } is not
directly following;
- no explicit zeros in the list terminator;
- a space after an opening { and before a closing }, a single space in
the list terminator;
Adapt the few offenders accordingly.
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
drivers/gpio/gpio-ljca.c | 2 +-
drivers/gpio/gpio-mpsse.c | 3 +--
drivers/gpio/gpio-pca953x.c | 2 +-
drivers/gpio/gpio-shared-proxy.c | 2 +-
drivers/gpio/gpio-virtio.c | 2 +-
drivers/gpio/gpiolib-acpi-quirks.c | 2 +-
6 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/gpio/gpio-ljca.c b/drivers/gpio/gpio-ljca.c
index f967feedb5d2..29b4e06497d9 100644
--- a/drivers/gpio/gpio-ljca.c
+++ b/drivers/gpio/gpio-ljca.c
@@ -473,7 +473,7 @@ static void ljca_gpio_remove(struct auxiliary_device *auxdev)
static const struct auxiliary_device_id ljca_gpio_id_table[] = {
{ .name = "usb_ljca.ljca-gpio" },
- { /* sentinel */ },
+ { /* sentinel */ }
};
MODULE_DEVICE_TABLE(auxiliary, ljca_gpio_id_table);
diff --git a/drivers/gpio/gpio-mpsse.c b/drivers/gpio/gpio-mpsse.c
index 61c5ca96314b..a540f6e94f11 100644
--- a/drivers/gpio/gpio-mpsse.c
+++ b/drivers/gpio/gpio-mpsse.c
@@ -80,10 +80,9 @@ static struct mpsse_quirk bryx_brik_quirk = {
static const struct usb_device_id gpio_mpsse_table[] = {
{ USB_DEVICE(0x0c52, 0xa064) }, /* SeaLevel Systems, Inc. */
{ USB_DEVICE(0x0403, 0x6988), /* FTDI, assigned to Bryx */
- .driver_info = (kernel_ulong_t)&bryx_brik_quirk},
+ .driver_info = (kernel_ulong_t)&bryx_brik_quirk },
{ } /* Terminating entry */
};
-
MODULE_DEVICE_TABLE(usb, gpio_mpsse_table);
static DEFINE_IDA(gpio_mpsse_ida);
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 77b447c0fea5..06f7ad0299f3 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -175,7 +175,7 @@ static const struct dmi_system_id pca953x_dmi_acpi_irq_info[] = {
DMI_EXACT_MATCH(DMI_BOARD_NAME, "GalileoGen2"),
},
},
- {}
+ { }
};
#endif
diff --git a/drivers/gpio/gpio-shared-proxy.c b/drivers/gpio/gpio-shared-proxy.c
index bc69b8729d19..b64e32a1c0a5 100644
--- a/drivers/gpio/gpio-shared-proxy.c
+++ b/drivers/gpio/gpio-shared-proxy.c
@@ -303,7 +303,7 @@ static int gpio_shared_proxy_probe(struct auxiliary_device *adev,
static const struct auxiliary_device_id gpio_shared_proxy_id_table[] = {
{ .name = "gpiolib_shared.proxy" },
- {},
+ { }
};
MODULE_DEVICE_TABLE(auxiliary, gpio_shared_proxy_id_table);
diff --git a/drivers/gpio/gpio-virtio.c b/drivers/gpio/gpio-virtio.c
index 42871db05ec1..062c70fe4671 100644
--- a/drivers/gpio/gpio-virtio.c
+++ b/drivers/gpio/gpio-virtio.c
@@ -647,7 +647,7 @@ static void virtio_gpio_remove(struct virtio_device *vdev)
static const struct virtio_device_id id_table[] = {
{ .device = VIRTIO_ID_GPIO, .vendor = VIRTIO_DEV_ANY_ID },
- {},
+ { }
};
MODULE_DEVICE_TABLE(virtio, id_table);
diff --git a/drivers/gpio/gpiolib-acpi-quirks.c b/drivers/gpio/gpiolib-acpi-quirks.c
index 3ab02c5f95df..77b9e34cd618 100644
--- a/drivers/gpio/gpiolib-acpi-quirks.c
+++ b/drivers/gpio/gpiolib-acpi-quirks.c
@@ -465,7 +465,7 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
.ignore_wake = "GTCH7503:00@10",
},
},
- {} /* Terminating entry */
+ { } /* Terminating entry */
};
static int __init acpi_gpio_setup_params(void)
--
2.56.0.rc1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v4 00/23] gpio: Improvements around device-id arrays
2026-10-27 10:48 [PATCH v4 00/23] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:49 ` [PATCH v4 23/23] gpio: Unify style of various *_device_id arrays Uwe Kleine-König (The Capable Hub)
@ 2026-10-28 13:57 ` Alan Borzeszkowski
2026-11-03 12:24 ` Bartosz Golaszewski
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Alan Borzeszkowski @ 2026-10-28 13:57 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub), Linus Walleij,
Bartosz Golaszewski
Cc: Andy Shevchenko, linux-gpio, linux-kernel, Lixu Zhang,
Sakari Ailus, Broadcom internal kernel review list,
Florian Fainelli, Eugeniy Paltsev, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Imre Kaloz, Conor Dooley,
Valentina Fernandez, Daire McNamara, Daniel Palmer, Romain Perier,
Robert Jarzmik, imx, linux-arm-kernel, linux-riscv, Hoan Tran,
Mika Westerberg, Hans de Goede, Nuno Sá, linux-hwmon,
Matti Vaittinen, Enrico Weigelt, metux IT consult, Viresh Kumar,
virtualization, Yinbo Zhu, Thierry Reding, Jonathan Hunter,
linux-tegra, Geert Uytterhoeven, AngeloGioacchino Del Regno,
Srinivas Neeli, Michal Simek, linux-aspeed, asahi, linux-mediatek,
openbmc, linux-omap, linux-renesas-soc, linux-unisoc,
linux-rockchip, linux-stm32, Michael Buesch,
William Breathitt Gray, Robert Richter, Andy Shevchenko,
linux-acpi
Hi,
On Tue, 2026-10-27 at 11:48 +0100, Uwe Kleine-König (The Capable Hub)
wrote:
> Hello,
>
> the original motivation for this series are the patches that convert
> the
> arrays to use named initializers, see
> https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
> for the idea behind it. Looking left and right a bit while
> implementing
> that, the series grew a bit.
>
> Changes since v3 (available at
> https://lore.kernel.org/all/cover.1793030820.git.u.kleine-koenig@baylibre.com
> ):
>
> - Picked up review tags (b4 even found some from v2)
> - Add a 2nd MODULE_DEVICE_TABLE(of, ...) in drivers/gpio/gpio-
> mpc5200.c
> (My grep didn't handle >1 driver per file well), noticed by
> Sashiko
> - New patch to use named initializers for auxiliary_device_id arrays
> - Fix code style of of_device_id array in drivers/gpio/gpio-grgpio.c
> (My script doesn't handle of_device_id::name) and
> drivers/gpio/gpio-ppc44x.c (didn't exist yet when I sent v2 and
> failed to notice that for v3)
> - Fix code style of auxiliary_device_id array in
> drivers/gpio/gpio-shared-proxy.c, missed as I didn't have a script
> for auxiliary_device_id before.
> - Dropped a few broken email addresses from Cc:
>
> Best regards
> Uwe
>
> Uwe Kleine-König (The Capable Hub) (23):
> [...]
> gpio: Use named initializers for acpi_device_id array
> [...]
> gpio: Unify style of acpi_device_id arrays
> [...]
>
> [...]
> drivers/gpio/gpio-novalake-events.c | 4 ++--
> [...]
>
For gpio-novalake-events
Acked-by: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v4 00/23] gpio: Improvements around device-id arrays
2026-10-27 10:48 [PATCH v4 00/23] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:49 ` [PATCH v4 23/23] gpio: Unify style of various *_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-28 13:57 ` [PATCH v4 00/23] gpio: Improvements around device-id arrays Alan Borzeszkowski
@ 2026-11-03 12:24 ` Bartosz Golaszewski
2026-11-05 8:47 ` Bartosz Golaszewski
2026-11-05 12:24 ` Bartosz Golaszewski
4 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2026-11-03 12:24 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub)
Cc: Linus Walleij, Andy Shevchenko, linux-gpio, linux-kernel,
Lixu Zhang, Sakari Ailus, Broadcom internal kernel review list,
Florian Fainelli, Eugeniy Paltsev, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Imre Kaloz, Conor Dooley,
Valentina Fernandez, Daire McNamara, Daniel Palmer, Romain Perier,
Robert Jarzmik, imx, linux-arm-kernel, linux-riscv, Hoan Tran,
Alan Borzeszkowski, Mika Westerberg, Hans de Goede, Nuno Sá,
linux-hwmon, Matti Vaittinen, Enrico Weigelt, metux IT consult,
Viresh Kumar, virtualization, Yinbo Zhu, Thierry Reding,
Jonathan Hunter, linux-tegra, Geert Uytterhoeven,
AngeloGioacchino Del Regno, Srinivas Neeli, Michal Simek,
linux-aspeed, asahi, linux-mediatek, openbmc, linux-omap,
linux-renesas-soc, linux-unisoc, linux-rockchip, linux-stm32,
Michael Buesch, William Breathitt Gray, Robert Richter,
Andy Shevchenko, linux-acpi
On Tue, Oct 27, 2026 at 11:48:37AM +0100, Uwe Kleine-König (The Capable Hub) wrote:
> Hello,
>
> the original motivation for this series are the patches that convert the
> arrays to use named initializers, see
> https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
> for the idea behind it. Looking left and right a bit while implementing
> that, the series grew a bit.
>
> Changes since v3 (available at
> https://lore.kernel.org/all/cover.1793030820.git.u.kleine-koenig@baylibre.com):
>
> - Picked up review tags (b4 even found some from v2)
> - Add a 2nd MODULE_DEVICE_TABLE(of, ...) in drivers/gpio/gpio-mpc5200.c
> (My grep didn't handle >1 driver per file well), noticed by Sashiko
> - New patch to use named initializers for auxiliary_device_id arrays
> - Fix code style of of_device_id array in drivers/gpio/gpio-grgpio.c
> (My script doesn't handle of_device_id::name) and
> drivers/gpio/gpio-ppc44x.c (didn't exist yet when I sent v2 and
> failed to notice that for v3)
> - Fix code style of auxiliary_device_id array in
> drivers/gpio/gpio-shared-proxy.c, missed as I didn't have a script
> for auxiliary_device_id before.
> - Dropped a few broken email addresses from Cc:
>
If there are no objections, I'll queue it by the end of this week.
Bart
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 00/23] gpio: Improvements around device-id arrays
2026-10-27 10:48 [PATCH v4 00/23] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
` (2 preceding siblings ...)
2026-11-03 12:24 ` Bartosz Golaszewski
@ 2026-11-05 8:47 ` Bartosz Golaszewski
2026-11-05 11:06 ` Uwe Kleine-König (The Capable Hub)
2026-11-05 12:24 ` Bartosz Golaszewski
4 siblings, 1 reply; 9+ messages in thread
From: Bartosz Golaszewski @ 2026-11-05 8:47 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub)
Cc: Linus Walleij, Andy Shevchenko, linux-gpio, linux-kernel,
Lixu Zhang, Sakari Ailus, Broadcom internal kernel review list,
Florian Fainelli, Eugeniy Paltsev, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Imre Kaloz, Conor Dooley,
Valentina Fernandez, Daire McNamara, Daniel Palmer, Romain Perier,
Robert Jarzmik, imx, linux-arm-kernel, linux-riscv, Hoan Tran,
Alan Borzeszkowski, Mika Westerberg, Hans de Goede, Nuno Sá,
linux-hwmon, Matti Vaittinen, Enrico Weigelt, metux IT consult,
Viresh Kumar, virtualization, Yinbo Zhu, Thierry Reding,
Jonathan Hunter, linux-tegra, Geert Uytterhoeven,
AngeloGioacchino Del Regno, Srinivas Neeli, Michal Simek,
linux-aspeed, asahi, linux-mediatek, openbmc, linux-omap,
linux-renesas-soc, linux-unisoc, linux-rockchip, linux-stm32,
Michael Buesch, William Breathitt Gray, Robert Richter,
Andy Shevchenko, linux-acpi
On Tue, Oct 27, 2026 at 11:48:37AM +0100, Uwe Kleine-König (The Capable Hub) wrote:
> Hello,
>
> the original motivation for this series are the patches that convert the
> arrays to use named initializers, see
> https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
> for the idea behind it. Looking left and right a bit while implementing
> that, the series grew a bit.
>
Hi Uwe!
This no longer applies, can you rebase it on top of gpio/for-next and
resend? I'll apply it right away before any additional conflicts.
Bart
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v4 00/23] gpio: Improvements around device-id arrays
2026-11-05 8:47 ` Bartosz Golaszewski
@ 2026-11-05 11:06 ` Uwe Kleine-König (The Capable Hub)
2026-11-05 12:25 ` Bartosz Golaszewski
0 siblings, 1 reply; 9+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-11-05 11:06 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Linus Walleij, Andy Shevchenko, linux-gpio, linux-kernel,
Lixu Zhang, Sakari Ailus, Broadcom internal kernel review list,
Florian Fainelli, Eugeniy Paltsev, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Imre Kaloz, Conor Dooley,
Valentina Fernandez, Daire McNamara, Daniel Palmer, Romain Perier,
Robert Jarzmik, imx, linux-arm-kernel, linux-riscv, Hoan Tran,
Alan Borzeszkowski, Mika Westerberg, Hans de Goede, Nuno Sá,
linux-hwmon, Matti Vaittinen, Enrico Weigelt, metux IT consult,
Viresh Kumar, virtualization, Yinbo Zhu, Thierry Reding,
Jonathan Hunter, linux-tegra, Geert Uytterhoeven,
AngeloGioacchino Del Regno, Srinivas Neeli, Michal Simek,
linux-aspeed, asahi, linux-mediatek, openbmc, linux-omap,
linux-renesas-soc, linux-unisoc, linux-rockchip, linux-stm32,
Michael Buesch, William Breathitt Gray, Robert Richter,
Andy Shevchenko, linux-acpi
[-- Attachment #1: Type: text/plain, Size: 2696 bytes --]
On Thu, Nov 05, 2026 at 09:47:39AM +0100, Bartosz Golaszewski wrote:
> On Tue, Oct 27, 2026 at 11:48:37AM +0100, Uwe Kleine-König (The Capable Hub) wrote:
> > Hello,
> >
> > the original motivation for this series are the patches that convert the
> > arrays to use named initializers, see
> > https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
> > for the idea behind it. Looking left and right a bit while implementing
> > that, the series grew a bit.
> >
>
> Hi Uwe!
>
> This no longer applies, can you rebase it on top of gpio/for-next and
> resend? I'll apply it right away before any additional conflicts.
Hmm:
$ git fetch https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
From https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux
* branch gpio/for-next -> FETCH_HEAD
$ git checkout FETCH_HEAD
HEAD is now at d66b6b86d5a6 gpio: 74x164: add support for 74lv164 shift register variant
$ b4 am -3 2hfpcbk6r56vvhkqyiex2apl3pinieybad5sd3vkvvabqs3uto@lydt3gin5kxe
Looking up 2hfpcbk6r56vvhkqyiex2apl3pinieybad5sd3vkvvabqs3uto@lydt3gin5kxe
Analyzing 33 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Analyzing 99 code-review messages
Checking attestation on all messages, may take a moment...
---
✓ [PATCH v4 1/23] gpio: Remove __maybe_unused annotations from acpi_device_id arrays
+ Acked-by: Frank Li <Frank.Li@nxp.com> (✗ DKIM/nxp1.onmicrosoft.com)
+ Acked-by: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com> (✓ DKIM/intel.com)
✓ [PATCH v4 2/23] gpio: fxl6408: Remove __maybe_unused annotations from of_device_id array
[...]
Link: https://patch.msgid.link/cover.1793097104.git.u.kleine-koenig@baylibre.com
git checkout -b v4_20261027_u_kleine_koenig_baylibre_com 20a33c6b6cbe7e4805dfb6cd68816937443aa148
git am -3 ./v4_20261027_u_kleine_koenig_gpio_improvements_around_device_id_arrays.mbx
$ git am -3 ./v4_20261027_u_kleine_koenig_gpio_improvements_around_device_id_arrays.mbx
Applying: gpio: Remove __maybe_unused annotations from acpi_device_id arrays
Applying: gpio: fxl6408: Remove __maybe_unused annotations from of_device_id array
Applying: gpio: Drop unused assignment of acpi_device_id driver data
...
Applying: gpio: Unify style of pci_device_id arrays
Applying: gpio: Unify style of various *_device_id arrays
$ echo $?
0
Maybe you just need to add `-3` to your workflow? ISTR this should be
the default for b4, but it seems if failed to mention the -3 in the git
am cmdline.
Should I still resend?
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 00/23] gpio: Improvements around device-id arrays
2026-11-05 11:06 ` Uwe Kleine-König (The Capable Hub)
@ 2026-11-05 12:25 ` Bartosz Golaszewski
2026-11-05 14:22 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: Bartosz Golaszewski @ 2026-11-05 12:25 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub)
Cc: Linus Walleij, Andy Shevchenko, linux-gpio, linux-kernel,
Lixu Zhang, Sakari Ailus, Broadcom internal kernel review list,
Florian Fainelli, Eugeniy Paltsev, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Imre Kaloz, Conor Dooley,
Valentina Fernandez, Daire McNamara, Daniel Palmer, Romain Perier,
Robert Jarzmik, imx, linux-arm-kernel, linux-riscv, Hoan Tran,
Alan Borzeszkowski, Mika Westerberg, Hans de Goede, Nuno Sá,
linux-hwmon, Matti Vaittinen, Enrico Weigelt, metux IT consult,
Viresh Kumar, virtualization, Yinbo Zhu, Thierry Reding,
Jonathan Hunter, linux-tegra, Geert Uytterhoeven,
AngeloGioacchino Del Regno, Srinivas Neeli, Michal Simek,
linux-aspeed, asahi, linux-mediatek, openbmc, linux-omap,
linux-renesas-soc, linux-unisoc, linux-rockchip, linux-stm32,
Michael Buesch, William Breathitt Gray, Robert Richter,
Andy Shevchenko, linux-acpi
On Thu, Nov 05, 2026 at 12:06:33PM +0100, Uwe Kleine-König (The Capable Hub) wrote:
>
> Maybe you just need to add `-3` to your workflow? ISTR this should be
> the default for b4, but it seems if failed to mention the -3 in the git
> am cmdline.
>
> Should I still resend?
>
No, it's alright. I would have preferred a clean b4 shazam but that
works too, thanks.
Bart
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 00/23] gpio: Improvements around device-id arrays
2026-11-05 12:25 ` Bartosz Golaszewski
@ 2026-11-05 14:22 ` Andy Shevchenko
0 siblings, 0 replies; 9+ messages in thread
From: Andy Shevchenko @ 2026-11-05 14:22 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Uwe Kleine-König (The Capable Hub), Linus Walleij,
Andy Shevchenko, linux-gpio, linux-kernel, Lixu Zhang,
Sakari Ailus, Broadcom internal kernel review list,
Florian Fainelli, Eugeniy Paltsev, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Imre Kaloz, Conor Dooley,
Valentina Fernandez, Daire McNamara, Daniel Palmer, Romain Perier,
Robert Jarzmik, imx, linux-arm-kernel, linux-riscv, Hoan Tran,
Alan Borzeszkowski, Mika Westerberg, Hans de Goede, Nuno Sá,
linux-hwmon, Matti Vaittinen, Enrico Weigelt, metux IT consult,
Viresh Kumar, virtualization, Yinbo Zhu, Thierry Reding,
Jonathan Hunter, linux-tegra, Geert Uytterhoeven,
AngeloGioacchino Del Regno, Srinivas Neeli, Michal Simek,
linux-aspeed, asahi, linux-mediatek, openbmc, linux-omap,
linux-renesas-soc, linux-unisoc, linux-rockchip, linux-stm32,
Michael Buesch, William Breathitt Gray, Robert Richter,
linux-acpi
On Thu, Nov 05, 2026 at 01:25:34PM +0100, Bartosz Golaszewski wrote:
> On Thu, Nov 05, 2026 at 12:06:33PM +0100, Uwe Kleine-König (The Capable Hub) wrote:
> >
> > Maybe you just need to add `-3` to your workflow? ISTR this should be
> > the default for b4, but it seems if failed to mention the -3 in the git
> > am cmdline.
> >
> > Should I still resend?
>
> No, it's alright. I would have preferred a clean b4 shazam but that
> works too, thanks.
To make that one should really have a unbiased base with the gpio/for-next,
say v7.4-rc1. Then with --base present `b4 shazam` should follow that.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 00/23] gpio: Improvements around device-id arrays
2026-10-27 10:48 [PATCH v4 00/23] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
` (3 preceding siblings ...)
2026-11-05 8:47 ` Bartosz Golaszewski
@ 2026-11-05 12:24 ` Bartosz Golaszewski
4 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2026-11-05 12:24 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski,
Uwe Kleine-König (The Capable Hub)
Cc: Bartosz Golaszewski, Andy Shevchenko, linux-gpio, linux-kernel,
Lixu Zhang, Sakari Ailus, Broadcom internal kernel review list,
Florian Fainelli, Eugeniy Paltsev, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Imre Kaloz, Conor Dooley,
Valentina Fernandez, Daire McNamara, Daniel Palmer, Romain Perier,
Robert Jarzmik, imx, linux-arm-kernel, linux-riscv, Hoan Tran,
Alan Borzeszkowski, Mika Westerberg, Hans de Goede, Nuno Sá,
linux-hwmon, Matti Vaittinen, Enrico Weigelt, metux IT consult,
Viresh Kumar, virtualization, Yinbo Zhu, Thierry Reding,
Jonathan Hunter, linux-tegra, Geert Uytterhoeven,
AngeloGioacchino Del Regno, Srinivas Neeli, Michal Simek,
linux-aspeed, asahi, linux-mediatek, openbmc, linux-omap,
linux-renesas-soc, linux-unisoc, linux-rockchip, linux-stm32,
Michael Buesch, William Breathitt Gray, Robert Richter,
Andy Shevchenko, linux-acpi
On Tue, 27 Oct 2026 11:48:37 +0100, Uwe Kleine-König (The Capable Hub) wrote:
> the original motivation for this series are the patches that convert the
> arrays to use named initializers, see
> https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
> for the idea behind it. Looking left and right a bit while implementing
> that, the series grew a bit.
>
> Changes since v3 (available at
> https://lore.kernel.org/all/cover.1793030820.git.u.kleine-koenig@baylibre.com):
>
> [...]
Applied, thanks!
[01/23] gpio: Remove __maybe_unused annotations from acpi_device_id arrays
https://git.kernel.org/brgl/c/c563f9a7ebdb8de36042b685c89b29a56bb4a2d8
[02/23] gpio: fxl6408: Remove __maybe_unused annotations from of_device_id array
https://git.kernel.org/brgl/c/9ae231ac040cbdd9e24dda8a76e5b0a52195fca3
[03/23] gpio: Drop unused assignment of acpi_device_id driver data
https://git.kernel.org/brgl/c/7a2dac6de054da359a0f986dc9b8fe7a1c2a97e4
[04/23] gpio: max7301: Drop unused assignment of spi_device_id driver data
https://git.kernel.org/brgl/c/9d6f21a8154ebcf777d9836f2c804f65c4173b02
[05/23] gpio: mmio: Drop unused assignment of platform_device_id driver data
https://git.kernel.org/brgl/c/9d14e246391f0caafcffa7fe5211b32d246fb327
[06/23] gpio: ljca: Drop unused assignment of auxiliary_device_id driver data
https://git.kernel.org/brgl/c/526fd5a299da4e954a66124464fc272b9d6ec529
[07/23] gpio: xgene: Add missing ACPI module annotation
https://git.kernel.org/brgl/c/c7b4f8ea5725363bb7209be26cd57428e534eb4c
[08/23] gpio: sodaville: Add missing PCI module annotations
https://git.kernel.org/brgl/c/77e387153e2a871d1bd84fa170d1e0c2ba2cf78d
[09/23] gpio: Add missing OF module annotations
https://git.kernel.org/brgl/c/93ff9d3beb2a20c7cc5a5d60e81de8ba8e770338
[10/23] gpio: pxa: Add missing platform module annotations
https://git.kernel.org/brgl/c/1a93b8060780bc50b9348d28224986a3552f5d87
[11/23] gpio: pl061: Use empty initializer for amba_id terminator
https://git.kernel.org/brgl/c/501a0376a582abee825d25fba42ab6f9f80433be
[12/23] gpio: Use named initializers for acpi_device_id array
https://git.kernel.org/brgl/c/91f7e7fb10592850a7d9075e16aee5fbe83f1e9a
[13/23] gpio: Use named initializers for auxiliary_device_id arrays
https://git.kernel.org/brgl/c/b3ef6bfd0e14450debf728225894b70a3379f514
[14/23] gpio: pcf857x: Use named initializers for of_device_id array
https://git.kernel.org/brgl/c/5b2dcd61c2105f5b17591c3c44b10630d68001f7
[15/23] gpio: bd73800: Use named initializers for platform_device_id array
https://git.kernel.org/brgl/c/92aa1d97bd10195df229851f4e008914a0e8445f
[16/23] gpio: Use named initializers for spi_device_id array
https://git.kernel.org/brgl/c/7b86d1e3c33b95a85a5a3e6f72afdcc2ff717e0d
[17/23] gpio: virtio: Use a named initializer for virtio_device_id array
https://git.kernel.org/brgl/c/7c01eb6861833cfb9d00673fbf8aef0b3e330dbe
[18/23] gpio: Unify style of acpi_device_id arrays
https://git.kernel.org/brgl/c/6588211f4fe51a881ca56648dcc5a8fa1479d4e2
[19/23] gpio: Unify style of of_device_id arrays
https://git.kernel.org/brgl/c/aee4187b00011bb65ee1aef578b1fceafae76fba
[20/23] gpio: max77620: Unify style of platform_device_id array
https://git.kernel.org/brgl/c/1b454163287b3839bdfd219e3520456ce251bbe5
[21/23] gpio: Unify style of spi_device_id arrays
https://git.kernel.org/brgl/c/17d6308e7d5a4d4f317c7f92cbca330bffcfc391
[22/23] gpio: Unify style of pci_device_id arrays
https://git.kernel.org/brgl/c/aff8eccdb976f43298117b52a7bae6d13ca62554
[23/23] gpio: Unify style of various *_device_id arrays
https://git.kernel.org/brgl/c/0fa38ba784896f2fc32c9dacd33822f844b21906
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 9+ messages in thread