* [PATCH] selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned
@ 2015-10-01 7:33 Chunyan Zhang
[not found] ` <1443684782-10898-1-git-send-email-zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Chunyan Zhang @ 2015-10-01 7:33 UTC (permalink / raw)
To: shuahkh; +Cc: linux-api, linux-kernel
There is a mandate of 16-byte aligned stack on AArch64 [1], so the
STACK_SIZE here should also be 16-byte aligned, otherwise we would
get an error when calling clone().
[1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L265
Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
---
tools/testing/selftests/memfd/memfd_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
index 0b9eafb..aa5d3eb 100644
--- a/tools/testing/selftests/memfd/memfd_test.c
+++ b/tools/testing/selftests/memfd/memfd_test.c
@@ -18,7 +18,7 @@
#include <unistd.h>
#define MFD_DEF_SIZE 8192
-#define STACK_SIZE 65535
+#define STACK_SIZE 65536
static int sys_memfd_create(const char *name,
unsigned int flags)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned
[not found] ` <1443684782-10898-1-git-send-email-zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2015-10-15 3:22 ` Chunyan Zhang
2015-10-15 8:44 ` Arnd Bergmann
1 sibling, 0 replies; 4+ messages in thread
From: Chunyan Zhang @ 2015-10-15 3:22 UTC (permalink / raw)
To: shuahkh-JPH+aEBZ4P+UEJcrhfAQsw
Cc: linux-api-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Hello Shuah,
Can this patch be allowed to merge into next realse?
Thanks,
Chunyan
On Thu, Oct 1, 2015 at 3:33 PM, Chunyan Zhang <zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> There is a mandate of 16-byte aligned stack on AArch64 [1], so the
> STACK_SIZE here should also be 16-byte aligned, otherwise we would
> get an error when calling clone().
>
> [1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L265
>
> Signed-off-by: Chunyan Zhang <zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> tools/testing/selftests/memfd/memfd_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
> index 0b9eafb..aa5d3eb 100644
> --- a/tools/testing/selftests/memfd/memfd_test.c
> +++ b/tools/testing/selftests/memfd/memfd_test.c
> @@ -18,7 +18,7 @@
> #include <unistd.h>
>
> #define MFD_DEF_SIZE 8192
> -#define STACK_SIZE 65535
> +#define STACK_SIZE 65536
>
> static int sys_memfd_create(const char *name,
> unsigned int flags)
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned
[not found] ` <1443684782-10898-1-git-send-email-zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-10-15 3:22 ` Chunyan Zhang
@ 2015-10-15 8:44 ` Arnd Bergmann
2015-10-15 13:50 ` Shuah Khan
1 sibling, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2015-10-15 8:44 UTC (permalink / raw)
To: Chunyan Zhang
Cc: shuahkh-JPH+aEBZ4P+UEJcrhfAQsw, linux-api-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Thursday 01 October 2015 15:33:02 Chunyan Zhang wrote:
> There is a mandate of 16-byte aligned stack on AArch64 [1], so the
> STACK_SIZE here should also be 16-byte aligned, otherwise we would
> get an error when calling clone().
>
> [1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L265
>
> Signed-off-by: Chunyan Zhang <zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
Acked-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
This should probably also be marked
Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned
2015-10-15 8:44 ` Arnd Bergmann
@ 2015-10-15 13:50 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2015-10-15 13:50 UTC (permalink / raw)
To: Arnd Bergmann, Chunyan Zhang
Cc: linux-api-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Shuah Khan
On 10/15/2015 02:44 AM, Arnd Bergmann wrote:
> On Thursday 01 October 2015 15:33:02 Chunyan Zhang wrote:
>> There is a mandate of 16-byte aligned stack on AArch64 [1], so the
>> STACK_SIZE here should also be 16-byte aligned, otherwise we would
>> get an error when calling clone().
>>
>> [1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L265
>>
>> Signed-off-by: Chunyan Zhang <zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>
>
> Acked-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
>
> This should probably also be marked
>
> Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>
Thank you both. Now applied to linux-kselftest next for 4.4
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-15 13:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-01 7:33 [PATCH] selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned Chunyan Zhang
[not found] ` <1443684782-10898-1-git-send-email-zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-10-15 3:22 ` Chunyan Zhang
2015-10-15 8:44 ` Arnd Bergmann
2015-10-15 13:50 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox