[PATCH] selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned

[PATCH] selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned

[Chunyan Zhang]

There is a mandate of 16-byte aligned stack on AArch64 [1], so the
STACK_SIZE here should also be 16-byte aligned, otherwise we would
get an error when calling clone().

[1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L265

Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
---
 tools/testing/selftests/memfd/memfd_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
index 0b9eafb..aa5d3eb 100644
--- a/tools/testing/selftests/memfd/memfd_test.c
+++ b/tools/testing/selftests/memfd/memfd_test.c
@@ -18,7 +18,7 @@
 #include <unistd.h>
 
 #define MFD_DEF_SIZE 8192
-#define STACK_SIZE 65535
+#define STACK_SIZE 65536
 
 static int sys_memfd_create(const char *name,
 			    unsigned int flags)
-- 
1.9.1

Re: [PATCH] selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned

[Chunyan Zhang]

Hello Shuah,

Can this patch be allowed to merge into next realse?

Thanks,
Chunyan

On Thu, Oct 1, 2015 at 3:33 PM, Chunyan Zhang <zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> There is a mandate of 16-byte aligned stack on AArch64 [1], so the
> STACK_SIZE here should also be 16-byte aligned, otherwise we would
> get an error when calling clone().
>
> [1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L265
>
> Signed-off-by: Chunyan Zhang <zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  tools/testing/selftests/memfd/memfd_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
> index 0b9eafb..aa5d3eb 100644
> --- a/tools/testing/selftests/memfd/memfd_test.c
> +++ b/tools/testing/selftests/memfd/memfd_test.c
> @@ -18,7 +18,7 @@
>  #include <unistd.h>
>
>  #define MFD_DEF_SIZE 8192
> -#define STACK_SIZE 65535
> +#define STACK_SIZE 65536
>
>  static int sys_memfd_create(const char *name,
>                             unsigned int flags)
> --
> 1.9.1
>

Re: [PATCH] selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned

[Arnd Bergmann]

On Thursday 01 October 2015 15:33:02 Chunyan Zhang wrote:
> There is a mandate of 16-byte aligned stack on AArch64 [1], so the
> STACK_SIZE here should also be 16-byte aligned, otherwise we would
> get an error when calling clone().
> 
> [1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L265
> 
> Signed-off-by: Chunyan Zhang <zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> 

Acked-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>

This should probably also be marked

Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

Re: [PATCH] selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned

[Shuah Khan]

On 10/15/2015 02:44 AM, Arnd Bergmann wrote:
> On Thursday 01 October 2015 15:33:02 Chunyan Zhang wrote:
>> There is a mandate of 16-byte aligned stack on AArch64 [1], so the
>> STACK_SIZE here should also be 16-byte aligned, otherwise we would
>> get an error when calling clone().
>>
>> [1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L265
>>
>> Signed-off-by: Chunyan Zhang <zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>
> 
> Acked-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> 
> This should probably also be marked
> 
> Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> 

Thank you both. Now applied to linux-kselftest next for 4.4

-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978