public inbox for linux-api@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH v2 1/2] man/man3/errno.3: Document EFTYPE error code
       [not found]     ` <lhu5x5c4rpl.fsf@oldenburg.str.redhat.com>
@ 2026-04-27 13:13       ` Alejandro Colomar
  2026-04-27 13:29         ` Florian Weimer
  0 siblings, 1 reply; 3+ messages in thread
From: Alejandro Colomar @ 2026-04-27 13:13 UTC (permalink / raw)
  To: Florian Weimer
  Cc: Dorjoy Chowdhury, linux-man, brauner, jlayton, libc-alpha,
	linux-api

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

Hi Florian,

On 2026-04-27T12:34:30+0200, Florian Weimer wrote:
> * Alejandro Colomar:
> 
> > [CC += libc-alpha]
> >
> > Hi Dorjoy,
> >
> > On 2026-04-26T17:14:25+0600, Dorjoy Chowdhury wrote:
> >> Signed-off-by: Dorjoy Chowdhury <dorjoychy111@gmail.com>
> >
> > Thanks!
> >
> > 	Reviewed-by: Alejandro Colomar <alx@kernel.org>
> >
> > I will wait until glibc adds this error code to their <errno.h> before
> > applying the patch.  This means either you should write and send a patch
> > to glibc (if so, please CC me), or you should ask them to add it
> > themselves (if you're not comfortable writing glibc code).
> 
> I'm not sure where this is coming from.

Here's a link to the thread:
<https://lore.kernel.org/linux-man/20260426111707.36541-1-dorjoychy111@gmail.com/T/>

> POSIX says EFTYPE was rejected
> in favor of ENOTTY.

Could you please share a link to that?

Anyway, I guess ENOTTY would be inappropriate in this case.  Although
maybe a better error code could be devised; I don't know.  This is why
I wanted glibc involved in this discussion before this arrives to a
Linux release.  Thanks for the quick feedback!


> Thanks,
> Florian

Have a lovely day!
Alex

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/2] man/man3/errno.3: Document EFTYPE error code
  2026-04-27 13:13       ` [PATCH v2 1/2] man/man3/errno.3: Document EFTYPE error code Alejandro Colomar
@ 2026-04-27 13:29         ` Florian Weimer
  2026-04-27 13:33           ` Alejandro Colomar
  0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer @ 2026-04-27 13:29 UTC (permalink / raw)
  To: Alejandro Colomar
  Cc: Dorjoy Chowdhury, linux-man, brauner, jlayton, libc-alpha,
	linux-api

* Alejandro Colomar:

> Hi Florian,
>
> On 2026-04-27T12:34:30+0200, Florian Weimer wrote:
>> * Alejandro Colomar:
>> 
>> > [CC += libc-alpha]
>> >
>> > Hi Dorjoy,
>> >
>> > On 2026-04-26T17:14:25+0600, Dorjoy Chowdhury wrote:
>> >> Signed-off-by: Dorjoy Chowdhury <dorjoychy111@gmail.com>
>> >
>> > Thanks!
>> >
>> > 	Reviewed-by: Alejandro Colomar <alx@kernel.org>
>> >
>> > I will wait until glibc adds this error code to their <errno.h> before
>> > applying the patch.  This means either you should write and send a patch
>> > to glibc (if so, please CC me), or you should ask them to add it
>> > themselves (if you're not comfortable writing glibc code).
>> 
>> I'm not sure where this is coming from.
>
> Here's a link to the thread:
> <https://lore.kernel.org/linux-man/20260426111707.36541-1-dorjoychy111@gmail.com/T/>
>
>> POSIX says EFTYPE was rejected
>> in favor of ENOTTY.
>
> Could you please share a link to that?
>
> Anyway, I guess ENOTTY would be inappropriate in this case.  Although
> maybe a better error code could be devised; I don't know.  This is why
> I wanted glibc involved in this discussion before this arrives to a
> Linux release.  Thanks for the quick feedback!

It's in the Rationale for System Interfaces:

“
[EFTYPE]
    This error code was proposed in earlier proposals as "Inappropriate
    operation for file type", meaning that the operation requested is
    not appropriate for the file specified in the function call. This
    code was proposed, although the same idea was covered by [ENOTTY],
    because the connotations of the name would be misleading. It was
    pointed out that the fcntl() function uses the error code [EINVAL]
    for this notion, and hence all instances of [EFTYPE] were changed to
    this code.
”

I replied on linux-fsdevel, too.

(It would be nice to submit patches introducing new error codes to
linux-api with a subject mentioning the error code.)

Thanks,
Florian


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/2] man/man3/errno.3: Document EFTYPE error code
  2026-04-27 13:29         ` Florian Weimer
@ 2026-04-27 13:33           ` Alejandro Colomar
  0 siblings, 0 replies; 3+ messages in thread
From: Alejandro Colomar @ 2026-04-27 13:33 UTC (permalink / raw)
  To: Florian Weimer
  Cc: Dorjoy Chowdhury, linux-man, brauner, jlayton, libc-alpha,
	linux-api

[-- Attachment #1: Type: text/plain, Size: 2349 bytes --]

Hi Florian,

On 2026-04-27T15:29:30+0200, Florian Weimer wrote:
> * Alejandro Colomar:
> 
> > Hi Florian,
> >
> > On 2026-04-27T12:34:30+0200, Florian Weimer wrote:
> >> * Alejandro Colomar:
> >> 
> >> > [CC += libc-alpha]
> >> >
> >> > Hi Dorjoy,
> >> >
> >> > On 2026-04-26T17:14:25+0600, Dorjoy Chowdhury wrote:
> >> >> Signed-off-by: Dorjoy Chowdhury <dorjoychy111@gmail.com>
> >> >
> >> > Thanks!
> >> >
> >> > 	Reviewed-by: Alejandro Colomar <alx@kernel.org>
> >> >
> >> > I will wait until glibc adds this error code to their <errno.h> before
> >> > applying the patch.  This means either you should write and send a patch
> >> > to glibc (if so, please CC me), or you should ask them to add it
> >> > themselves (if you're not comfortable writing glibc code).
> >> 
> >> I'm not sure where this is coming from.
> >
> > Here's a link to the thread:
> > <https://lore.kernel.org/linux-man/20260426111707.36541-1-dorjoychy111@gmail.com/T/>
> >
> >> POSIX says EFTYPE was rejected
> >> in favor of ENOTTY.
> >
> > Could you please share a link to that?
> >
> > Anyway, I guess ENOTTY would be inappropriate in this case.  Although
> > maybe a better error code could be devised; I don't know.  This is why
> > I wanted glibc involved in this discussion before this arrives to a
> > Linux release.  Thanks for the quick feedback!
> 
> It's in the Rationale for System Interfaces:
> 
> “
> [EFTYPE]
>     This error code was proposed in earlier proposals as "Inappropriate
>     operation for file type", meaning that the operation requested is
>     not appropriate for the file specified in the function call. This
>     code was proposed, although the same idea was covered by [ENOTTY],
>     because the connotations of the name would be misleading. It was
>     pointed out that the fcntl() function uses the error code [EINVAL]
>     for this notion, and hence all instances of [EFTYPE] were changed to
>     this code.
> ”
> 
> I replied on linux-fsdevel, too.

Thanks!

> 
> (It would be nice to submit patches introducing new error codes to
> linux-api with a subject mentioning the error code.)

Thanks!  I'll remember this advice for when receiving patches that add
error codes.

> 
> Thanks,
> Florian

Cheers,
Alex

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-27 13:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20260426111707.36541-1-dorjoychy111@gmail.com>
     [not found] ` <20260426111707.36541-2-dorjoychy111@gmail.com>
     [not found]   ` <ae4K_5f1g3zgSNkC@devuan>
     [not found]     ` <lhu5x5c4rpl.fsf@oldenburg.str.redhat.com>
2026-04-27 13:13       ` [PATCH v2 1/2] man/man3/errno.3: Document EFTYPE error code Alejandro Colomar
2026-04-27 13:29         ` Florian Weimer
2026-04-27 13:33           ` Alejandro Colomar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox