Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pinctrl: rockchip: Fix pull configuration readback on RK3506
@ 2026-11-21 15:58 Jonas Karlman
  2026-11-21 16:09 ` Heiko Stübner
  0 siblings, 1 reply; 2+ messages in thread
From: Jonas Karlman @ 2026-11-21 15:58 UTC (permalink / raw)
  To: Heiko Stuebner, Linus Walleij, Ye Zhang
  Cc: linux-gpio, linux-rockchip, linux-arm-kernel, Jonas Karlman

rockchip_get_pull() is missing a RK3506 case and instead returns -EINVAL
for all pins. As a result, the pinconf-pins debugfs file omits the pull
configuration for all pins on RK3506:

  pin 0 (gpio0-0): ..., pin output (1 level)
  pin 1 (gpio0-1): ..., pin output (1 level)
  pin 2 (gpio0-2): ..., pin output (1 level)
  pin 3 (gpio0-3): ..., pin output (0 level)

Add RK3506 to the case that decodes the pull configuration from the
register value to fix pull configuration readback on RK3506.

After this the pinconf-pins debugfs file includes pull configuration:

  pin 0 (gpio0-0): input bias pull up (1 ohms), ..., pin output (1 level)
  pin 1 (gpio0-1): input bias pull down (1 ohms), ..., pin output (1 level)
  pin 2 (gpio0-2): input bias pull up (1 ohms), ..., pin output (1 level)
  pin 3 (gpio0-3): input bias pull down (1 ohms), ..., pin output (0 level)

Fixes: dbd2317d7b9f ("pinctrl: rockchip: Add rk3506 pinctrl support")
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
---
Based-on: <20261120201540.672016-1-jonas@kwiboo.se>
---
 drivers/pinctrl/pinctrl-rockchip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index 97a73f8c4f6e..cad602fa41ae 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -3910,6 +3910,7 @@ static int rockchip_get_pull(struct rockchip_pin_bank *bank, int pin_num)
 	case RK3328:
 	case RK3368:
 	case RK3399:
+	case RK3506:
 	case RK3528:
 	case RK3562:
 	case RK3568:
-- 
2.56.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] pinctrl: rockchip: Fix pull configuration readback on RK3506
  2026-11-21 15:58 [PATCH] pinctrl: rockchip: Fix pull configuration readback on RK3506 Jonas Karlman
@ 2026-11-21 16:09 ` Heiko Stübner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stübner @ 2026-11-21 16:09 UTC (permalink / raw)
  To: Linus Walleij, Ye Zhang, Jonas Karlman
  Cc: linux-gpio, linux-rockchip, linux-arm-kernel, Jonas Karlman

Am Samstag, 21. November 2026, 16:58:09 Mitteleuropäische Normalzeit schrieb Jonas Karlman:
> rockchip_get_pull() is missing a RK3506 case and instead returns -EINVAL
> for all pins. As a result, the pinconf-pins debugfs file omits the pull
> configuration for all pins on RK3506:
> 
>   pin 0 (gpio0-0): ..., pin output (1 level)
>   pin 1 (gpio0-1): ..., pin output (1 level)
>   pin 2 (gpio0-2): ..., pin output (1 level)
>   pin 3 (gpio0-3): ..., pin output (0 level)
> 
> Add RK3506 to the case that decodes the pull configuration from the
> register value to fix pull configuration readback on RK3506.
> 
> After this the pinconf-pins debugfs file includes pull configuration:
> 
>   pin 0 (gpio0-0): input bias pull up (1 ohms), ..., pin output (1 level)
>   pin 1 (gpio0-1): input bias pull down (1 ohms), ..., pin output (1 level)
>   pin 2 (gpio0-2): input bias pull up (1 ohms), ..., pin output (1 level)
>   pin 3 (gpio0-3): input bias pull down (1 ohms), ..., pin output (0 level)
> 
> Fixes: dbd2317d7b9f ("pinctrl: rockchip: Add rk3506 pinctrl support")
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>

rockchip_set_pull has that case statenment, rockchip_get_pull is
missing it.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-21 16:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21 15:58 [PATCH] pinctrl: rockchip: Fix pull configuration readback on RK3506 Jonas Karlman
2026-11-21 16:09 ` Heiko Stübner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox