* [PATCH] Another small regulators update for Goni board @ 2011-02-15 9:06 Marek Szyprowski 2011-02-15 9:06 ` [PATCH 1/2] ARM: S5PC110: disable unused power regulators on " Marek Szyprowski 2011-02-15 9:06 ` [PATCH 2/2] ARM: S5PC110: add power consumers for hsotg for " Marek Szyprowski 0 siblings, 2 replies; 6+ messages in thread From: Marek Szyprowski @ 2011-02-15 9:06 UTC (permalink / raw) To: linux-arm-kernel Hello, This small patch series updates regulator definitions on Goni board. The first one disables all unused regulators, the second one add support for regualtors for s3c-hsotg driver. Best regards -- Marek Szyprowski Samsung Poland R&D Center ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: S5PC110: disable unused power regulators on Goni board 2011-02-15 9:06 [PATCH] Another small regulators update for Goni board Marek Szyprowski @ 2011-02-15 9:06 ` Marek Szyprowski 2011-02-23 10:23 ` Kukjin Kim 2011-02-15 9:06 ` [PATCH 2/2] ARM: S5PC110: add power consumers for hsotg for " Marek Szyprowski 1 sibling, 1 reply; 6+ messages in thread From: Marek Szyprowski @ 2011-02-15 9:06 UTC (permalink / raw) To: linux-arm-kernel A lot of power regulator has been enabled by default causing the board to consume a lot of power. This patch fixes this issue. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-s5pv210/mach-goni.c | 10 +--------- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c index 43c1c1b..10f754b 100644 --- a/arch/arm/mach-s5pv210/mach-goni.c +++ b/arch/arm/mach-s5pv210/mach-goni.c @@ -292,7 +292,6 @@ static struct regulator_init_data goni_ldo3_data = { .min_uV = 1100000, .max_uV = 1100000, .apply_uV = 1, - .always_on = 1, }, }; @@ -311,6 +310,7 @@ static struct regulator_init_data goni_ldo5_data = { .min_uV = 2800000, .max_uV = 2800000, .apply_uV = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, }, .num_consumer_supplies = ARRAY_SIZE(goni_ldo5_consumers), .consumer_supplies = goni_ldo5_consumers, @@ -341,7 +341,6 @@ static struct regulator_init_data goni_ldo8_data = { .min_uV = 3300000, .max_uV = 3300000, .apply_uV = 1, - .always_on = 1, }, }; @@ -351,7 +350,6 @@ static struct regulator_init_data goni_ldo9_data = { .min_uV = 2800000, .max_uV = 2800000, .apply_uV = 1, - .always_on = 1, }, }; @@ -371,7 +369,6 @@ static struct regulator_init_data goni_ldo11_data = { .min_uV = 2800000, .max_uV = 2800000, .apply_uV = 1, - .always_on = 1, }, }; @@ -381,7 +378,6 @@ static struct regulator_init_data goni_ldo12_data = { .min_uV = 1200000, .max_uV = 1200000, .apply_uV = 1, - .always_on = 1, }, }; @@ -391,7 +387,6 @@ static struct regulator_init_data goni_ldo13_data = { .min_uV = 2800000, .max_uV = 2800000, .apply_uV = 1, - .always_on = 1, }, }; @@ -401,7 +396,6 @@ static struct regulator_init_data goni_ldo14_data = { .min_uV = 1800000, .max_uV = 1800000, .apply_uV = 1, - .always_on = 1, }, }; @@ -411,7 +405,6 @@ static struct regulator_init_data goni_ldo15_data = { .min_uV = 3300000, .max_uV = 3300000, .apply_uV = 1, - .always_on = 1, }, }; @@ -421,7 +414,6 @@ static struct regulator_init_data goni_ldo16_data = { .min_uV = 1800000, .max_uV = 1800000, .apply_uV = 1, - .always_on = 1, }, }; -- 1.7.1.569.g6f426 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: S5PC110: disable unused power regulators on Goni board 2011-02-15 9:06 ` [PATCH 1/2] ARM: S5PC110: disable unused power regulators on " Marek Szyprowski @ 2011-02-23 10:23 ` Kukjin Kim 2011-02-24 1:33 ` Kukjin Kim 0 siblings, 1 reply; 6+ messages in thread From: Kukjin Kim @ 2011-02-23 10:23 UTC (permalink / raw) To: linux-arm-kernel Marek Szyprowski wrote: > > A lot of power regulator has been enabled by default causing the board > to consume a lot of power. This patch fixes this issue. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/mach-s5pv210/mach-goni.c | 10 +--------- > 1 files changed, 1 insertions(+), 9 deletions(-) > > diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach- > goni.c > index 43c1c1b..10f754b 100644 > --- a/arch/arm/mach-s5pv210/mach-goni.c > +++ b/arch/arm/mach-s5pv210/mach-goni.c > @@ -292,7 +292,6 @@ static struct regulator_init_data goni_ldo3_data = { > .min_uV = 1100000, > .max_uV = 1100000, > .apply_uV = 1, > - .always_on = 1, > }, > }; > > @@ -311,6 +310,7 @@ static struct regulator_init_data goni_ldo5_data = { > .min_uV = 2800000, > .max_uV = 2800000, > .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > }, > .num_consumer_supplies = ARRAY_SIZE(goni_ldo5_consumers), > .consumer_supplies = goni_ldo5_consumers, > @@ -341,7 +341,6 @@ static struct regulator_init_data goni_ldo8_data = { > .min_uV = 3300000, > .max_uV = 3300000, > .apply_uV = 1, > - .always_on = 1, > }, > }; > > @@ -351,7 +350,6 @@ static struct regulator_init_data goni_ldo9_data = { > .min_uV = 2800000, > .max_uV = 2800000, > .apply_uV = 1, > - .always_on = 1, > }, > }; > > @@ -371,7 +369,6 @@ static struct regulator_init_data goni_ldo11_data = { > .min_uV = 2800000, > .max_uV = 2800000, > .apply_uV = 1, > - .always_on = 1, > }, > }; > > @@ -381,7 +378,6 @@ static struct regulator_init_data goni_ldo12_data = { > .min_uV = 1200000, > .max_uV = 1200000, > .apply_uV = 1, > - .always_on = 1, > }, > }; > > @@ -391,7 +387,6 @@ static struct regulator_init_data goni_ldo13_data = { > .min_uV = 2800000, > .max_uV = 2800000, > .apply_uV = 1, > - .always_on = 1, > }, > }; > > @@ -401,7 +396,6 @@ static struct regulator_init_data goni_ldo14_data = { > .min_uV = 1800000, > .max_uV = 1800000, > .apply_uV = 1, > - .always_on = 1, > }, > }; > > @@ -411,7 +405,6 @@ static struct regulator_init_data goni_ldo15_data = { > .min_uV = 3300000, > .max_uV = 3300000, > .apply_uV = 1, > - .always_on = 1, > }, > }; > > @@ -421,7 +414,6 @@ static struct regulator_init_data goni_ldo16_data = { > .min_uV = 1800000, > .max_uV = 1800000, > .apply_uV = 1, > - .always_on = 1, > }, > }; > > -- Ok...will apply this. And how about "mach-aquila.c"? Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: S5PC110: disable unused power regulators on Goni board 2011-02-23 10:23 ` Kukjin Kim @ 2011-02-24 1:33 ` Kukjin Kim 0 siblings, 0 replies; 6+ messages in thread From: Kukjin Kim @ 2011-02-24 1:33 UTC (permalink / raw) To: linux-arm-kernel Kukjin Kim wrote: > > Marek Szyprowski wrote: > > > > A lot of power regulator has been enabled by default causing the board > > to consume a lot of power. This patch fixes this issue. > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > --- > > arch/arm/mach-s5pv210/mach-goni.c | 10 +--------- > > 1 files changed, 1 insertions(+), 9 deletions(-) (snip) > > @@ -371,7 +369,6 @@ static struct regulator_init_data goni_ldo11_data = { > > .min_uV = 2800000, > > .max_uV = 2800000, > > .apply_uV = 1, > > - .always_on = 1, > > }, > > }; Oops, already merged above changes by Sylwester's "Add supplies for CIF camera on GONI board" into my for-next. So will apply this with removing above changes. (snip) > > @@ -391,7 +387,6 @@ static struct regulator_init_data goni_ldo13_data = { > > .min_uV = 2800000, > > .max_uV = 2800000, > > .apply_uV = 1, > > - .always_on = 1, > > }, > > }; Same as above. > > @@ -401,7 +396,6 @@ static struct regulator_init_data goni_ldo14_data = { > > .min_uV = 1800000, > > .max_uV = 1800000, > > .apply_uV = 1, > > - .always_on = 1, > > }, > > }; Same as above. (snip) > > -- > > Ok...will apply this. > And how about "mach-aquila.c"? > Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: S5PC110: add power consumers for hsotg for Goni board 2011-02-15 9:06 [PATCH] Another small regulators update for Goni board Marek Szyprowski 2011-02-15 9:06 ` [PATCH 1/2] ARM: S5PC110: disable unused power regulators on " Marek Szyprowski @ 2011-02-15 9:06 ` Marek Szyprowski 2011-02-23 10:27 ` Kukjin Kim 1 sibling, 1 reply; 6+ messages in thread From: Marek Szyprowski @ 2011-02-15 9:06 UTC (permalink / raw) To: linux-arm-kernel This patch adds definitions for power consumers for s3c-hsotg driver on Goni board. The consumers are defined as arrays, because later more entries for MIPI and ADC will be defined. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-s5pv210/mach-goni.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c index 10f754b..796625c 100644 --- a/arch/arm/mach-s5pv210/mach-goni.c +++ b/arch/arm/mach-s5pv210/mach-goni.c @@ -269,10 +269,18 @@ static void __init goni_tsp_init(void) /* MAX8998 regulators */ #if defined(CONFIG_REGULATOR_MAX8998) || defined(CONFIG_REGULATOR_MAX8998_MODULE) +static struct regulator_consumer_supply goni_ldo3_consumers[] = { + REGULATOR_SUPPLY("vusb_a", "s3c-hsotg"), +}; + static struct regulator_consumer_supply goni_ldo5_consumers[] = { REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"), }; +static struct regulator_consumer_supply goni_ldo8_consumers[] = { + REGULATOR_SUPPLY("vusb_d", "s3c-hsotg"), +}; + static struct regulator_init_data goni_ldo2_data = { .constraints = { .name = "VALIVE_1.1V", @@ -292,7 +300,10 @@ static struct regulator_init_data goni_ldo3_data = { .min_uV = 1100000, .max_uV = 1100000, .apply_uV = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, }, + .num_consumer_supplies = ARRAY_SIZE(goni_ldo3_consumers), + .consumer_supplies = goni_ldo3_consumers, }; static struct regulator_init_data goni_ldo4_data = { @@ -341,7 +352,10 @@ static struct regulator_init_data goni_ldo8_data = { .min_uV = 3300000, .max_uV = 3300000, .apply_uV = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, }, + .num_consumer_supplies = ARRAY_SIZE(goni_ldo8_consumers), + .consumer_supplies = goni_ldo8_consumers, }; static struct regulator_init_data goni_ldo9_data = { -- 1.7.1.569.g6f426 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: S5PC110: add power consumers for hsotg for Goni board 2011-02-15 9:06 ` [PATCH 2/2] ARM: S5PC110: add power consumers for hsotg for " Marek Szyprowski @ 2011-02-23 10:27 ` Kukjin Kim 0 siblings, 0 replies; 6+ messages in thread From: Kukjin Kim @ 2011-02-23 10:27 UTC (permalink / raw) To: linux-arm-kernel Marek Szyprowski wrote: > > This patch adds definitions for power consumers for s3c-hsotg driver > on Goni board. The consumers are defined as arrays, because later more > entries for MIPI and ADC will be defined. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/mach-s5pv210/mach-goni.c | 14 ++++++++++++++ > 1 files changed, 14 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach- > goni.c > index 10f754b..796625c 100644 > --- a/arch/arm/mach-s5pv210/mach-goni.c > +++ b/arch/arm/mach-s5pv210/mach-goni.c > @@ -269,10 +269,18 @@ static void __init goni_tsp_init(void) > /* MAX8998 regulators */ > #if defined(CONFIG_REGULATOR_MAX8998) || > defined(CONFIG_REGULATOR_MAX8998_MODULE) > > +static struct regulator_consumer_supply goni_ldo3_consumers[] = { > + REGULATOR_SUPPLY("vusb_a", "s3c-hsotg"), > +}; > + > static struct regulator_consumer_supply goni_ldo5_consumers[] = { > REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"), > }; > > +static struct regulator_consumer_supply goni_ldo8_consumers[] = { > + REGULATOR_SUPPLY("vusb_d", "s3c-hsotg"), > +}; > + > static struct regulator_init_data goni_ldo2_data = { > .constraints = { > .name = "VALIVE_1.1V", > @@ -292,7 +300,10 @@ static struct regulator_init_data goni_ldo3_data = { > .min_uV = 1100000, > .max_uV = 1100000, > .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > }, > + .num_consumer_supplies = ARRAY_SIZE(goni_ldo3_consumers), > + .consumer_supplies = goni_ldo3_consumers, > }; > > static struct regulator_init_data goni_ldo4_data = { > @@ -341,7 +352,10 @@ static struct regulator_init_data goni_ldo8_data = { > .min_uV = 3300000, > .max_uV = 3300000, > .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > }, > + .num_consumer_supplies = ARRAY_SIZE(goni_ldo8_consumers), > + .consumer_supplies = goni_ldo8_consumers, > }; > > static struct regulator_init_data goni_ldo9_data = { > -- Ok...will apply :) Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-02-24 1:33 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-02-15 9:06 [PATCH] Another small regulators update for Goni board Marek Szyprowski 2011-02-15 9:06 ` [PATCH 1/2] ARM: S5PC110: disable unused power regulators on " Marek Szyprowski 2011-02-23 10:23 ` Kukjin Kim 2011-02-24 1:33 ` Kukjin Kim 2011-02-15 9:06 ` [PATCH 2/2] ARM: S5PC110: add power consumers for hsotg for " Marek Szyprowski 2011-02-23 10:27 ` Kukjin Kim
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox