[PATCH 1/2] dt-bindings: power: fsl,imx-gpc: Document address-cells

[PATCH 1/2] dt-bindings: power: fsl,imx-gpc: Document address-cells

[Alexander Stein]

The GPC power controller is an interrupt controllers and can be referenced
in interrupt-map properties, e.g. PCIe controller, thus the node should
have address-cells property.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
index 9de3fe73c1eb6..d49a5130b87c7 100644
--- a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
+++ b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
@@ -38,6 +38,9 @@ properties:
   reg:
     maxItems: 1
 
+  "#address-cells":
+    const: 0
+
   interrupts:
     maxItems: 1
 
-- 
2.43.0

[PATCH 2/2] ARM: dts: imx6qdl: Add default GIC address cells

[Alexander Stein]

Add missing address-cells 0 to GPC interrupt node to silence W=1
warning:

  imx6qdl.dtsi:281.4-284.29: Warning (interrupt_map): /soc/pcie@1ffc000:interrupt-map:
    Missing property '#address-cells' in node /soc/bus@2000000/gpc@20dc000, using 0 as fallback

Value '0' is correct because:
1. GPC interrupt controller children are only power domains,
2. interrupt-map property (in PCI node) consists of five components and
   the fourth component "parent unit address", which size is defined by
   '#address-cells' of the node pointed to by the interrupt-parent
   component, is not used (=0)

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
This is based on commit faf183a02ed6b ("arm64: dts: imx8mp: Add default GIC
address cells")

 arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
index 45bcfd7faf9db..9793feee63947 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
@@ -875,6 +875,7 @@ src: reset-controller@20d8000 {
 			gpc: gpc@20dc000 {
 				compatible = "fsl,imx6q-gpc";
 				reg = <0x020dc000 0x4000>;
+				#address-cells = <0>;
 				interrupt-controller;
 				#interrupt-cells = <3>;
 				interrupts = <0 89 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: power: fsl,imx-gpc: Document address-cells

[Frank Li]

On Fri, Dec 12, 2025 at 09:58:59AM +0100, Alexander Stein wrote:
> The GPC power controller is an interrupt controllers and can be referenced
> in interrupt-map properties, e.g. PCIe controller, thus the node should
> have address-cells property.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Strange, there are not #address-cells property for gic if there are not
ITS node. gic is widely used.

Does gic node also missed #address-cells?

Frank

> ---
>  Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> index 9de3fe73c1eb6..d49a5130b87c7 100644
> --- a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> @@ -38,6 +38,9 @@ properties:
>    reg:
>      maxItems: 1
>
> +  "#address-cells":
> +    const: 0
> +
>    interrupts:
>      maxItems: 1
>
> --
> 2.43.0
>

Re: [PATCH 1/2] dt-bindings: power: fsl,imx-gpc: Document address-cells

[Alexander Stein]

[-- Attachment #1: Type: text/plain, Size: 1718 bytes --]

Hi,

Am Freitag, 12. Dezember 2025, 18:02:32 CET schrieb Frank Li:
> On Fri, Dec 12, 2025 at 09:58:59AM +0100, Alexander Stein wrote:
> > The GPC power controller is an interrupt controllers and can be referenced
> > in interrupt-map properties, e.g. PCIe controller, thus the node should
> > have address-cells property.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> Strange, there are not #address-cells property for gic if there are not
> ITS node. gic is widely used.
> 
> Does gic node also missed #address-cells?

Yes and no.
Yes: see commit faf183a02ed6b ("arm64: dts: imx8mp: Add default GIC address cells")
No: AFAICS this is only necessary if an interrupt-controller is referenced
from within interrupt-map. But on imx6qdl.dtsi 'intc' (GIC) is not used that way.

Best regards,
Alexander

> 
> Frank
> 
> > ---
> >  Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> > index 9de3fe73c1eb6..d49a5130b87c7 100644
> > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> > @@ -38,6 +38,9 @@ properties:
> >    reg:
> >      maxItems: 1
> >
> > +  "#address-cells":
> > +    const: 0
> > +
> >    interrupts:
> >      maxItems: 1
> >
> > --
> > 2.43.0
> >
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] dt-bindings: power: fsl,imx-gpc: Document address-cells

[Frank Li]

On Mon, Dec 15, 2025 at 08:31:47AM +0100, Alexander Stein wrote:
> Hi,
>
> Am Freitag, 12. Dezember 2025, 18:02:32 CET schrieb Frank Li:
> > On Fri, Dec 12, 2025 at 09:58:59AM +0100, Alexander Stein wrote:
> > > The GPC power controller is an interrupt controllers and can be referenced
> > > in interrupt-map properties, e.g. PCIe controller, thus the node should
> > > have address-cells property.
> > >
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> >
> > Strange, there are not #address-cells property for gic if there are not
> > ITS node. gic is widely used.
> >
> > Does gic node also missed #address-cells?
>
> Yes and no.
> Yes: see commit faf183a02ed6b ("arm64: dts: imx8mp: Add default GIC address cells")
> No: AFAICS this is only necessary if an interrupt-controller is referenced
> from within interrupt-map. But on imx6qdl.dtsi 'intc' (GIC) is not used that way.

Thanks.

Frank

>
> Best regards,
> Alexander
>
> >
> > Frank
> >
> > > ---
> > >  Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> > > index 9de3fe73c1eb6..d49a5130b87c7 100644
> > > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> > > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> > > @@ -38,6 +38,9 @@ properties:
> > >    reg:
> > >      maxItems: 1
> > >
> > > +  "#address-cells":
> > > +    const: 0
> > > +
> > >    interrupts:
> > >      maxItems: 1
> > >
> > > --
> > > 2.43.0
> > >
> >
>
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/

Re: [PATCH 1/2] dt-bindings: power: fsl,imx-gpc: Document address-cells

[Krzysztof Kozlowski]

On Fri, Dec 12, 2025 at 09:58:59AM +0100, Alexander Stein wrote:
> The GPC power controller is an interrupt controllers and can be referenced
> in interrupt-map properties, e.g. PCIe controller, thus the node should
> have address-cells property.

You could say here that there are no children, thus using value of 0.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: power: fsl,imx-gpc: Document address-cells

[Shawn Guo]

On Fri, Dec 12, 2025 at 09:58:59AM +0100, Alexander Stein wrote:
> The GPC power controller is an interrupt controllers and can be referenced
> in interrupt-map properties, e.g. PCIe controller, thus the node should
> have address-cells property.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Applied both, thanks!