* [PATCH] phy: meson8b-usb2: fix offsets for some of the registers
@ 2017-01-13 18:53 Martin Blumenstingl
2017-02-03 20:05 ` Martin Blumenstingl
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Martin Blumenstingl @ 2017-01-13 18:53 UTC (permalink / raw)
To: linux-arm-kernel
The register offsets for REG_DBG_UART (and all following) were off by
0x4. This was not a problem yet because these registers are currently
not used by the driver.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
drivers/phy/phy-meson8b-usb2.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/phy-meson8b-usb2.c b/drivers/phy/phy-meson8b-usb2.c
index 33c9f4ba157d..30f56a6a411f 100644
--- a/drivers/phy/phy-meson8b-usb2.c
+++ b/drivers/phy/phy-meson8b-usb2.c
@@ -81,9 +81,9 @@
#define REG_ADP_BC_ACA_PIN_GND BIT(25)
#define REG_ADP_BC_ACA_PIN_FLOAT BIT(26)
-#define REG_DBG_UART 0x14
+#define REG_DBG_UART 0x10
-#define REG_TEST 0x18
+#define REG_TEST 0x14
#define REG_TEST_DATA_IN_MASK GENMASK(3, 0)
#define REG_TEST_EN_MASK GENMASK(7, 4)
#define REG_TEST_ADDR_MASK GENMASK(11, 8)
@@ -93,7 +93,7 @@
#define REG_TEST_DATA_OUT_MASK GENMASK(19, 16)
#define REG_TEST_DISABLE_ID_PULLUP BIT(20)
-#define REG_TUNE 0x1c
+#define REG_TUNE 0x18
#define REG_TUNE_TX_RES_TUNE_MASK GENMASK(1, 0)
#define REG_TUNE_TX_HSXV_TUNE_MASK GENMASK(3, 2)
#define REG_TUNE_TX_VREF_TUNE_MASK GENMASK(7, 4)
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] phy: meson8b-usb2: fix offsets for some of the registers
2017-01-13 18:53 [PATCH] phy: meson8b-usb2: fix offsets for some of the registers Martin Blumenstingl
@ 2017-02-03 20:05 ` Martin Blumenstingl
2017-02-10 9:27 ` Jerome Brunet
2017-03-04 10:20 ` [PATCH v2] " Martin Blumenstingl
2 siblings, 0 replies; 6+ messages in thread
From: Martin Blumenstingl @ 2017-02-03 20:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kishon, Hi Kevin,
did you have time to look into this yet?
On Fri, Jan 13, 2017 at 7:53 PM, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
> The register offsets for REG_DBG_UART (and all following) were off by
> 0x4. This was not a problem yet because these registers are currently
> not used by the driver.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/phy/phy-meson8b-usb2.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/phy-meson8b-usb2.c b/drivers/phy/phy-meson8b-usb2.c
> index 33c9f4ba157d..30f56a6a411f 100644
> --- a/drivers/phy/phy-meson8b-usb2.c
> +++ b/drivers/phy/phy-meson8b-usb2.c
> @@ -81,9 +81,9 @@
> #define REG_ADP_BC_ACA_PIN_GND BIT(25)
> #define REG_ADP_BC_ACA_PIN_FLOAT BIT(26)
>
> -#define REG_DBG_UART 0x14
> +#define REG_DBG_UART 0x10
>
> -#define REG_TEST 0x18
> +#define REG_TEST 0x14
> #define REG_TEST_DATA_IN_MASK GENMASK(3, 0)
> #define REG_TEST_EN_MASK GENMASK(7, 4)
> #define REG_TEST_ADDR_MASK GENMASK(11, 8)
> @@ -93,7 +93,7 @@
> #define REG_TEST_DATA_OUT_MASK GENMASK(19, 16)
> #define REG_TEST_DISABLE_ID_PULLUP BIT(20)
>
> -#define REG_TUNE 0x1c
> +#define REG_TUNE 0x18
> #define REG_TUNE_TX_RES_TUNE_MASK GENMASK(1, 0)
> #define REG_TUNE_TX_HSXV_TUNE_MASK GENMASK(3, 2)
> #define REG_TUNE_TX_VREF_TUNE_MASK GENMASK(7, 4)
> --
> 2.11.0
>
this is the struct (which represents the register mapping) from
Amlogic's kernel sources [0]:
typedef struct usb_peri_reg {
volatile uint32_t config;
volatile uint32_t ctrl;
volatile uint32_t endp_intr;
volatile uint32_t adp_bc;
volatile uint32_t dbg_uart;
volatile uint32_t test;
volatile uint32_t tune;
volatile uint32_t reserved;
} usb_peri_reg_t;
[0] https://github.com/khadas/linux/blob/b328e86796b96f3d421edba89cb015e30b0711dd/include/linux/amlogic/usb-meson8.h#L24
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] phy: meson8b-usb2: fix offsets for some of the registers
2017-01-13 18:53 [PATCH] phy: meson8b-usb2: fix offsets for some of the registers Martin Blumenstingl
2017-02-03 20:05 ` Martin Blumenstingl
@ 2017-02-10 9:27 ` Jerome Brunet
2017-03-04 10:20 ` [PATCH v2] " Martin Blumenstingl
2 siblings, 0 replies; 6+ messages in thread
From: Jerome Brunet @ 2017-02-10 9:27 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 2017-01-13 at 19:53 +0100, Martin Blumenstingl wrote:
> The register offsets for REG_DBG_UART (and all following) were off by
> 0x4. This was not a problem yet because these registers are currently
> not used by the driver.
>
> Signed-off-by: Martin Blumenstingl
> <martin.blumenstingl@googlemail.com>
Good catch ! Thx.
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> ?drivers/phy/phy-meson8b-usb2.c | 6 +++---
> ?1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/phy-meson8b-usb2.c b/drivers/phy/phy-
> meson8b-usb2.c
> index 33c9f4ba157d..30f56a6a411f 100644
> --- a/drivers/phy/phy-meson8b-usb2.c
> +++ b/drivers/phy/phy-meson8b-usb2.c
> @@ -81,9 +81,9 @@
> ? #define REG_ADP_BC_ACA_PIN_GND BIT(25
> )
> ? #define REG_ADP_BC_ACA_PIN_FLOAT BIT(26)
> ?
> -#define REG_DBG_UART 0x14
> +#define REG_DBG_UART 0x10
> ?
> -#define REG_TEST 0x18
> +#define REG_TEST 0x14
> ? #define REG_TEST_DATA_IN_MASK GENMASK
> (3, 0)
> ? #define REG_TEST_EN_MASK GENMASK(7,
> 4)
> ? #define REG_TEST_ADDR_MASK GENMASK(11
> , 8)
> @@ -93,7 +93,7 @@
> ? #define REG_TEST_DATA_OUT_MASK GENMAS
> K(19, 16)
> ? #define REG_TEST_DISABLE_ID_PULLUP BIT(20)
> ?
> -#define REG_TUNE 0x1c
> +#define REG_TUNE 0x18
> ? #define REG_TUNE_TX_RES_TUNE_MASK GENMASK(1,
> 0)
> ? #define REG_TUNE_TX_HSXV_TUNE_MASK GENMASK(3,
> 2)
> ? #define REG_TUNE_TX_VREF_TUNE_MASK GENMASK(7,
> 4)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] phy: meson8b-usb2: fix offsets for some of the registers
2017-01-13 18:53 [PATCH] phy: meson8b-usb2: fix offsets for some of the registers Martin Blumenstingl
2017-02-03 20:05 ` Martin Blumenstingl
2017-02-10 9:27 ` Jerome Brunet
@ 2017-03-04 10:20 ` Martin Blumenstingl
2017-03-24 19:19 ` Martin Blumenstingl
2 siblings, 1 reply; 6+ messages in thread
From: Martin Blumenstingl @ 2017-03-04 10:20 UTC (permalink / raw)
To: linux-arm-kernel
The register offsets for REG_DBG_UART (and all following) were off by
0x4. This was not a problem yet because these registers are currently
not used by the driver.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
---
changes since v1:
- added Jerome's Reviewed-By
drivers/phy/phy-meson8b-usb2.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/phy-meson8b-usb2.c b/drivers/phy/phy-meson8b-usb2.c
index 33c9f4ba157d..30f56a6a411f 100644
--- a/drivers/phy/phy-meson8b-usb2.c
+++ b/drivers/phy/phy-meson8b-usb2.c
@@ -81,9 +81,9 @@
#define REG_ADP_BC_ACA_PIN_GND BIT(25)
#define REG_ADP_BC_ACA_PIN_FLOAT BIT(26)
-#define REG_DBG_UART 0x14
+#define REG_DBG_UART 0x10
-#define REG_TEST 0x18
+#define REG_TEST 0x14
#define REG_TEST_DATA_IN_MASK GENMASK(3, 0)
#define REG_TEST_EN_MASK GENMASK(7, 4)
#define REG_TEST_ADDR_MASK GENMASK(11, 8)
@@ -93,7 +93,7 @@
#define REG_TEST_DATA_OUT_MASK GENMASK(19, 16)
#define REG_TEST_DISABLE_ID_PULLUP BIT(20)
-#define REG_TUNE 0x1c
+#define REG_TUNE 0x18
#define REG_TUNE_TX_RES_TUNE_MASK GENMASK(1, 0)
#define REG_TUNE_TX_HSXV_TUNE_MASK GENMASK(3, 2)
#define REG_TUNE_TX_VREF_TUNE_MASK GENMASK(7, 4)
--
2.12.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] phy: meson8b-usb2: fix offsets for some of the registers
2017-03-04 10:20 ` [PATCH v2] " Martin Blumenstingl
@ 2017-03-24 19:19 ` Martin Blumenstingl
2017-03-27 10:06 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 6+ messages in thread
From: Martin Blumenstingl @ 2017-03-24 19:19 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kishon,
On Sat, Mar 4, 2017 at 11:20 AM, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
> The register offsets for REG_DBG_UART (and all following) were off by
> 0x4. This was not a problem yet because these registers are currently
> not used by the driver.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
gentle ping - please let me know if something is missing (for example
some ACK orreview) before you are going to apply this
> ---
> changes since v1:
> - added Jerome's Reviewed-By
>
> drivers/phy/phy-meson8b-usb2.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/phy-meson8b-usb2.c b/drivers/phy/phy-meson8b-usb2.c
> index 33c9f4ba157d..30f56a6a411f 100644
> --- a/drivers/phy/phy-meson8b-usb2.c
> +++ b/drivers/phy/phy-meson8b-usb2.c
> @@ -81,9 +81,9 @@
> #define REG_ADP_BC_ACA_PIN_GND BIT(25)
> #define REG_ADP_BC_ACA_PIN_FLOAT BIT(26)
>
> -#define REG_DBG_UART 0x14
> +#define REG_DBG_UART 0x10
>
> -#define REG_TEST 0x18
> +#define REG_TEST 0x14
> #define REG_TEST_DATA_IN_MASK GENMASK(3, 0)
> #define REG_TEST_EN_MASK GENMASK(7, 4)
> #define REG_TEST_ADDR_MASK GENMASK(11, 8)
> @@ -93,7 +93,7 @@
> #define REG_TEST_DATA_OUT_MASK GENMASK(19, 16)
> #define REG_TEST_DISABLE_ID_PULLUP BIT(20)
>
> -#define REG_TUNE 0x1c
> +#define REG_TUNE 0x18
> #define REG_TUNE_TX_RES_TUNE_MASK GENMASK(1, 0)
> #define REG_TUNE_TX_HSXV_TUNE_MASK GENMASK(3, 2)
> #define REG_TUNE_TX_VREF_TUNE_MASK GENMASK(7, 4)
> --
> 2.12.0
>
Regards,
Martin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] phy: meson8b-usb2: fix offsets for some of the registers
2017-03-24 19:19 ` Martin Blumenstingl
@ 2017-03-27 10:06 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2017-03-27 10:06 UTC (permalink / raw)
To: linux-arm-kernel
On Saturday 25 March 2017 12:49 AM, Martin Blumenstingl wrote:
> Hi Kishon,
>
> On Sat, Mar 4, 2017 at 11:20 AM, Martin Blumenstingl
> <martin.blumenstingl@googlemail.com> wrote:
>> The register offsets for REG_DBG_UART (and all following) were off by
>> 0x4. This was not a problem yet because these registers are currently
>> not used by the driver.
>>
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
> gentle ping - please let me know if something is missing (for example
> some ACK orreview) before you are going to apply this
>
merged it now.
Thanks
Kishon
>> ---
>> changes since v1:
>> - added Jerome's Reviewed-By
>>
>> drivers/phy/phy-meson8b-usb2.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/phy/phy-meson8b-usb2.c b/drivers/phy/phy-meson8b-usb2.c
>> index 33c9f4ba157d..30f56a6a411f 100644
>> --- a/drivers/phy/phy-meson8b-usb2.c
>> +++ b/drivers/phy/phy-meson8b-usb2.c
>> @@ -81,9 +81,9 @@
>> #define REG_ADP_BC_ACA_PIN_GND BIT(25)
>> #define REG_ADP_BC_ACA_PIN_FLOAT BIT(26)
>>
>> -#define REG_DBG_UART 0x14
>> +#define REG_DBG_UART 0x10
>>
>> -#define REG_TEST 0x18
>> +#define REG_TEST 0x14
>> #define REG_TEST_DATA_IN_MASK GENMASK(3, 0)
>> #define REG_TEST_EN_MASK GENMASK(7, 4)
>> #define REG_TEST_ADDR_MASK GENMASK(11, 8)
>> @@ -93,7 +93,7 @@
>> #define REG_TEST_DATA_OUT_MASK GENMASK(19, 16)
>> #define REG_TEST_DISABLE_ID_PULLUP BIT(20)
>>
>> -#define REG_TUNE 0x1c
>> +#define REG_TUNE 0x18
>> #define REG_TUNE_TX_RES_TUNE_MASK GENMASK(1, 0)
>> #define REG_TUNE_TX_HSXV_TUNE_MASK GENMASK(3, 2)
>> #define REG_TUNE_TX_VREF_TUNE_MASK GENMASK(7, 4)
>> --
>> 2.12.0
>>
>
>
> Regards,
> Martin
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-27 10:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-13 18:53 [PATCH] phy: meson8b-usb2: fix offsets for some of the registers Martin Blumenstingl
2017-02-03 20:05 ` Martin Blumenstingl
2017-02-10 9:27 ` Jerome Brunet
2017-03-04 10:20 ` [PATCH v2] " Martin Blumenstingl
2017-03-24 19:19 ` Martin Blumenstingl
2017-03-27 10:06 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox