* [PATCH 1/7] ARM: dma-mapping: Cocci spatch "vma_pages" [not found] <1505946334393-568186305-0-diffsplit-thomas@m3y3r.de> @ 2017-09-20 22:29 ` Thomas Meyer 2017-09-20 22:29 ` [PATCH 2/7] arm64: " Thomas Meyer 2017-09-20 22:29 ` [PATCH 7/7] drm/rockchip: " Thomas Meyer 2 siblings, 0 replies; 8+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: linux-arm-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -846,7 +846,7 @@ static int __arm_dma_mmap(struct device unsigned long attrs) { int ret; - unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; + unsigned long nr_vma_pages = vma_pages(vma); unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT; unsigned long pfn = dma_to_pfn(dev, dma_addr); unsigned long off = vma->vm_pgoff; ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/7] arm64: Cocci spatch "vma_pages" [not found] <1505946334393-568186305-0-diffsplit-thomas@m3y3r.de> 2017-09-20 22:29 ` [PATCH 1/7] ARM: dma-mapping: Cocci spatch "vma_pages" Thomas Meyer @ 2017-09-20 22:29 ` Thomas Meyer 2017-09-26 11:57 ` Robin Murphy 2017-09-20 22:29 ` [PATCH 7/7] drm/rockchip: " Thomas Meyer 2 siblings, 1 reply; 8+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: linux-arm-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -303,8 +303,7 @@ static int __swiotlb_mmap_pfn(struct vm_ unsigned long pfn, size_t size) { int ret = -ENXIO; - unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >> - PAGE_SHIFT; + unsigned long nr_vma_pages = vma_pages(vma); unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT; unsigned long off = vma->vm_pgoff; ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/7] arm64: Cocci spatch "vma_pages" 2017-09-20 22:29 ` [PATCH 2/7] arm64: " Thomas Meyer @ 2017-09-26 11:57 ` Robin Murphy 0 siblings, 0 replies; 8+ messages in thread From: Robin Murphy @ 2017-09-26 11:57 UTC (permalink / raw) To: linux-arm-kernel On 20/09/17 23:29, Thomas Meyer wrote: > Use vma_pages function on vma object instead of explicit computation. > Found by coccinelle spatch "api/vma_pages.cocci" Reviewed-by: Robin Murphy <robin.murphy@arm.com> I guess this can be picked up independently of the other patches? Robin. > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > --- > > diff -u -p a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c > --- a/arch/arm64/mm/dma-mapping.c > +++ b/arch/arm64/mm/dma-mapping.c > @@ -303,8 +303,7 @@ static int __swiotlb_mmap_pfn(struct vm_ > unsigned long pfn, size_t size) > { > int ret = -ENXIO; > - unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >> > - PAGE_SHIFT; > + unsigned long nr_vma_pages = vma_pages(vma); > unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT; > unsigned long off = vma->vm_pgoff; > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" [not found] <1505946334393-568186305-0-diffsplit-thomas@m3y3r.de> 2017-09-20 22:29 ` [PATCH 1/7] ARM: dma-mapping: Cocci spatch "vma_pages" Thomas Meyer 2017-09-20 22:29 ` [PATCH 2/7] arm64: " Thomas Meyer @ 2017-09-20 22:29 ` Thomas Meyer 2017-09-21 1:02 ` Mark yao 2 siblings, 1 reply; 8+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: linux-arm-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ { struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); unsigned int i, count = obj->size >> PAGE_SHIFT; - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; + unsigned long user_count = vma_pages(vma); unsigned long uaddr = vma->vm_start; unsigned long offset = vma->vm_pgoff; unsigned long end = user_count + offset; ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" 2017-09-20 22:29 ` [PATCH 7/7] drm/rockchip: " Thomas Meyer @ 2017-09-21 1:02 ` Mark yao 2017-09-26 5:12 ` Daniel Vetter 0 siblings, 1 reply; 8+ messages in thread From: Mark yao @ 2017-09-21 1:02 UTC (permalink / raw) To: linux-arm-kernel On 2017?09?21? 06:29, Thomas Meyer wrote: > Use vma_pages function on vma object instead of explicit computation. > Found by coccinelle spatch "api/vma_pages.cocci" > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > --- Looks good for me: Acked-by: Mark Yao <mark.yao@rock-chips.com> > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > { > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > unsigned int i, count = obj->size >> PAGE_SHIFT; > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > + unsigned long user_count = vma_pages(vma); > unsigned long uaddr = vma->vm_start; > unsigned long offset = vma->vm_pgoff; > unsigned long end = user_count + offset; > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > -- ?ark Yao ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" 2017-09-21 1:02 ` Mark yao @ 2017-09-26 5:12 ` Daniel Vetter 2017-09-26 6:33 ` Mark yao 0 siblings, 1 reply; 8+ messages in thread From: Daniel Vetter @ 2017-09-26 5:12 UTC (permalink / raw) To: linux-arm-kernel On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: > On 2017?09?21? 06:29, Thomas Meyer wrote: > > Use vma_pages function on vma object instead of explicit computation. > > Found by coccinelle spatch "api/vma_pages.cocci" > > > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > > --- > Looks good for me: > Acked-by: Mark Yao <mark.yao@rock-chips.com> Once more a maintainer who acks a patch and doesn't push it. This is really confusing, who exactly do you expect to handle this patch for you? Please push to drm-misc-next (also for future patches), thanks. -Daniel > > > > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > > { > > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > > unsigned int i, count = obj->size >> PAGE_SHIFT; > > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > + unsigned long user_count = vma_pages(vma); > > unsigned long uaddr = vma->vm_start; > > unsigned long offset = vma->vm_pgoff; > > unsigned long end = user_count + offset; > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip at lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > > > > > > -- > ?ark Yao > > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" 2017-09-26 5:12 ` Daniel Vetter @ 2017-09-26 6:33 ` Mark yao 2017-09-26 8:08 ` Daniel Vetter 0 siblings, 1 reply; 8+ messages in thread From: Mark yao @ 2017-09-26 6:33 UTC (permalink / raw) To: linux-arm-kernel On 2017?09?26? 13:12, Daniel Vetter wrote: > On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: >> On 2017?09?21? 06:29, Thomas Meyer wrote: >>> Use vma_pages function on vma object instead of explicit computation. >>> Found by coccinelle spatch "api/vma_pages.cocci" >>> >>> Signed-off-by: Thomas Meyer <thomas@m3y3r.de> >>> --- >> Looks good for me: >> Acked-by: Mark Yao <mark.yao@rock-chips.com> > Once more a maintainer who acks a patch and doesn't push it. This is > really confusing, who exactly do you expect to handle this patch for you? > > Please push to drm-misc-next (also for future patches), thanks. > -Daniel Hi Daniel I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of patches and maybe it can pushed by series. Ok, Pushed it to drm-misc-next. > >>> diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ >>> { >>> struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); >>> unsigned int i, count = obj->size >> PAGE_SHIFT; >>> - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; >>> + unsigned long user_count = vma_pages(vma); >>> unsigned long uaddr = vma->vm_start; >>> unsigned long offset = vma->vm_pgoff; >>> unsigned long end = user_count + offset; >>> >>> _______________________________________________ >>> Linux-rockchip mailing list >>> Linux-rockchip at lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-rockchip >>> >>> >>> >> -- >> ?ark Yao >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel at lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- ?ark Ya ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" 2017-09-26 6:33 ` Mark yao @ 2017-09-26 8:08 ` Daniel Vetter 0 siblings, 0 replies; 8+ messages in thread From: Daniel Vetter @ 2017-09-26 8:08 UTC (permalink / raw) To: linux-arm-kernel On Tue, Sep 26, 2017 at 02:33:07PM +0800, Mark yao wrote: > On 2017?09?26? 13:12, Daniel Vetter wrote: > > On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: > > > On 2017?09?21? 06:29, Thomas Meyer wrote: > > > > Use vma_pages function on vma object instead of explicit computation. > > > > Found by coccinelle spatch "api/vma_pages.cocci" > > > > > > > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > > > > --- > > > Looks good for me: > > > Acked-by: Mark Yao <mark.yao@rock-chips.com> > > Once more a maintainer who acks a patch and doesn't push it. This is > > really confusing, who exactly do you expect to handle this patch for you? > > > > Please push to drm-misc-next (also for future patches), thanks. > > -Daniel > > Hi Daniel > I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of patches and maybe it can pushed by series. > > Ok, Pushed it to drm-misc-next. Hm right, but I only see 7/7 here. Either way, except when the author asks for a preferred tree it's best if you just pick things up right away. And if you're unsure, just ask instead of risking that a patch drops through the cracks. -Daniel > > > > > > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > > > > { > > > > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > > > > unsigned int i, count = obj->size >> PAGE_SHIFT; > > > > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > > > + unsigned long user_count = vma_pages(vma); > > > > unsigned long uaddr = vma->vm_start; > > > > unsigned long offset = vma->vm_pgoff; > > > > unsigned long end = user_count + offset; > > > > > > > > _______________________________________________ > > > > Linux-rockchip mailing list > > > > Linux-rockchip at lists.infradead.org > > > > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > > > > > > > > > > > > > -- > > > ?ark Yao > > > > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel at lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > -- > ?ark Ya > > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-09-26 11:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1505946334393-568186305-0-diffsplit-thomas@m3y3r.de>
2017-09-20 22:29 ` [PATCH 1/7] ARM: dma-mapping: Cocci spatch "vma_pages" Thomas Meyer
2017-09-20 22:29 ` [PATCH 2/7] arm64: " Thomas Meyer
2017-09-26 11:57 ` Robin Murphy
2017-09-20 22:29 ` [PATCH 7/7] drm/rockchip: " Thomas Meyer
2017-09-21 1:02 ` Mark yao
2017-09-26 5:12 ` Daniel Vetter
2017-09-26 6:33 ` Mark yao
2017-09-26 8:08 ` Daniel Vetter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox