public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Gavin Shan <gshan@redhat.com>
To: linux-arm-kernel@lists.infradead.org
Cc: mark.rutland@arm.com, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com
Subject: Re: [PATCH] drivers/firmware/psci: Hide ACPI state during initialization
Date: Tue, 11 Feb 2020 13:02:44 +1100	[thread overview]
Message-ID: <15169cd9-a22f-9ab2-b7e4-d050aee334cd@redhat.com> (raw)
In-Reply-To: <20200202230626.6598-1-gshan@redhat.com>


Hi Sudeep,

On Mon, Feb. 3, 2020, 11:45 a.m. UTC, Sudeep Holla wrote:
> On Mon, Feb 03, 2020 at 10:06:26AM +1100, Gavin Shan wrote:
>> Either psci_dt_init() or psci_acpi_init() s called depends on ACPI
>> enablement state, which isn't so nice. In this case, two functions
>> have to be exported from PSCI module.
>>

I missed your reply and sorry for late catchup.

> I am confused, we don't export any functions as you mention and both
> are __init functions which can't be exported.
>

The words "export" here means "declared". Two functons (psci_{dt,acpi}_init())
are declared and one of them is called depending on ACPI is enabled or not. If
we hide the ACPI enablement state inside the driver/module, we just need to
declare one function (psci_init()), to make the code a bit cleaner.

>> This hides the ACPI enablement state insides PSCI module so that we
>> only need to export a function, to make the code a bit simplified.
>>

> For me it's just the preference. I will leave it to maintainers' taste.
>

Sure, lets see what comments Mark will have then. It's not bad to make
the code cleaner, even just a bit :)

Thank you for your time on this.

Thanks,
Gavin


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-02-11  2:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-02 23:06 [PATCH] drivers/firmware/psci: Hide ACPI state during initialization Gavin Shan
2020-02-03 11:45 ` Sudeep Holla
2020-02-11  2:02 ` Gavin Shan [this message]
2020-02-11 12:21   ` Lorenzo Pieralisi
2020-02-11 23:14     ` Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15169cd9-a22f-9ab2-b7e4-d050aee334cd@redhat.com \
    --to=gshan@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox