From: Gavin Shan <gshan@redhat.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
sudeep.holla@arm.com
Subject: Re: [PATCH] drivers/firmware/psci: Hide ACPI state during initialization
Date: Wed, 12 Feb 2020 10:14:54 +1100 [thread overview]
Message-ID: <bab3d6ed-a35d-dcf5-9b05-ee60f2d503f8@redhat.com> (raw)
In-Reply-To: <20200211122104.GB21093@e121166-lin.cambridge.arm.com>
On 2/11/20 11:21 PM, Lorenzo Pieralisi wrote:
> On Tue, Feb 11, 2020 at 01:02:44PM +1100, Gavin Shan wrote:
>
> [...]
>
>> The words "export" here means "declared". Two functons (psci_{dt,acpi}_init())
>> are declared and one of them is called depending on ACPI is enabled or not. If
>> we hide the ACPI enablement state inside the driver/module, we just need to
>> declare one function (psci_init()), to make the code a bit cleaner.
>>
>>>> This hides the ACPI enablement state insides PSCI module so that we
>>>> only need to export a function, to make the code a bit simplified.
>>>>
>>
>>> For me it's just the preference. I will leave it to maintainers' taste.
> I am not too fussed either way. As code is now though at least we know
> acpi_disabled was {set/clear} before PSCI is initialized. Hiding the
> ACPI/DT switch in PSCI code can be a problem if we move the boot code
> around.
>
> I don't necessarily see this patch as an improvement, again it is
> no big deal regardless.
>
Lorenzo, thanks a lot for the explanation. I'm fine with either way. Please
pick it if it's fine to you. Otherwise, please drop this :)
Thanks,
Gavin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-02-11 23:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 23:06 [PATCH] drivers/firmware/psci: Hide ACPI state during initialization Gavin Shan
2020-02-03 11:45 ` Sudeep Holla
2020-02-11 2:02 ` Gavin Shan
2020-02-11 12:21 ` Lorenzo Pieralisi
2020-02-11 23:14 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bab3d6ed-a35d-dcf5-9b05-ee60f2d503f8@redhat.com \
--to=gshan@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox