From: Sudeep Holla <sudeep.holla@arm.com>
To: Gavin Shan <gshan@redhat.com>
Cc: mark.rutland@arm.com, lorenzo.pieralisi@arm.com,
linux-arm-kernel@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] drivers/firmware/psci: Hide ACPI state during initialization
Date: Mon, 3 Feb 2020 11:45:17 +0000 [thread overview]
Message-ID: <20200203114517.GA38195@bogus> (raw)
In-Reply-To: <20200202230626.6598-1-gshan@redhat.com>
On Mon, Feb 03, 2020 at 10:06:26AM +1100, Gavin Shan wrote:
> Either psci_dt_init() or psci_acpi_init() s called depends on ACPI
> enablement state, which isn't so nice. In this case, two functions
> have to be exported from PSCI module.
>
I am confused, we don't export any functions as you mention and both
are __init functions which can't be exported.
> This hides the ACPI enablement state insides PSCI module so that we
> only need to export a function, to make the code a bit simplified.
>
For me it's just the preference. I will leave it to maintainers' taste.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-03 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 23:06 [PATCH] drivers/firmware/psci: Hide ACPI state during initialization Gavin Shan
2020-02-03 11:45 ` Sudeep Holla [this message]
2020-02-11 2:02 ` Gavin Shan
2020-02-11 12:21 ` Lorenzo Pieralisi
2020-02-11 23:14 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203114517.GA38195@bogus \
--to=sudeep.holla@arm.com \
--cc=gshan@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox