* [PATCH] usb: mtu3: fix EXTCON dependency
@ 2019-03-25 13:54 Arnd Bergmann
2019-03-27 6:56 ` Chunfeng Yun
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2019-03-25 13:54 UTC (permalink / raw)
To: Chunfeng Yun, Greg Kroah-Hartman
Cc: Arnd Bergmann, Felipe Balbi, linux-usb, linux-kernel,
linux-mediatek, linux-arm-kernel
When EXTCON is a loadable module, mtu3 fails to link as built-in:
drivers/usb/mtu3/mtu3_plat.o: In function `mtu3_probe':
mtu3_plat.c:(.text+0x690): undefined reference to `extcon_get_edev_by_phandle'
Add a Kconfig dependency to force mtu3 also to be a loadable module
if extconn is, but still allow it to be built without extcon.
Fixes: d0ed062a8b75 ("usb: mtu3: dual-role mode support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/mtu3/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/mtu3/Kconfig b/drivers/usb/mtu3/Kconfig
index bcc23486c4ed..928c2cd6fc00 100644
--- a/drivers/usb/mtu3/Kconfig
+++ b/drivers/usb/mtu3/Kconfig
@@ -6,6 +6,7 @@ config USB_MTU3
tristate "MediaTek USB3 Dual Role controller"
depends on USB || USB_GADGET
depends on ARCH_MEDIATEK || COMPILE_TEST
+ depends on EXTCON || !EXTCON
select USB_XHCI_MTK if USB_SUPPORT && USB_XHCI_HCD
help
Say Y or M here if your system runs on MediaTek SoCs with
--
2.20.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: mtu3: fix EXTCON dependency
2019-03-25 13:54 [PATCH] usb: mtu3: fix EXTCON dependency Arnd Bergmann
@ 2019-03-27 6:56 ` Chunfeng Yun
0 siblings, 0 replies; 2+ messages in thread
From: Chunfeng Yun @ 2019-03-27 6:56 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel,
linux-mediatek, linux-arm-kernel
Hi Arnd,
On Mon, 2019-03-25 at 14:54 +0100, Arnd Bergmann wrote:
> When EXTCON is a loadable module, mtu3 fails to link as built-in:
>
> drivers/usb/mtu3/mtu3_plat.o: In function `mtu3_probe':
> mtu3_plat.c:(.text+0x690): undefined reference to `extcon_get_edev_by_phandle'
>
> Add a Kconfig dependency to force mtu3 also to be a loadable module
> if extconn is, but still allow it to be built without extcon.
^^ extcon
>
> Fixes: d0ed062a8b75 ("usb: mtu3: dual-role mode support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/usb/mtu3/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/mtu3/Kconfig b/drivers/usb/mtu3/Kconfig
> index bcc23486c4ed..928c2cd6fc00 100644
> --- a/drivers/usb/mtu3/Kconfig
> +++ b/drivers/usb/mtu3/Kconfig
> @@ -6,6 +6,7 @@ config USB_MTU3
> tristate "MediaTek USB3 Dual Role controller"
> depends on USB || USB_GADGET
> depends on ARCH_MEDIATEK || COMPILE_TEST
> + depends on EXTCON || !EXTCON
> select USB_XHCI_MTK if USB_SUPPORT && USB_XHCI_HCD
> help
> Say Y or M here if your system runs on MediaTek SoCs with
Tested-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Thank you!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-27 6:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-25 13:54 [PATCH] usb: mtu3: fix EXTCON dependency Arnd Bergmann
2019-03-27 6:56 ` Chunfeng Yun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox