* [PATCH] [RESEND] arm64: dts: mt8173: Add dynamic power node.
@ 2019-11-22 9:06 michael.kao
2019-12-05 16:00 ` Daniel Lezcano
0 siblings, 1 reply; 4+ messages in thread
From: michael.kao @ 2019-11-22 9:06 UTC (permalink / raw)
To: Zhang Rui, Eduardo Valentin, Daniel Lezcano, Rob Herring,
Mark Rutland, Matthias Brugger, hsinyi, linux-pm
Cc: devicetree, Dawei Chien, linux-kernel, michael.kao,
linux-mediatek, linux-arm-kernel
From: "michael.kao" <michael.kao@mediatek.com>
This device node is for calculating dynamic power in mW.
Since mt8173 has two clusters, there are two dynamic power
coefficient as well.
Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
Signed-off-by: Michael.Kao <michael.kao@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index 15f1842f6df3..b03ca5a71338 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -157,6 +157,7 @@
enable-method = "psci";
cpu-idle-states = <&CPU_SLEEP_0>;
#cooling-cells = <2>;
+ dynamic-power-coefficient = <263>;
clocks = <&infracfg CLK_INFRA_CA53SEL>,
<&apmixedsys CLK_APMIXED_MAINPLL>;
clock-names = "cpu", "intermediate";
@@ -170,6 +171,7 @@
enable-method = "psci";
cpu-idle-states = <&CPU_SLEEP_0>;
#cooling-cells = <2>;
+ dynamic-power-coefficient = <263>;
clocks = <&infracfg CLK_INFRA_CA53SEL>,
<&apmixedsys CLK_APMIXED_MAINPLL>;
clock-names = "cpu", "intermediate";
@@ -183,6 +185,7 @@
enable-method = "psci";
cpu-idle-states = <&CPU_SLEEP_0>;
#cooling-cells = <2>;
+ dynamic-power-coefficient = <530>;
clocks = <&infracfg CLK_INFRA_CA72SEL>,
<&apmixedsys CLK_APMIXED_MAINPLL>;
clock-names = "cpu", "intermediate";
@@ -196,6 +199,7 @@
enable-method = "psci";
cpu-idle-states = <&CPU_SLEEP_0>;
#cooling-cells = <2>;
+ dynamic-power-coefficient = <530>;
clocks = <&infracfg CLK_INFRA_CA72SEL>,
<&apmixedsys CLK_APMIXED_MAINPLL>;
clock-names = "cpu", "intermediate";
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [RESEND] arm64: dts: mt8173: Add dynamic power node.
2019-11-22 9:06 [PATCH] [RESEND] arm64: dts: mt8173: Add dynamic power node michael.kao
@ 2019-12-05 16:00 ` Daniel Lezcano
2019-12-11 8:13 ` Michael Kao
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Lezcano @ 2019-12-05 16:00 UTC (permalink / raw)
To: michael.kao, Zhang Rui, Eduardo Valentin, Rob Herring,
Mark Rutland, Matthias Brugger, hsinyi, linux-pm
Cc: devicetree, linux-mediatek, linux-kernel, linux-arm-kernel,
Dawei Chien
Hi Michael,
On 22/11/2019 10:06, michael.kao@mediatek.com wrote:
> From: "michael.kao" <michael.kao@mediatek.com>
>
> This device node is for calculating dynamic power in mW.
> Since mt8173 has two clusters, there are two dynamic power
> coefficient as well.
Are you sure about the values? Usually, Big is ~x4 little, here it is ~x2.
> Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
> Signed-off-by: Michael.Kao <michael.kao@mediatek.com>
>
> ---
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 15f1842f6df3..b03ca5a71338 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -157,6 +157,7 @@
> enable-method = "psci";
> cpu-idle-states = <&CPU_SLEEP_0>;
> #cooling-cells = <2>;
> + dynamic-power-coefficient = <263>;
> clocks = <&infracfg CLK_INFRA_CA53SEL>,
> <&apmixedsys CLK_APMIXED_MAINPLL>;
> clock-names = "cpu", "intermediate";
> @@ -170,6 +171,7 @@
> enable-method = "psci";
> cpu-idle-states = <&CPU_SLEEP_0>;
> #cooling-cells = <2>;
> + dynamic-power-coefficient = <263>;
> clocks = <&infracfg CLK_INFRA_CA53SEL>,
> <&apmixedsys CLK_APMIXED_MAINPLL>;
> clock-names = "cpu", "intermediate";
> @@ -183,6 +185,7 @@
> enable-method = "psci";
> cpu-idle-states = <&CPU_SLEEP_0>;
> #cooling-cells = <2>;
> + dynamic-power-coefficient = <530>;
> clocks = <&infracfg CLK_INFRA_CA72SEL>,
> <&apmixedsys CLK_APMIXED_MAINPLL>;
> clock-names = "cpu", "intermediate";
> @@ -196,6 +199,7 @@
> enable-method = "psci";
> cpu-idle-states = <&CPU_SLEEP_0>;
> #cooling-cells = <2>;
> + dynamic-power-coefficient = <530>;
> clocks = <&infracfg CLK_INFRA_CA72SEL>,
> <&apmixedsys CLK_APMIXED_MAINPLL>;
> clock-names = "cpu", "intermediate";
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [RESEND] arm64: dts: mt8173: Add dynamic power node.
2019-12-05 16:00 ` Daniel Lezcano
@ 2019-12-11 8:13 ` Michael Kao
2019-12-11 18:06 ` Matthias Brugger
0 siblings, 1 reply; 4+ messages in thread
From: Michael Kao @ 2019-12-11 8:13 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Mark Rutland, devicetree, linux-pm, Dawei Chien, linux-kernel,
Eduardo Valentin, Rob Herring, linux-mediatek, hsinyi,
Matthias Brugger, Zhang Rui, mn.tsou, linux-arm-kernel
On Thu, 2019-12-05 at 17:00 +0100, Daniel Lezcano wrote:
> Hi Michael,
>
>
> On 22/11/2019 10:06, michael.kao@mediatek.com wrote:
> > From: "michael.kao" <michael.kao@mediatek.com>
> >
> > This device node is for calculating dynamic power in mW.
> > Since mt8173 has two clusters, there are two dynamic power
> > coefficient as well.
>
> Are you sure about the values? Usually, Big is ~x4 little, here it is ~x2.
Hi Daniel,
I have confirmed again with our IC designer.
The dynamic power coefficients are these value is right.
Designer comment that it is result from different IC implement.
>
> > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
> > Signed-off-by: Michael.Kao <michael.kao@mediatek.com>
> >
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 15f1842f6df3..b03ca5a71338 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -157,6 +157,7 @@
> > enable-method = "psci";
> > cpu-idle-states = <&CPU_SLEEP_0>;
> > #cooling-cells = <2>;
> > + dynamic-power-coefficient = <263>;
> > clocks = <&infracfg CLK_INFRA_CA53SEL>,
> > <&apmixedsys CLK_APMIXED_MAINPLL>;
> > clock-names = "cpu", "intermediate";
> > @@ -170,6 +171,7 @@
> > enable-method = "psci";
> > cpu-idle-states = <&CPU_SLEEP_0>;
> > #cooling-cells = <2>;
> > + dynamic-power-coefficient = <263>;
> > clocks = <&infracfg CLK_INFRA_CA53SEL>,
> > <&apmixedsys CLK_APMIXED_MAINPLL>;
> > clock-names = "cpu", "intermediate";
> > @@ -183,6 +185,7 @@
> > enable-method = "psci";
> > cpu-idle-states = <&CPU_SLEEP_0>;
> > #cooling-cells = <2>;
> > + dynamic-power-coefficient = <530>;
> > clocks = <&infracfg CLK_INFRA_CA72SEL>,
> > <&apmixedsys CLK_APMIXED_MAINPLL>;
> > clock-names = "cpu", "intermediate";
> > @@ -196,6 +199,7 @@
> > enable-method = "psci";
> > cpu-idle-states = <&CPU_SLEEP_0>;
> > #cooling-cells = <2>;
> > + dynamic-power-coefficient = <530>;
> > clocks = <&infracfg CLK_INFRA_CA72SEL>,
> > <&apmixedsys CLK_APMIXED_MAINPLL>;
> > clock-names = "cpu", "intermediate";
> >
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [RESEND] arm64: dts: mt8173: Add dynamic power node.
2019-12-11 8:13 ` Michael Kao
@ 2019-12-11 18:06 ` Matthias Brugger
0 siblings, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2019-12-11 18:06 UTC (permalink / raw)
To: Michael Kao, Daniel Lezcano
Cc: Mark Rutland, devicetree, linux-pm, Dawei Chien, linux-kernel,
Eduardo Valentin, Rob Herring, linux-mediatek, hsinyi, Zhang Rui,
mn.tsou, linux-arm-kernel
On 11/12/2019 09:13, Michael Kao wrote:
> On Thu, 2019-12-05 at 17:00 +0100, Daniel Lezcano wrote:
>> Hi Michael,
>>
>>
>> On 22/11/2019 10:06, michael.kao@mediatek.com wrote:
>>> From: "michael.kao" <michael.kao@mediatek.com>
>>>
>>> This device node is for calculating dynamic power in mW.
>>> Since mt8173 has two clusters, there are two dynamic power
>>> coefficient as well.
>>
>> Are you sure about the values? Usually, Big is ~x4 little, here it is ~x2.
>
> Hi Daniel,
>
> I have confirmed again with our IC designer.
> The dynamic power coefficients are these value is right.
> Designer comment that it is result from different IC implement.
Applied to v5.5-next/dts64
Thanks!
Matthias
>>
>>> Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
>>> Signed-off-by: Michael.Kao <michael.kao@mediatek.com>
>>>
>>> ---
>>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> index 15f1842f6df3..b03ca5a71338 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> @@ -157,6 +157,7 @@
>>> enable-method = "psci";
>>> cpu-idle-states = <&CPU_SLEEP_0>;
>>> #cooling-cells = <2>;
>>> + dynamic-power-coefficient = <263>;
>>> clocks = <&infracfg CLK_INFRA_CA53SEL>,
>>> <&apmixedsys CLK_APMIXED_MAINPLL>;
>>> clock-names = "cpu", "intermediate";
>>> @@ -170,6 +171,7 @@
>>> enable-method = "psci";
>>> cpu-idle-states = <&CPU_SLEEP_0>;
>>> #cooling-cells = <2>;
>>> + dynamic-power-coefficient = <263>;
>>> clocks = <&infracfg CLK_INFRA_CA53SEL>,
>>> <&apmixedsys CLK_APMIXED_MAINPLL>;
>>> clock-names = "cpu", "intermediate";
>>> @@ -183,6 +185,7 @@
>>> enable-method = "psci";
>>> cpu-idle-states = <&CPU_SLEEP_0>;
>>> #cooling-cells = <2>;
>>> + dynamic-power-coefficient = <530>;
>>> clocks = <&infracfg CLK_INFRA_CA72SEL>,
>>> <&apmixedsys CLK_APMIXED_MAINPLL>;
>>> clock-names = "cpu", "intermediate";
>>> @@ -196,6 +199,7 @@
>>> enable-method = "psci";
>>> cpu-idle-states = <&CPU_SLEEP_0>;
>>> #cooling-cells = <2>;
>>> + dynamic-power-coefficient = <530>;
>>> clocks = <&infracfg CLK_INFRA_CA72SEL>,
>>> <&apmixedsys CLK_APMIXED_MAINPLL>;
>>> clock-names = "cpu", "intermediate";
>>>
>>
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-11 18:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-22 9:06 [PATCH] [RESEND] arm64: dts: mt8173: Add dynamic power node michael.kao
2019-12-05 16:00 ` Daniel Lezcano
2019-12-11 8:13 ` Michael Kao
2019-12-11 18:06 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox