[PATCH] pinctrl: actions: fix function group name for i2c0_group

[PATCH] pinctrl: actions: fix function group name for i2c0_group

[Amit Singh Tomar]

After commit 6f87359e8bcaf88381b9c9c038929e0e6872d308("pinctrl: actions: Fix
functions groups names for S700 SoC") following error has been observed
while booting Linux on Cubieboard7-lite(based on S700 SoC).

[    1.206245] pinctrl-s700 e01b0000.pinctrl: invalid group "i2c0_mfp" for function "i2c0"

This commit fixes it by using correct name for i2c0_group.

Fixes: 6f87359 ("pinctrl: actions: Fix functions groups names for S700 SoC")
Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
---
 drivers/pinctrl/actions/pinctrl-s700.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/actions/pinctrl-s700.c b/drivers/pinctrl/actions/pinctrl-s700.c
index 47a4ccd..f579a65 100644
--- a/drivers/pinctrl/actions/pinctrl-s700.c
+++ b/drivers/pinctrl/actions/pinctrl-s700.c
@@ -1435,7 +1435,7 @@ static const char * const sd2_groups[] = {
 static const char * const i2c0_groups[] = {
 	"uart0_rx_mfp",
 	"uart0_tx_mfp",
-	"i2c0_mfp_mfp",
+	"i2c0_mfp",
 };
 
 static const char * const i2c1_groups[] = {
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pinctrl: actions: fix function group name for i2c0_group

[Manivannan Sadhasivam]

On Sun, Apr 12, 2020 at 08:04:20PM +0530, Amit Singh Tomar wrote:
> After commit 6f87359e8bcaf88381b9c9c038929e0e6872d308("pinctrl: actions: Fix
> functions groups names for S700 SoC") following error has been observed
> while booting Linux on Cubieboard7-lite(based on S700 SoC).
> 
> [    1.206245] pinctrl-s700 e01b0000.pinctrl: invalid group "i2c0_mfp" for function "i2c0"
> 
> This commit fixes it by using correct name for i2c0_group.
> 

Another one ;)

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> Fixes: 6f87359 ("pinctrl: actions: Fix functions groups names for S700 SoC")
> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
> ---
>  drivers/pinctrl/actions/pinctrl-s700.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/actions/pinctrl-s700.c b/drivers/pinctrl/actions/pinctrl-s700.c
> index 47a4ccd..f579a65 100644
> --- a/drivers/pinctrl/actions/pinctrl-s700.c
> +++ b/drivers/pinctrl/actions/pinctrl-s700.c
> @@ -1435,7 +1435,7 @@ static const char * const sd2_groups[] = {
>  static const char * const i2c0_groups[] = {
>  	"uart0_rx_mfp",
>  	"uart0_tx_mfp",
> -	"i2c0_mfp_mfp",
> +	"i2c0_mfp",
>  };
>  
>  static const char * const i2c1_groups[] = {
> -- 
> 2.7.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pinctrl: actions: fix function group name for i2c0_group

[Andreas Färber]

Hi,

Am 12.04.20 um 16:34 schrieb Amit Singh Tomar:
> After commit 6f87359e8bcaf88381b9c9c038929e0e6872d308("pinctrl: actions: Fix
> functions groups names for S700 SoC") following error has been observed
> while booting Linux on Cubieboard7-lite(based on S700 SoC).
> 
> [    1.206245] pinctrl-s700 e01b0000.pinctrl: invalid group "i2c0_mfp" for function "i2c0"
> 
> This commit fixes it by using correct name for i2c0_group.
> 
> Fixes: 6f87359 ("pinctrl: actions: Fix functions groups names for S700 SoC")

The commit hash should have 12 digits.

Please also check the white spaces: The subject seems to have too many 
after "actions:", and there's one missing before each parenthesis above.

Regards,
Andreas

> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
> ---
>   drivers/pinctrl/actions/pinctrl-s700.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/actions/pinctrl-s700.c b/drivers/pinctrl/actions/pinctrl-s700.c
> index 47a4ccd..f579a65 100644
> --- a/drivers/pinctrl/actions/pinctrl-s700.c
> +++ b/drivers/pinctrl/actions/pinctrl-s700.c
> @@ -1435,7 +1435,7 @@ static const char * const sd2_groups[] = {
>   static const char * const i2c0_groups[] = {
>   	"uart0_rx_mfp",
>   	"uart0_tx_mfp",
> -	"i2c0_mfp_mfp",
> +	"i2c0_mfp",
>   };
>   
>   static const char * const i2c1_groups[] = {
> 


-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pinctrl: actions: fix function group name for i2c0_group

[Manivannan Sadhasivam]

On Sun, Apr 12, 2020 at 11:58:05PM +0200, Andreas Färber wrote:
> Hi,
> 
> Am 12.04.20 um 16:34 schrieb Amit Singh Tomar:
> > After commit 6f87359e8bcaf88381b9c9c038929e0e6872d308("pinctrl: actions: Fix
> > functions groups names for S700 SoC") following error has been observed
> > while booting Linux on Cubieboard7-lite(based on S700 SoC).
> > 
> > [    1.206245] pinctrl-s700 e01b0000.pinctrl: invalid group "i2c0_mfp" for function "i2c0"
> > 
> > This commit fixes it by using correct name for i2c0_group.
> > 
> > Fixes: 6f87359 ("pinctrl: actions: Fix functions groups names for S700 SoC")
> 
> The commit hash should have 12 digits.
> 
> Please also check the white spaces: The subject seems to have too many after
> "actions:", and there's one missing before each parenthesis above.
> 

Amit, you can use something like this

git log -1 --abbrev-commit --pretty=format:"Fixes: %h (\"%s\")%n" <commit-hash>

Thanks,
Mani

> Regards,
> Andreas
> 
> > Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
> > ---
> >   drivers/pinctrl/actions/pinctrl-s700.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pinctrl/actions/pinctrl-s700.c b/drivers/pinctrl/actions/pinctrl-s700.c
> > index 47a4ccd..f579a65 100644
> > --- a/drivers/pinctrl/actions/pinctrl-s700.c
> > +++ b/drivers/pinctrl/actions/pinctrl-s700.c
> > @@ -1435,7 +1435,7 @@ static const char * const sd2_groups[] = {
> >   static const char * const i2c0_groups[] = {
> >   	"uart0_rx_mfp",
> >   	"uart0_tx_mfp",
> > -	"i2c0_mfp_mfp",
> > +	"i2c0_mfp",
> >   };
> >   static const char * const i2c1_groups[] = {
> > 
> 
> 
> -- 
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer
> HRB 36809 (AG Nürnberg)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pinctrl: actions: fix function group name for i2c0_group

[Amit Tomer]

Hi Mani,

> Amit, you can use something like this
>
> git log -1 --abbrev-commit --pretty=format:"Fixes: %h (\"%s\")%n" <commit-hash>

Yeah, I already had this enabled in my git config:

[pretty]
        fixes = Fixes: %h (\"%s\")
        picked = Cherry-Picked: %h (\"%s\")

and then I generated it using:

git log --pretty=fixes -1 6f87359e8bcaf88381b9c9c038929e0e6872d308
Fixes: 6f87359 ("pinctrl: actions: Fix functions groups names for S700 SoC")

But seems to only generates 7 chars for commit hash

Thanks
Amit

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel