From: Catalin Marinas <catalin.marinas@arm.com>
To: David Hildenbrand <dhildenb@redhat.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Liu Shixin <liushixin2@huawei.com>,
Rafael Aquini <raquini@redhat.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Will Deacon <will@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: (subset) [PATCH v2 0/2] arm64: fix two bug about page table check
Date: Fri, 18 Nov 2022 19:35:02 +0000 [thread overview]
Message-ID: <166879995436.2970319.8402648264263746100.b4-ty@arm.com> (raw)
In-Reply-To: <20221117075602.2904324-1-liushixin2@huawei.com>
On Thu, 17 Nov 2022 15:56:00 +0800, Liu Shixin wrote:
> Denys Vlasenko has reported two bug about page table check on arm64.
> On arm64, pmd_present() contains non-leaf pmd and invalid pmd too.
>
> When collapse hugepage, the pmd is non-leaf and should skip the check.
> Use pmd_leaf() instead of pmd_present().
>
> When split hugepage, the pmd will be marked as invalid and then populate.
> So we should decrease file_map_count when invalid pmd and then increase
> when populate the pmd. Add pmd_valid() check.
>
> [...]
Applied to arm64 (for-next/fixes), thanks!
[1/2] arm64/mm: fix incorrect file_map_count for non-leaf pmd/pud
https://git.kernel.org/arm64/c/5b47348fc0b1
I only merged the first patch in this series as Will had some questions
on the second patch (it does seem weird that the pud and pmd functions
are different w.r.t. the p*d_user() checks).
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-11-18 19:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 7:56 [PATCH v2 0/2] arm64: fix two bug about page table check Liu Shixin
2022-11-17 7:56 ` [PATCH v2 1/2] arm64/mm: fix incorrect file_map_count for non-leaf pmd/pud Liu Shixin
2022-11-17 7:56 ` Kefeng Wang
2022-11-18 14:35 ` Will Deacon
2022-11-22 3:21 ` Anshuman Khandual
2022-11-17 7:56 ` [PATCH v2 2/2] arm64/mm: fix incorrect file_map_count for invalid pmd/pud Liu Shixin
2022-11-17 7:49 ` David Hildenbrand
2022-11-17 7:56 ` Kefeng Wang
2022-11-18 14:34 ` Will Deacon
2022-11-21 3:15 ` Liu Shixin
2022-11-21 18:16 ` Will Deacon
2022-11-22 1:24 ` Liu Shixin
2022-11-18 19:35 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166879995436.2970319.8402648264263746100.b4-ty@arm.com \
--to=catalin.marinas@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=dhildenb@redhat.com \
--cc=dvlasenk@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liushixin2@huawei.com \
--cc=pasha.tatashin@soleen.com \
--cc=raquini@redhat.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox