Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Liu Shixin <liushixin2@huawei.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	David Hildenbrand <dhildenb@redhat.com>,
	Rafael Aquini <raquini@redhat.com>,
	Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Liu Shixin <liushixin2@huawei.com>
Subject: [PATCH v2 0/2] arm64: fix two bug about page table check
Date: Thu, 17 Nov 2022 15:56:00 +0800	[thread overview]
Message-ID: <20221117075602.2904324-1-liushixin2@huawei.com> (raw)

Denys Vlasenko has reported two bug about page table check on arm64.
On arm64, pmd_present() contains non-leaf pmd and invalid pmd too.

When collapse hugepage, the pmd is non-leaf and should skip the check.
Use pmd_leaf() instead of pmd_present().

When split hugepage, the pmd will be marked as invalid and then populate.
So we should decrease file_map_count when invalid pmd and then increase
when populate the pmd. Add pmd_valid() check.

v1->v2: Update comment and optimize the code by moving p?d_valid() at
	first place suggested by Mark.

Liu Shixin (2):
  arm64/mm: fix incorrect file_map_count for non-leaf pmd/pud
  arm64/mm: fix incorrect file_map_count for invalid pmd/pud

 arch/arm64/include/asm/pgtable.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2022-11-17  7:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17  7:56 Liu Shixin [this message]
2022-11-17  7:56 ` [PATCH v2 1/2] arm64/mm: fix incorrect file_map_count for non-leaf pmd/pud Liu Shixin
2022-11-17  7:56   ` Kefeng Wang
2022-11-18 14:35   ` Will Deacon
2022-11-22  3:21   ` Anshuman Khandual
2022-11-17  7:56 ` [PATCH v2 2/2] arm64/mm: fix incorrect file_map_count for invalid pmd/pud Liu Shixin
2022-11-17  7:49   ` David Hildenbrand
2022-11-17  7:56   ` Kefeng Wang
2022-11-18 14:34   ` Will Deacon
2022-11-21  3:15     ` Liu Shixin
2022-11-21 18:16       ` Will Deacon
2022-11-22  1:24         ` Liu Shixin
2022-11-18 19:35 ` (subset) [PATCH v2 0/2] arm64: fix two bug about page table check Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221117075602.2904324-1-liushixin2@huawei.com \
    --to=liushixin2@huawei.com \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=dhildenb@redhat.com \
    --cc=dvlasenk@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=raquini@redhat.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox