From: Liu Shixin <liushixin2@huawei.com>
To: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
"Anshuman Khandual" <anshuman.khandual@arm.com>,
David Hildenbrand <dhildenb@redhat.com>,
Rafael Aquini <raquini@redhat.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] arm64/mm: fix incorrect file_map_count for invalid pmd/pud
Date: Tue, 22 Nov 2022 09:24:57 +0800 [thread overview]
Message-ID: <1f4ef941-6b45-8562-1723-21048a639c18@huawei.com> (raw)
In-Reply-To: <20221121181636.GD7645@willie-the-truck>
On 2022/11/22 2:16, Will Deacon wrote:
> On Mon, Nov 21, 2022 at 11:15:49AM +0800, Liu Shixin wrote:
>> On 2022/11/18 22:34, Will Deacon wrote:
>>> On Thu, Nov 17, 2022 at 03:56:02PM +0800, Liu Shixin wrote:
>>>> static inline bool pud_user_accessible_page(pud_t pud)
>>>> {
>>>> - return pud_leaf(pud) && pud_user(pud);
>>>> + return pud_valid(pud) && pud_leaf(pud) && pud_user(pud);
>>> Not caused by this patch, but why don't we have something like a
>>> pud_user_exec() check here like we do for the pte and pmd levels?
>> As far as I know, there is no user use the user executable pud on arm64, so didn't define pud_user_exec().
> I can believe they don't get exposed to userspace at all, but exposing only
> as non-executable doesn't sound right. So I would have thought that either
> pud_user_accessible_page() would always return false or it would need to
> check for the executable case too.
Thanks for your advice, I will add the check for the executable case too.
>
> Will
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-22 1:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 7:56 [PATCH v2 0/2] arm64: fix two bug about page table check Liu Shixin
2022-11-17 7:56 ` [PATCH v2 1/2] arm64/mm: fix incorrect file_map_count for non-leaf pmd/pud Liu Shixin
2022-11-17 7:56 ` Kefeng Wang
2022-11-18 14:35 ` Will Deacon
2022-11-22 3:21 ` Anshuman Khandual
2022-11-17 7:56 ` [PATCH v2 2/2] arm64/mm: fix incorrect file_map_count for invalid pmd/pud Liu Shixin
2022-11-17 7:49 ` David Hildenbrand
2022-11-17 7:56 ` Kefeng Wang
2022-11-18 14:34 ` Will Deacon
2022-11-21 3:15 ` Liu Shixin
2022-11-21 18:16 ` Will Deacon
2022-11-22 1:24 ` Liu Shixin [this message]
2022-11-18 19:35 ` (subset) [PATCH v2 0/2] arm64: fix two bug about page table check Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f4ef941-6b45-8562-1723-21048a639c18@huawei.com \
--to=liushixin2@huawei.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dhildenb@redhat.com \
--cc=dvlasenk@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=raquini@redhat.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox