From: "Rob Herring (Arm)" <robh@kernel.org>
To: Atish Patra <atishp@rivosinc.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
weilin.wang@intel.com, devicetree@vger.kernel.org,
kvm@vger.kernel.org, Paul Walmsley <paul.walmsley@sifive.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Conor Dooley <conor+dt@kernel.org>,
Atish Patra <atishp@atishpatra.org>,
linux-riscv@lists.infradead.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Conor Dooley <conor@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Anup Patel <anup@brainfault.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Will Deacon <will@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
kvm-riscv@lists.infradead.org, Ian Rogers <irogers@google.com>,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v4 10/21] dt-bindings: riscv: add Counter delegation ISA extensions description
Date: Thu, 06 Feb 2025 02:39:19 -0600 [thread overview]
Message-ID: <173883115938.126290.3444587267516997369.robh@kernel.org> (raw)
In-Reply-To: <20250205-counter_delegation-v4-10-835cfa88e3b1@rivosinc.com>
On Wed, 05 Feb 2025 23:23:15 -0800, Atish Patra wrote:
> Add description for the Smcdeleg/Ssccfg extension.
>
> Signed-off-by: Atish Patra <atishp@rivosinc.com>
> ---
> .../devicetree/bindings/riscv/extensions.yaml | 45 ++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/extensions.yaml: properties:riscv,isa-extensions:allOf:4: 'if' is a dependency of 'then'
hint: Keywords must be a subset of known json-schema keywords
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/extensions.yaml: properties:riscv,isa-extensions:allOf:4: 'anyOf' conditional failed, one must be fixed:
'If' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
'type' was expected
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/extensions.yaml: properties:riscv,isa-extensions:allOf:5: 'if' is a dependency of 'then'
hint: Keywords must be a subset of known json-schema keywords
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/extensions.yaml: properties:riscv,isa-extensions:allOf:5: 'anyOf' conditional failed, one must be fixed:
'If' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
'type' was expected
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250205-counter_delegation-v4-10-835cfa88e3b1@rivosinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-02-06 8:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 7:23 [PATCH v4 00/21] Add Counter delegation ISA extension support Atish Patra
2025-02-06 7:23 ` [PATCH v4 01/21] perf pmu-events: Add functions in jevent.py to parse counter and event info for hardware aware grouping Atish Patra
2025-02-06 7:23 ` [PATCH v4 02/21] RISC-V: Add Sxcsrind ISA extension CSR definitions Atish Patra
2025-02-07 7:57 ` Clément Léger
2025-02-06 7:23 ` [PATCH v4 03/21] RISC-V: Add Sxcsrind ISA extension definition and parsing Atish Patra
2025-02-06 7:23 ` [PATCH v4 04/21] dt-bindings: riscv: add Sxcsrind ISA extension description Atish Patra
2025-02-19 14:09 ` Rob Herring (Arm)
2025-02-06 7:23 ` [PATCH v4 05/21] RISC-V: Define indirect CSR access helpers Atish Patra
2025-02-06 7:23 ` [PATCH v4 06/21] RISC-V: Add Smcntrpmf extension parsing Atish Patra
2025-02-07 9:21 ` Clément Léger
2025-02-06 7:23 ` [PATCH v4 07/21] dt-bindings: riscv: add Smcntrpmf ISA extension description Atish Patra
2025-02-19 14:09 ` Rob Herring (Arm)
2025-02-06 7:23 ` [PATCH v4 08/21] RISC-V: Add Sscfg extension CSR definition Atish Patra
2025-02-07 9:30 ` Clément Léger
2025-02-27 0:03 ` Atish Kumar Patra
2025-02-06 7:23 ` [PATCH v4 09/21] RISC-V: Add Ssccfg ISA extension definition and parsing Atish Patra
2025-02-07 8:08 ` Clément Léger
2025-02-07 8:13 ` Clément Léger
2025-02-27 0:06 ` Atish Kumar Patra
2025-02-06 7:23 ` [PATCH v4 10/21] dt-bindings: riscv: add Counter delegation ISA extensions description Atish Patra
2025-02-06 8:39 ` Rob Herring (Arm) [this message]
2025-02-06 7:23 ` [PATCH v4 11/21] RISC-V: perf: Restructure the SBI PMU code Atish Patra
2025-02-06 10:51 ` Will Deacon
2025-02-07 16:53 ` Atish Kumar Patra
2025-02-07 9:59 ` Clément Léger
2025-02-06 7:23 ` [PATCH v4 12/21] RISC-V: perf: Modify the counter discovery mechanism Atish Patra
2025-02-07 10:29 ` Clément Léger
2025-02-27 1:05 ` Atish Kumar Patra
2025-02-06 7:23 ` [PATCH v4 13/21] RISC-V: perf: Add a mechanism to defined legacy event encoding Atish Patra
2025-02-06 7:23 ` [PATCH v4 14/21] RISC-V: perf: Implement supervisor counter delegation support Atish Patra
2025-02-06 7:23 ` [PATCH v4 15/21] RISC-V: perf: Skip PMU SBI extension when not implemented Atish Patra
2025-02-06 7:23 ` [PATCH v4 16/21] RISC-V: perf: Use config2/vendor table for event to counter mapping Atish Patra
2025-02-06 7:23 ` [PATCH v4 17/21] RISC-V: perf: Add legacy event encodings via sysfs Atish Patra
2025-02-06 7:23 ` [PATCH v4 18/21] RISC-V: perf: Add Qemu virt machine events Atish Patra
2025-02-06 7:23 ` [PATCH v4 19/21] tools/perf: Support event code for arch standard events Atish Patra
2025-02-06 7:23 ` [PATCH v4 20/21] tools/perf: Pass the Counter constraint values in the pmu events Atish Patra
2025-02-06 7:23 ` [PATCH v4 21/21] Sync empty-pmu-events.c with autogenerated one Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173883115938.126290.3444587267516997369.robh@kernel.org \
--to=robh@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=atishp@rivosinc.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=weilin.wang@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox