From: Will Deacon <will@kernel.org>
To: Atish Patra <atishp@rivosinc.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Anup Patel <anup@brainfault.org>,
Atish Patra <atishp@atishpatra.org>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
weilin.wang@intel.com, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, Conor Dooley <conor@kernel.org>,
devicetree@vger.kernel.org, kvm@vger.kernel.org,
kvm-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v4 11/21] RISC-V: perf: Restructure the SBI PMU code
Date: Thu, 6 Feb 2025 10:51:01 +0000 [thread overview]
Message-ID: <20250206105100.GA2971@willie-the-truck> (raw)
In-Reply-To: <20250205-counter_delegation-v4-11-835cfa88e3b1@rivosinc.com>
On Wed, Feb 05, 2025 at 11:23:16PM -0800, Atish Patra wrote:
> With Ssccfg/Smcdeleg, we no longer need SBI PMU extension to program/
> access hpmcounter/events. However, we do need it for firmware counters.
> Rename the driver and its related code to represent generic name
> that will handle both sbi and ISA mechanism for hpmcounter related
> operations. Take this opportunity to update the Kconfig names to
> match the new driver name closely.
>
> No functional change intended.
>
> Signed-off-by: Atish Patra <atishp@rivosinc.com>
> ---
> MAINTAINERS | 4 +-
> arch/riscv/include/asm/kvm_vcpu_pmu.h | 4 +-
> arch/riscv/include/asm/kvm_vcpu_sbi.h | 2 +-
> arch/riscv/kvm/Makefile | 4 +-
> arch/riscv/kvm/vcpu_sbi.c | 2 +-
> drivers/perf/Kconfig | 16 +-
> drivers/perf/Makefile | 4 +-
> drivers/perf/{riscv_pmu.c => riscv_pmu_common.c} | 0
> drivers/perf/{riscv_pmu_sbi.c => riscv_pmu_dev.c} | 214 +++++++++++++---------
This seems... gratuitous? It feels like renaming the file could be a pain
for managing backports and renaming the driver might cause some headaches
in userspace.
What do you gain from such an invasive change?
Will
next prev parent reply other threads:[~2025-02-06 10:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 7:23 [PATCH v4 00/21] Add Counter delegation ISA extension support Atish Patra
2025-02-06 7:23 ` [PATCH v4 01/21] perf pmu-events: Add functions in jevent.py to parse counter and event info for hardware aware grouping Atish Patra
2025-02-06 7:23 ` [PATCH v4 02/21] RISC-V: Add Sxcsrind ISA extension CSR definitions Atish Patra
2025-02-07 7:57 ` Clément Léger
2025-02-06 7:23 ` [PATCH v4 03/21] RISC-V: Add Sxcsrind ISA extension definition and parsing Atish Patra
2025-02-06 7:23 ` [PATCH v4 04/21] dt-bindings: riscv: add Sxcsrind ISA extension description Atish Patra
2025-02-19 14:09 ` Rob Herring (Arm)
2025-02-06 7:23 ` [PATCH v4 05/21] RISC-V: Define indirect CSR access helpers Atish Patra
2025-02-06 7:23 ` [PATCH v4 06/21] RISC-V: Add Smcntrpmf extension parsing Atish Patra
2025-02-07 9:21 ` Clément Léger
2025-02-06 7:23 ` [PATCH v4 07/21] dt-bindings: riscv: add Smcntrpmf ISA extension description Atish Patra
2025-02-19 14:09 ` Rob Herring (Arm)
2025-02-06 7:23 ` [PATCH v4 08/21] RISC-V: Add Sscfg extension CSR definition Atish Patra
2025-02-07 9:30 ` Clément Léger
2025-02-27 0:03 ` Atish Kumar Patra
2025-02-06 7:23 ` [PATCH v4 09/21] RISC-V: Add Ssccfg ISA extension definition and parsing Atish Patra
2025-02-07 8:08 ` Clément Léger
2025-02-07 8:13 ` Clément Léger
2025-02-27 0:06 ` Atish Kumar Patra
2025-02-06 7:23 ` [PATCH v4 10/21] dt-bindings: riscv: add Counter delegation ISA extensions description Atish Patra
2025-02-06 8:39 ` Rob Herring (Arm)
2025-02-06 7:23 ` [PATCH v4 11/21] RISC-V: perf: Restructure the SBI PMU code Atish Patra
2025-02-06 10:51 ` Will Deacon [this message]
2025-02-07 16:53 ` Atish Kumar Patra
2025-02-07 9:59 ` Clément Léger
2025-02-06 7:23 ` [PATCH v4 12/21] RISC-V: perf: Modify the counter discovery mechanism Atish Patra
2025-02-07 10:29 ` Clément Léger
2025-02-27 1:05 ` Atish Kumar Patra
2025-02-06 7:23 ` [PATCH v4 13/21] RISC-V: perf: Add a mechanism to defined legacy event encoding Atish Patra
2025-02-06 7:23 ` [PATCH v4 14/21] RISC-V: perf: Implement supervisor counter delegation support Atish Patra
2025-02-06 7:23 ` [PATCH v4 15/21] RISC-V: perf: Skip PMU SBI extension when not implemented Atish Patra
2025-02-06 7:23 ` [PATCH v4 16/21] RISC-V: perf: Use config2/vendor table for event to counter mapping Atish Patra
2025-02-06 7:23 ` [PATCH v4 17/21] RISC-V: perf: Add legacy event encodings via sysfs Atish Patra
2025-02-06 7:23 ` [PATCH v4 18/21] RISC-V: perf: Add Qemu virt machine events Atish Patra
2025-02-06 7:23 ` [PATCH v4 19/21] tools/perf: Support event code for arch standard events Atish Patra
2025-02-06 7:23 ` [PATCH v4 20/21] tools/perf: Pass the Counter constraint values in the pmu events Atish Patra
2025-02-06 7:23 ` [PATCH v4 21/21] Sync empty-pmu-events.c with autogenerated one Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206105100.GA2971@willie-the-truck \
--to=will@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=atishp@rivosinc.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=weilin.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox