* [PATCH RESEND v3 0/3] clk: en7523: reset-controller support for EN7523 SoC
@ 2025-11-10 3:56 Mikhail Kshevetskiy
2025-11-10 3:56 ` [PATCH RESEND v3 1/3] dt-bindings: clock: airoha: Add reset support to EN7523 clock binding Mikhail Kshevetskiy
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Mikhail Kshevetskiy @ 2025-11-10 3:56 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Philipp Zabel, Felix Fietkau, linux-clk, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek
Cc: Mikhail Kshevetskiy, Andreas Gnau
No any activity for a long time, so resend
These patches:
* adds reset-controller support for EN7523 SoC
* updates dt-bindings
* updates en7523 dtsi
Reset-controller support will allow us more easily reusing of en7581 drivers
for en7523.
Changes v2:
* keep '#reset-cells' property optional
* put dtsi changes to a separate commit
* add missed dtsi include
Changes v3:
* keep en7581 prefix for common en7523/en7581 variables and functions
Mikhail Kshevetskiy (3):
dt-bindings: clock: airoha: Add reset support to EN7523 clock binding
clk: en7523: Add reset-controller support for EN7523 SoC
ARM: dts: airoha: update EN7523 dtsi to support resets
.../bindings/clock/airoha,en7523-scu.yaml | 3 +-
arch/arm/boot/dts/airoha/en7523.dtsi | 2 +
drivers/clk/clk-en7523.c | 64 +++++++++++++++++--
.../dt-bindings/reset/airoha,en7523-reset.h | 61 ++++++++++++++++++
4 files changed, 123 insertions(+), 7 deletions(-)
create mode 100644 include/dt-bindings/reset/airoha,en7523-reset.h
--
2.51.0
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH RESEND v3 1/3] dt-bindings: clock: airoha: Add reset support to EN7523 clock binding 2025-11-10 3:56 [PATCH RESEND v3 0/3] clk: en7523: reset-controller support for EN7523 SoC Mikhail Kshevetskiy @ 2025-11-10 3:56 ` Mikhail Kshevetskiy 2025-11-14 4:09 ` Stephen Boyd 2025-11-10 3:56 ` [PATCH RESEND v3 2/3] clk: en7523: Add reset-controller support for EN7523 SoC Mikhail Kshevetskiy 2025-11-10 3:56 ` [PATCH RESEND v3 3/3] ARM: dts: airoha: update EN7523 dtsi to support resets Mikhail Kshevetskiy 2 siblings, 1 reply; 9+ messages in thread From: Mikhail Kshevetskiy @ 2025-11-10 3:56 UTC (permalink / raw) To: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, Philipp Zabel, Felix Fietkau, linux-clk, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek Cc: Mikhail Kshevetskiy, Andreas Gnau Introduce reset capability to EN7523 device-tree clock binding documentation. Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> --- .../bindings/clock/airoha,en7523-scu.yaml | 3 +- .../dt-bindings/reset/airoha,en7523-reset.h | 61 +++++++++++++++++++ 2 files changed, 62 insertions(+), 2 deletions(-) create mode 100644 include/dt-bindings/reset/airoha,en7523-reset.h diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml index fe2c5c1baf43..a8471367175b 100644 --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml @@ -64,8 +64,6 @@ allOf: reg: minItems: 2 - '#reset-cells': false - - if: properties: compatible: @@ -85,6 +83,7 @@ examples: reg = <0x1fa20000 0x400>, <0x1fb00000 0x1000>; #clock-cells = <1>; + #reset-cells = <1>; }; - | diff --git a/include/dt-bindings/reset/airoha,en7523-reset.h b/include/dt-bindings/reset/airoha,en7523-reset.h new file mode 100644 index 000000000000..211e8a23a21c --- /dev/null +++ b/include/dt-bindings/reset/airoha,en7523-reset.h @@ -0,0 +1,61 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (C) 2024 iopsys Software Solutions AB. + * Copyright (C) 2025 Genexis AB. + * + * Author: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu> + * + * based on + * include/dt-bindings/reset/airoha,en7581-reset.h + * by Lorenzo Bianconi <lorenzo@kernel.org> + */ + +#ifndef __DT_BINDINGS_RESET_CONTROLLER_AIROHA_EN7523_H_ +#define __DT_BINDINGS_RESET_CONTROLLER_AIROHA_EN7523_H_ + +/* RST_CTRL2 */ +#define EN7523_XPON_PHY_RST 0 +#define EN7523_XSI_MAC_RST 1 +#define EN7523_XSI_PHY_RST 2 +#define EN7523_NPU_RST 3 +#define EN7523_I2S_RST 4 +#define EN7523_TRNG_RST 5 +#define EN7523_TRNG_MSTART_RST 6 +#define EN7523_DUAL_HSI0_RST 7 +#define EN7523_DUAL_HSI1_RST 8 +#define EN7523_HSI_RST 9 +#define EN7523_DUAL_HSI0_MAC_RST 10 +#define EN7523_DUAL_HSI1_MAC_RST 11 +#define EN7523_HSI_MAC_RST 12 +#define EN7523_WDMA_RST 13 +#define EN7523_WOE0_RST 14 +#define EN7523_WOE1_RST 15 +#define EN7523_HSDMA_RST 16 +#define EN7523_I2C2RBUS_RST 17 +#define EN7523_TDMA_RST 18 +/* RST_CTRL1 */ +#define EN7523_PCM1_ZSI_ISI_RST 19 +#define EN7523_FE_PDMA_RST 20 +#define EN7523_FE_QDMA_RST 21 +#define EN7523_PCM_SPIWP_RST 22 +#define EN7523_CRYPTO_RST 23 +#define EN7523_TIMER_RST 24 +#define EN7523_PCM1_RST 25 +#define EN7523_UART_RST 26 +#define EN7523_GPIO_RST 27 +#define EN7523_GDMA_RST 28 +#define EN7523_I2C_MASTER_RST 29 +#define EN7523_PCM2_ZSI_ISI_RST 30 +#define EN7523_SFC_RST 31 +#define EN7523_UART2_RST 32 +#define EN7523_GDMP_RST 33 +#define EN7523_FE_RST 34 +#define EN7523_USB_HOST_P0_RST 35 +#define EN7523_GSW_RST 36 +#define EN7523_SFC2_PCM_RST 37 +#define EN7523_PCIE0_RST 38 +#define EN7523_PCIE1_RST 39 +#define EN7523_PCIE_HB_RST 40 +#define EN7523_XPON_MAC_RST 41 + +#endif /* __DT_BINDINGS_RESET_CONTROLLER_AIROHA_EN7523_H_ */ -- 2.51.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND v3 1/3] dt-bindings: clock: airoha: Add reset support to EN7523 clock binding 2025-11-10 3:56 ` [PATCH RESEND v3 1/3] dt-bindings: clock: airoha: Add reset support to EN7523 clock binding Mikhail Kshevetskiy @ 2025-11-14 4:09 ` Stephen Boyd 0 siblings, 0 replies; 9+ messages in thread From: Stephen Boyd @ 2025-11-14 4:09 UTC (permalink / raw) To: AngeloGioacchino Del Regno, Conor Dooley, Felix Fietkau, Krzysztof Kozlowski, Matthias Brugger, Michael Turquette, Mikhail Kshevetskiy, Philipp Zabel, Rob Herring, devicetree, linux-arm-kernel, linux-clk, linux-kernel, linux-mediatek Cc: Mikhail Kshevetskiy, Andreas Gnau Quoting Mikhail Kshevetskiy (2025-11-09 19:56:43) > Introduce reset capability to EN7523 device-tree clock binding > documentation. > > Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > --- Applied to clk-next ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH RESEND v3 2/3] clk: en7523: Add reset-controller support for EN7523 SoC 2025-11-10 3:56 [PATCH RESEND v3 0/3] clk: en7523: reset-controller support for EN7523 SoC Mikhail Kshevetskiy 2025-11-10 3:56 ` [PATCH RESEND v3 1/3] dt-bindings: clock: airoha: Add reset support to EN7523 clock binding Mikhail Kshevetskiy @ 2025-11-10 3:56 ` Mikhail Kshevetskiy 2025-11-10 7:53 ` Philipp Zabel 2025-11-14 4:09 ` Stephen Boyd 2025-11-10 3:56 ` [PATCH RESEND v3 3/3] ARM: dts: airoha: update EN7523 dtsi to support resets Mikhail Kshevetskiy 2 siblings, 2 replies; 9+ messages in thread From: Mikhail Kshevetskiy @ 2025-11-10 3:56 UTC (permalink / raw) To: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, Philipp Zabel, Felix Fietkau, linux-clk, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek Cc: Mikhail Kshevetskiy, Andreas Gnau Introduce reset API support to EN7523 clock driver. EN7523 uses the same reset logic as EN7581, so just reuse existing code. Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/clk/clk-en7523.c | 64 ++++++++++++++++++++++++++++++++++++---- 1 file changed, 59 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c index 15bbdeb60b8e..08cc8e5acf43 100644 --- a/drivers/clk/clk-en7523.c +++ b/drivers/clk/clk-en7523.c @@ -9,6 +9,7 @@ #include <linux/regmap.h> #include <linux/reset-controller.h> #include <dt-bindings/clock/en7523-clk.h> +#include <dt-bindings/reset/airoha,en7523-reset.h> #include <dt-bindings/reset/airoha,en7581-reset.h> #define RST_NR_PER_BANK 32 @@ -299,6 +300,53 @@ static const u16 en7581_rst_ofs[] = { REG_RST_CTRL1, }; +static const u16 en7523_rst_map[] = { + /* RST_CTRL2 */ + [EN7523_XPON_PHY_RST] = 0, + [EN7523_XSI_MAC_RST] = 7, + [EN7523_XSI_PHY_RST] = 8, + [EN7523_NPU_RST] = 9, + [EN7523_I2S_RST] = 10, + [EN7523_TRNG_RST] = 11, + [EN7523_TRNG_MSTART_RST] = 12, + [EN7523_DUAL_HSI0_RST] = 13, + [EN7523_DUAL_HSI1_RST] = 14, + [EN7523_HSI_RST] = 15, + [EN7523_DUAL_HSI0_MAC_RST] = 16, + [EN7523_DUAL_HSI1_MAC_RST] = 17, + [EN7523_HSI_MAC_RST] = 18, + [EN7523_WDMA_RST] = 19, + [EN7523_WOE0_RST] = 20, + [EN7523_WOE1_RST] = 21, + [EN7523_HSDMA_RST] = 22, + [EN7523_I2C2RBUS_RST] = 23, + [EN7523_TDMA_RST] = 24, + /* RST_CTRL1 */ + [EN7523_PCM1_ZSI_ISI_RST] = RST_NR_PER_BANK + 0, + [EN7523_FE_PDMA_RST] = RST_NR_PER_BANK + 1, + [EN7523_FE_QDMA_RST] = RST_NR_PER_BANK + 2, + [EN7523_PCM_SPIWP_RST] = RST_NR_PER_BANK + 4, + [EN7523_CRYPTO_RST] = RST_NR_PER_BANK + 6, + [EN7523_TIMER_RST] = RST_NR_PER_BANK + 8, + [EN7523_PCM1_RST] = RST_NR_PER_BANK + 11, + [EN7523_UART_RST] = RST_NR_PER_BANK + 12, + [EN7523_GPIO_RST] = RST_NR_PER_BANK + 13, + [EN7523_GDMA_RST] = RST_NR_PER_BANK + 14, + [EN7523_I2C_MASTER_RST] = RST_NR_PER_BANK + 16, + [EN7523_PCM2_ZSI_ISI_RST] = RST_NR_PER_BANK + 17, + [EN7523_SFC_RST] = RST_NR_PER_BANK + 18, + [EN7523_UART2_RST] = RST_NR_PER_BANK + 19, + [EN7523_GDMP_RST] = RST_NR_PER_BANK + 20, + [EN7523_FE_RST] = RST_NR_PER_BANK + 21, + [EN7523_USB_HOST_P0_RST] = RST_NR_PER_BANK + 22, + [EN7523_GSW_RST] = RST_NR_PER_BANK + 23, + [EN7523_SFC2_PCM_RST] = RST_NR_PER_BANK + 25, + [EN7523_PCIE0_RST] = RST_NR_PER_BANK + 26, + [EN7523_PCIE1_RST] = RST_NR_PER_BANK + 27, + [EN7523_PCIE_HB_RST] = RST_NR_PER_BANK + 29, + [EN7523_XPON_MAC_RST] = RST_NR_PER_BANK + 31, +}; + static const u16 en7581_rst_map[] = { /* RST_CTRL2 */ [EN7581_XPON_PHY_RST] = 0, @@ -357,6 +405,9 @@ static const u16 en7581_rst_map[] = { [EN7581_XPON_MAC_RST] = RST_NR_PER_BANK + 31, }; +static int en7581_reset_register(struct device *dev, void __iomem *base, + const u16 *rst_map, int nr_resets); + static u32 en7523_get_base_rate(const struct en_clk_desc *desc, u32 val) { if (!desc->base_bits) @@ -552,7 +603,8 @@ static int en7523_clk_hw_init(struct platform_device *pdev, en7523_register_clocks(&pdev->dev, clk_data, base, np_base); - return 0; + return en7581_reset_register(&pdev->dev, np_base, en7523_rst_map, + ARRAY_SIZE(en7523_rst_map)); } static void en7581_register_clocks(struct device *dev, struct clk_hw_onecell_data *clk_data, @@ -652,7 +704,8 @@ static const struct reset_control_ops en7581_reset_ops = { .status = en7523_reset_status, }; -static int en7581_reset_register(struct device *dev, void __iomem *base) +static int en7581_reset_register(struct device *dev, void __iomem *base, + const u16 *rst_map, int nr_resets) { struct en_rst_data *rst_data; @@ -661,10 +714,10 @@ static int en7581_reset_register(struct device *dev, void __iomem *base) return -ENOMEM; rst_data->bank_ofs = en7581_rst_ofs; - rst_data->idx_map = en7581_rst_map; + rst_data->idx_map = rst_map; rst_data->base = base; - rst_data->rcdev.nr_resets = ARRAY_SIZE(en7581_rst_map); + rst_data->rcdev.nr_resets = nr_resets; rst_data->rcdev.of_xlate = en7523_reset_xlate; rst_data->rcdev.ops = &en7581_reset_ops; rst_data->rcdev.of_node = dev->of_node; @@ -698,7 +751,8 @@ static int en7581_clk_hw_init(struct platform_device *pdev, val = readl(base + REG_NP_SCU_PCIC); writel(val | 3, base + REG_NP_SCU_PCIC); - return en7581_reset_register(&pdev->dev, base); + return en7581_reset_register(&pdev->dev, base, en7581_rst_map, + ARRAY_SIZE(en7581_rst_map)); } static int en7523_clk_probe(struct platform_device *pdev) -- 2.51.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND v3 2/3] clk: en7523: Add reset-controller support for EN7523 SoC 2025-11-10 3:56 ` [PATCH RESEND v3 2/3] clk: en7523: Add reset-controller support for EN7523 SoC Mikhail Kshevetskiy @ 2025-11-10 7:53 ` Philipp Zabel 2025-11-14 4:09 ` Stephen Boyd 1 sibling, 0 replies; 9+ messages in thread From: Philipp Zabel @ 2025-11-10 7:53 UTC (permalink / raw) To: Mikhail Kshevetskiy, Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, Felix Fietkau, linux-clk, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek Cc: Andreas Gnau On Mo, 2025-11-10 at 06:56 +0300, Mikhail Kshevetskiy wrote: > Introduce reset API support to EN7523 clock driver. EN7523 uses the > same reset logic as EN7581, so just reuse existing code. > > Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> > --- > drivers/clk/clk-en7523.c | 64 ++++++++++++++++++++++++++++++++++++---- > 1 file changed, 59 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c > index 15bbdeb60b8e..08cc8e5acf43 100644 > --- a/drivers/clk/clk-en7523.c > +++ b/drivers/clk/clk-en7523.c > @@ -9,6 +9,7 @@ > #include <linux/regmap.h> > #include <linux/reset-controller.h> > #include <dt-bindings/clock/en7523-clk.h> > +#include <dt-bindings/reset/airoha,en7523-reset.h> > #include <dt-bindings/reset/airoha,en7581-reset.h> > > #define RST_NR_PER_BANK 32 > @@ -299,6 +300,53 @@ static const u16 en7581_rst_ofs[] = { > REG_RST_CTRL1, > }; > > +static const u16 en7523_rst_map[] = { > + /* RST_CTRL2 */ > + [EN7523_XPON_PHY_RST] = 0, > + [EN7523_XSI_MAC_RST] = 7, > + [EN7523_XSI_PHY_RST] = 8, > + [EN7523_NPU_RST] = 9, > + [EN7523_I2S_RST] = 10, > + [EN7523_TRNG_RST] = 11, > + [EN7523_TRNG_MSTART_RST] = 12, > + [EN7523_DUAL_HSI0_RST] = 13, > + [EN7523_DUAL_HSI1_RST] = 14, > + [EN7523_HSI_RST] = 15, > + [EN7523_DUAL_HSI0_MAC_RST] = 16, > + [EN7523_DUAL_HSI1_MAC_RST] = 17, > + [EN7523_HSI_MAC_RST] = 18, > + [EN7523_WDMA_RST] = 19, > + [EN7523_WOE0_RST] = 20, > + [EN7523_WOE1_RST] = 21, > + [EN7523_HSDMA_RST] = 22, > + [EN7523_I2C2RBUS_RST] = 23, > + [EN7523_TDMA_RST] = 24, > + /* RST_CTRL1 */ > + [EN7523_PCM1_ZSI_ISI_RST] = RST_NR_PER_BANK + 0, > + [EN7523_FE_PDMA_RST] = RST_NR_PER_BANK + 1, > + [EN7523_FE_QDMA_RST] = RST_NR_PER_BANK + 2, > + [EN7523_PCM_SPIWP_RST] = RST_NR_PER_BANK + 4, > + [EN7523_CRYPTO_RST] = RST_NR_PER_BANK + 6, > + [EN7523_TIMER_RST] = RST_NR_PER_BANK + 8, > + [EN7523_PCM1_RST] = RST_NR_PER_BANK + 11, > + [EN7523_UART_RST] = RST_NR_PER_BANK + 12, > + [EN7523_GPIO_RST] = RST_NR_PER_BANK + 13, > + [EN7523_GDMA_RST] = RST_NR_PER_BANK + 14, > + [EN7523_I2C_MASTER_RST] = RST_NR_PER_BANK + 16, > + [EN7523_PCM2_ZSI_ISI_RST] = RST_NR_PER_BANK + 17, > + [EN7523_SFC_RST] = RST_NR_PER_BANK + 18, > + [EN7523_UART2_RST] = RST_NR_PER_BANK + 19, > + [EN7523_GDMP_RST] = RST_NR_PER_BANK + 20, > + [EN7523_FE_RST] = RST_NR_PER_BANK + 21, > + [EN7523_USB_HOST_P0_RST] = RST_NR_PER_BANK + 22, > + [EN7523_GSW_RST] = RST_NR_PER_BANK + 23, > + [EN7523_SFC2_PCM_RST] = RST_NR_PER_BANK + 25, > + [EN7523_PCIE0_RST] = RST_NR_PER_BANK + 26, > + [EN7523_PCIE1_RST] = RST_NR_PER_BANK + 27, > + [EN7523_PCIE_HB_RST] = RST_NR_PER_BANK + 29, > + [EN7523_XPON_MAC_RST] = RST_NR_PER_BANK + 31, > +}; > + > static const u16 en7581_rst_map[] = { > /* RST_CTRL2 */ > [EN7581_XPON_PHY_RST] = 0, > @@ -357,6 +405,9 @@ static const u16 en7581_rst_map[] = { > [EN7581_XPON_MAC_RST] = RST_NR_PER_BANK + 31, > }; > > +static int en7581_reset_register(struct device *dev, void __iomem *base, > + const u16 *rst_map, int nr_resets); > + > static u32 en7523_get_base_rate(const struct en_clk_desc *desc, u32 val) > { > if (!desc->base_bits) > @@ -552,7 +603,8 @@ static int en7523_clk_hw_init(struct platform_device *pdev, > > en7523_register_clocks(&pdev->dev, clk_data, base, np_base); > > - return 0; > + return en7581_reset_register(&pdev->dev, np_base, en7523_rst_map, > + ARRAY_SIZE(en7523_rst_map)); I wonder if this wouldn't be better moved out of hw_init(), with rst_map and the corresponding ARRAY_SIZE() stored in struct en_clk_soc_data. Registering a reset controller is not hardware initialization, after all. But that's not an issue with this patch. regards Philipp ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND v3 2/3] clk: en7523: Add reset-controller support for EN7523 SoC 2025-11-10 3:56 ` [PATCH RESEND v3 2/3] clk: en7523: Add reset-controller support for EN7523 SoC Mikhail Kshevetskiy 2025-11-10 7:53 ` Philipp Zabel @ 2025-11-14 4:09 ` Stephen Boyd 2025-11-14 23:40 ` Mikhail Kshevetskiy 1 sibling, 1 reply; 9+ messages in thread From: Stephen Boyd @ 2025-11-14 4:09 UTC (permalink / raw) To: AngeloGioacchino Del Regno, Conor Dooley, Felix Fietkau, Krzysztof Kozlowski, Matthias Brugger, Michael Turquette, Mikhail Kshevetskiy, Philipp Zabel, Rob Herring, devicetree, linux-arm-kernel, linux-clk, linux-kernel, linux-mediatek Cc: Mikhail Kshevetskiy, Andreas Gnau Quoting Mikhail Kshevetskiy (2025-11-09 19:56:44) > Introduce reset API support to EN7523 clock driver. EN7523 uses the > same reset logic as EN7581, so just reuse existing code. > > Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- Applied to clk-next ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND v3 2/3] clk: en7523: Add reset-controller support for EN7523 SoC 2025-11-14 4:09 ` Stephen Boyd @ 2025-11-14 23:40 ` Mikhail Kshevetskiy 0 siblings, 0 replies; 9+ messages in thread From: Mikhail Kshevetskiy @ 2025-11-14 23:40 UTC (permalink / raw) To: Stephen Boyd, AngeloGioacchino Del Regno, Conor Dooley, Felix Fietkau, Krzysztof Kozlowski, Matthias Brugger, Michael Turquette, Philipp Zabel, Rob Herring, devicetree, linux-arm-kernel, linux-clk, linux-kernel, linux-mediatek Cc: Andreas Gnau Hello Stephen, I can't find this and other my commit in the clk-next. Are changes was dropped? If it was dropped, could you tell me a reason? Regards, Mikhail Kshevetskiy On 11/14/25 07:09, Stephen Boyd wrote: > Quoting Mikhail Kshevetskiy (2025-11-09 19:56:44) >> Introduce reset API support to EN7523 clock driver. EN7523 uses the >> same reset logic as EN7581, so just reuse existing code. >> >> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu> >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- > Applied to clk-next ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH RESEND v3 3/3] ARM: dts: airoha: update EN7523 dtsi to support resets 2025-11-10 3:56 [PATCH RESEND v3 0/3] clk: en7523: reset-controller support for EN7523 SoC Mikhail Kshevetskiy 2025-11-10 3:56 ` [PATCH RESEND v3 1/3] dt-bindings: clock: airoha: Add reset support to EN7523 clock binding Mikhail Kshevetskiy 2025-11-10 3:56 ` [PATCH RESEND v3 2/3] clk: en7523: Add reset-controller support for EN7523 SoC Mikhail Kshevetskiy @ 2025-11-10 3:56 ` Mikhail Kshevetskiy 2 siblings, 0 replies; 9+ messages in thread From: Mikhail Kshevetskiy @ 2025-11-10 3:56 UTC (permalink / raw) To: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, Philipp Zabel, Felix Fietkau, linux-clk, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek Cc: Mikhail Kshevetskiy, Andreas Gnau This patch updates EN7523 dtsi to reflect the reset-controller support for EN7523 SoC. Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- arch/arm/boot/dts/airoha/en7523.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/airoha/en7523.dtsi b/arch/arm/boot/dts/airoha/en7523.dtsi index b523a868c4ad..231638b25c5b 100644 --- a/arch/arm/boot/dts/airoha/en7523.dtsi +++ b/arch/arm/boot/dts/airoha/en7523.dtsi @@ -4,6 +4,7 @@ #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/clock/en7523-clk.h> +#include <dt-bindings/reset/airoha,en7523-reset.h> / { interrupt-parent = <&gic>; @@ -91,6 +92,7 @@ scu: system-controller@1fa20000 { reg = <0x1fa20000 0x400>, <0x1fb00000 0x1000>; #clock-cells = <1>; + #reset-cells = <1>; }; gic: interrupt-controller@9000000 { -- 2.51.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH RESEND v3 0/3] clk: en7523: reset-controller support for EN7523 SoC @ 2025-10-17 20:11 Mikhail Kshevetskiy 2025-10-17 20:11 ` [PATCH RESEND v3 1/3] dt-bindings: clock: airoha: Add reset support to EN7523 clock binding Mikhail Kshevetskiy 0 siblings, 1 reply; 9+ messages in thread From: Mikhail Kshevetskiy @ 2025-10-17 20:11 UTC (permalink / raw) To: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, Philipp Zabel, Felix Fietkau, linux-clk, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek Cc: Mikhail Kshevetskiy, Andreas Gnau No any activity for 3 weeks, so resend. These patches: * adds reset-controller support for EN7523 SoC * updates dt-bindings * updates en7523 dtsi Reset-controller support will allow us more easily reusing of en7581 drivers for en7523. Changes v2: * keep '#reset-cells' property optional * put dtsi changes to a separate commit * add missed dtsi include Changes v3: * keep en7581 prefix for common en7523/en7581 variables and functions Mikhail Kshevetskiy (3): dt-bindings: clock: airoha: Add reset support to EN7523 clock binding clk: en7523: Add reset-controller support for EN7523 SoC ARM: dts: airoha: update EN7523 dtsi to support resets .../bindings/clock/airoha,en7523-scu.yaml | 3 +- arch/arm/boot/dts/airoha/en7523.dtsi | 2 + drivers/clk/clk-en7523.c | 64 +++++++++++++++++-- .../dt-bindings/reset/airoha,en7523-reset.h | 61 ++++++++++++++++++ 4 files changed, 123 insertions(+), 7 deletions(-) create mode 100644 include/dt-bindings/reset/airoha,en7523-reset.h -- 2.51.0 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH RESEND v3 1/3] dt-bindings: clock: airoha: Add reset support to EN7523 clock binding 2025-10-17 20:11 [PATCH RESEND v3 0/3] clk: en7523: reset-controller support for EN7523 SoC Mikhail Kshevetskiy @ 2025-10-17 20:11 ` Mikhail Kshevetskiy 0 siblings, 0 replies; 9+ messages in thread From: Mikhail Kshevetskiy @ 2025-10-17 20:11 UTC (permalink / raw) To: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, Philipp Zabel, Felix Fietkau, linux-clk, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek Cc: Mikhail Kshevetskiy, Andreas Gnau Introduce reset capability to EN7523 device-tree clock binding documentation. Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> --- .../bindings/clock/airoha,en7523-scu.yaml | 3 +- .../dt-bindings/reset/airoha,en7523-reset.h | 61 +++++++++++++++++++ 2 files changed, 62 insertions(+), 2 deletions(-) create mode 100644 include/dt-bindings/reset/airoha,en7523-reset.h diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml index fe2c5c1baf43..a8471367175b 100644 --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml @@ -64,8 +64,6 @@ allOf: reg: minItems: 2 - '#reset-cells': false - - if: properties: compatible: @@ -85,6 +83,7 @@ examples: reg = <0x1fa20000 0x400>, <0x1fb00000 0x1000>; #clock-cells = <1>; + #reset-cells = <1>; }; - | diff --git a/include/dt-bindings/reset/airoha,en7523-reset.h b/include/dt-bindings/reset/airoha,en7523-reset.h new file mode 100644 index 000000000000..211e8a23a21c --- /dev/null +++ b/include/dt-bindings/reset/airoha,en7523-reset.h @@ -0,0 +1,61 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (C) 2024 iopsys Software Solutions AB. + * Copyright (C) 2025 Genexis AB. + * + * Author: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu> + * + * based on + * include/dt-bindings/reset/airoha,en7581-reset.h + * by Lorenzo Bianconi <lorenzo@kernel.org> + */ + +#ifndef __DT_BINDINGS_RESET_CONTROLLER_AIROHA_EN7523_H_ +#define __DT_BINDINGS_RESET_CONTROLLER_AIROHA_EN7523_H_ + +/* RST_CTRL2 */ +#define EN7523_XPON_PHY_RST 0 +#define EN7523_XSI_MAC_RST 1 +#define EN7523_XSI_PHY_RST 2 +#define EN7523_NPU_RST 3 +#define EN7523_I2S_RST 4 +#define EN7523_TRNG_RST 5 +#define EN7523_TRNG_MSTART_RST 6 +#define EN7523_DUAL_HSI0_RST 7 +#define EN7523_DUAL_HSI1_RST 8 +#define EN7523_HSI_RST 9 +#define EN7523_DUAL_HSI0_MAC_RST 10 +#define EN7523_DUAL_HSI1_MAC_RST 11 +#define EN7523_HSI_MAC_RST 12 +#define EN7523_WDMA_RST 13 +#define EN7523_WOE0_RST 14 +#define EN7523_WOE1_RST 15 +#define EN7523_HSDMA_RST 16 +#define EN7523_I2C2RBUS_RST 17 +#define EN7523_TDMA_RST 18 +/* RST_CTRL1 */ +#define EN7523_PCM1_ZSI_ISI_RST 19 +#define EN7523_FE_PDMA_RST 20 +#define EN7523_FE_QDMA_RST 21 +#define EN7523_PCM_SPIWP_RST 22 +#define EN7523_CRYPTO_RST 23 +#define EN7523_TIMER_RST 24 +#define EN7523_PCM1_RST 25 +#define EN7523_UART_RST 26 +#define EN7523_GPIO_RST 27 +#define EN7523_GDMA_RST 28 +#define EN7523_I2C_MASTER_RST 29 +#define EN7523_PCM2_ZSI_ISI_RST 30 +#define EN7523_SFC_RST 31 +#define EN7523_UART2_RST 32 +#define EN7523_GDMP_RST 33 +#define EN7523_FE_RST 34 +#define EN7523_USB_HOST_P0_RST 35 +#define EN7523_GSW_RST 36 +#define EN7523_SFC2_PCM_RST 37 +#define EN7523_PCIE0_RST 38 +#define EN7523_PCIE1_RST 39 +#define EN7523_PCIE_HB_RST 40 +#define EN7523_XPON_MAC_RST 41 + +#endif /* __DT_BINDINGS_RESET_CONTROLLER_AIROHA_EN7523_H_ */ -- 2.51.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-11-14 23:40 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-11-10 3:56 [PATCH RESEND v3 0/3] clk: en7523: reset-controller support for EN7523 SoC Mikhail Kshevetskiy 2025-11-10 3:56 ` [PATCH RESEND v3 1/3] dt-bindings: clock: airoha: Add reset support to EN7523 clock binding Mikhail Kshevetskiy 2025-11-14 4:09 ` Stephen Boyd 2025-11-10 3:56 ` [PATCH RESEND v3 2/3] clk: en7523: Add reset-controller support for EN7523 SoC Mikhail Kshevetskiy 2025-11-10 7:53 ` Philipp Zabel 2025-11-14 4:09 ` Stephen Boyd 2025-11-14 23:40 ` Mikhail Kshevetskiy 2025-11-10 3:56 ` [PATCH RESEND v3 3/3] ARM: dts: airoha: update EN7523 dtsi to support resets Mikhail Kshevetskiy -- strict thread matches above, loose matches on Subject: below -- 2025-10-17 20:11 [PATCH RESEND v3 0/3] clk: en7523: reset-controller support for EN7523 SoC Mikhail Kshevetskiy 2025-10-17 20:11 ` [PATCH RESEND v3 1/3] dt-bindings: clock: airoha: Add reset support to EN7523 clock binding Mikhail Kshevetskiy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox