Re: [PATCH 2/3] dt-bindings: clock: amlogic: t7: Add missing mpll3 parent clock

[Jian Hu <jian.hu@amlogic.com>]

On 3/6/2026 4:14 PM, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On Thu, Mar 05, 2026 at 10:03:32AM +0100, Jerome Brunet wrote:
>> On jeu. 05 mars 2026 at 15:43, Jian Hu <jian.hu@amlogic.com> wrote:
>>
>>> The mpll3 clock is a valid parent clock for sd_emmc and mipi_isp on
>>> the Amlogic T7 SoC, but was missing from t7-peripherals-clkc.yaml.
>>> Add it to enable proper clock parent configuration for these peripherals.
>> ... but this changes the index of the clocks after this mpll3, and those
>> index are supposed to be stable if I'm not mistaken.
>>
>> It is indeed more convenient to have the optional clocks at the end
>> as it avoids writing multiple <0> in DT when we do not have them.
>>
>> At the very least, your commit description should say that this change
>> will not break any existing DT because these bindings are not used yet.
>>
>> I leave it to the DT folks to say if the change is OK in such case.
> Based on commit msg it is not OK, that's why we ask about explaining
> true problem and actual impact, IOW whether this did not work in the
> first place and authors did not bother to test it...


Thank you for the clarification and explanation.

mpll3 is one of the clock sources for sd_emmc, and this use case was 
indeed not verified in the initial version.

mpll3 is typically used by the audio module and is one of the required 
clock sources for the audio clock driver.

In practice, sd_emmc does not use mpll3.
During testing, only the other clock sources of sd_emmc were verified: 
fdivx, gp0, hifi.
I apologize for this oversight.

Even though sd_emmc does not use mpll3, the clock driver should still 
support it as a valid clock source.

Additionally, I have confirmed that all required clock sources are 
defined in the T7 peripheral device tree.

I will update the commit message to state that this change does not 
affect the ABI.
> Best regards,
> Krzysztof
>