Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jian Hu <jian.hu@amlogic.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	 Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	 Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Stephen Boyd <sboyd@kernel.org>,
	 Michael Turquette <mturquette@baylibre.com>,
	robh+dt <robh+dt@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 devicetree <devicetree@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	 linux-amlogic <linux-amlogic@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Ronald Claveau <linux-kernel-dev@aliel.fr>
Subject: Re: [PATCH 2/3] dt-bindings: clock: amlogic: t7: Add missing mpll3 parent clock
Date: Fri, 6 Mar 2026 09:12:33 +0100	[thread overview]
Message-ID: <20260306-monumental-nuthatch-from-avalon-bf108b@quoll> (raw)
In-Reply-To: <20260305074328.639993-3-jian.hu@amlogic.com>

On Thu, Mar 05, 2026 at 03:43:26PM +0800, Jian Hu wrote:
> The mpll3 clock is a valid parent clock for sd_emmc and mipi_isp on
> the Amlogic T7 SoC, but was missing from t7-peripherals-clkc.yaml.
> Add it to enable proper clock parent configuration for these peripherals.
> 
> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
> ---
>  .../bindings/clock/amlogic,t7-peripherals-clkc.yaml       | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/amlogic,t7-peripherals-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,t7-peripherals-clkc.yaml
> index 55bb73707d58..27cc1f331587 100644
> --- a/Documentation/devicetree/bindings/clock/amlogic,t7-peripherals-clkc.yaml
> +++ b/Documentation/devicetree/bindings/clock/amlogic,t7-peripherals-clkc.yaml
> @@ -24,7 +24,7 @@ properties:
>      const: 1
>  
>    clocks:
> -    minItems: 14
> +    minItems: 15
>      items:
>        - description: input oscillator
>        - description: input sys clk
> @@ -40,12 +40,13 @@ properties:
>        - description: input gp1 pll
>        - description: input mpll1
>        - description: input mpll2
> +      - description: input mpll3

Nah, ABI break. You add it to the end of the list or provide arguments
on ABI impact.

Best regards,
Krzysztof



  parent reply	other threads:[~2026-03-06  8:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05  7:43 [PATCH 0/3] Add the missing mpll3 clock and clock controller nodes Jian Hu
2026-03-05  7:43 ` [PATCH 1/3] dt-bindings: clock: amlogic: Fix a typo Jian Hu
2026-03-05  8:57   ` Jerome Brunet
2026-03-06  6:57     ` Jian Hu
2026-03-06  8:11   ` Krzysztof Kozlowski
2026-03-09  3:28     ` Jian Hu
2026-03-05  7:43 ` [PATCH 2/3] dt-bindings: clock: amlogic: t7: Add missing mpll3 parent clock Jian Hu
2026-03-05  9:03   ` Jerome Brunet
2026-03-06  7:36     ` Jian Hu
2026-03-06  8:14     ` Krzysztof Kozlowski
2026-03-10  7:42       ` Jian Hu
2026-03-05 13:45   ` Rob Herring (Arm)
2026-03-06  7:53     ` Jian Hu
2026-03-06  8:12   ` Krzysztof Kozlowski [this message]
2026-03-10  6:51     ` Jian Hu
2026-03-10  7:08       ` Krzysztof Kozlowski
2026-03-10 12:38         ` Jian Hu
2026-03-05  7:43 ` [PATCH 3/3] arm64: dts: amlogic: t7: Add clock controller nodes Jian Hu
2026-03-05  9:04   ` Jerome Brunet
2026-03-06  7:42     ` Jian Hu
2026-03-06  7:47   ` Ronald Claveau
2026-03-06  8:10     ` Jian Hu
2026-03-10 17:30   ` Ferass El Hafidi
2026-03-11  3:36     ` Jian Hu
2026-03-11  7:53   ` Ronald Claveau
2026-03-11 11:48     ` Jian Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260306-monumental-nuthatch-from-avalon-bf108b@quoll \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=jian.hu@amlogic.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel-dev@aliel.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mturquette@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox