From: jamie@shareable.org (Jamie Lokier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Use definition for cmpxchg swi
Date: Mon, 9 Nov 2009 19:08:52 +0000 [thread overview]
Message-ID: <20091109190852.GD3808@shareable.org> (raw)
In-Reply-To: <20091109173040.GA24358@n2100.arm.linux.org.uk>
Russell King - ARM Linux wrote:
> I'll add a comment then.
>
> Note, however, that the original code was buggy - it resulted in
> the '0xfff0' syscall being called instead of '0xffff0' - note the
> extra 4 bits there.
Meaning that nobody has ever actually used the original code? :-)
I notice that it loads the syscall number register for EABI
compatibility, but that instruction could be trivially omitted with
OABI-compatible kernels, couldn't it?
By the way, did you change it to LDR to make it faster? (I.e. does
that make it faster?)
-- Jamie
next prev parent reply other threads:[~2009-11-09 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-08 20:04 [PATCH] Use definition for cmpxchg swi Russell King - ARM Linux
2009-11-09 1:42 ` Nicolas Pitre
2009-11-09 8:51 ` Russell King - ARM Linux
2009-11-09 14:56 ` Nicolas Pitre
2009-11-09 17:30 ` Russell King - ARM Linux
2009-11-09 19:08 ` Jamie Lokier [this message]
2009-11-09 19:14 ` Russell King - ARM Linux
2009-11-09 19:31 ` Nicolas Pitre
2009-11-09 23:52 ` Russell King - ARM Linux
2009-11-09 23:58 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109190852.GD3808@shareable.org \
--to=jamie@shareable.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox