From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [v4 PATCH 12/12] ARM: dts: add spi nodes for the atmel boards
Date: Fri, 8 Feb 2013 17:55:30 +0100 [thread overview]
Message-ID: <20130208165530.GG30595@game.jcrosoft.org> (raw)
In-Reply-To: <B256D81BAE5131468A838E5D7A2436413A0875A3@penmbx02>
On 01:51 Fri 08 Feb , Yang, Wenyou wrote:
> Hello, JC
>
> > -----Original Message-----
> > From: Yang, Wenyou
> > Sent: 2013?2?6? 9:35
> > To: 'Jean-Christophe PLAGNIOL-VILLARD'
> > Cc: linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org; Ferre,
> > Nicolas; richard.genoud at gmail.com; Lin, JM; linux at arm.linux.org.uk
> > Subject: RE: [v4 PATCH 12/12] ARM: dts: add spi nodes for the atmel boards
> >
> >
> >
> > > -----Original Message-----
> > > From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
> > > Sent: 2013?2?6? 3:50
> > > To: Yang, Wenyou
> > > Cc: linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org;
> > Ferre,
> > > Nicolas; richard.genoud at gmail.com; Lin, JM; linux at arm.linux.org.uk
> > > Subject: Re: [v4 PATCH 12/12] ARM: dts: add spi nodes for the atmel boards
> > >
> > > On 15:34 Mon 14 Jan , Wenyou Yang wrote:
> > > > From: Richard Genoud <richard.genoud@gmail.com>
> > > >
> > > > Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> > > > [wenyou.yang at atmel.com: added spi nodes for the sam9263ek,
> > sam9g20ek,
> > > sam9m10g45ek and sam9n12ek boards]
> > > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > > > Cc: linux at arm.linux.org.uk
> > > > ---
> > > > arch/arm/boot/dts/at91sam9263ek.dts | 14
> > > ++++++++++++++
> > > > arch/arm/boot/dts/at91sam9g20ek_common.dtsi | 14
> > > ++++++++++++++
> > > > arch/arm/boot/dts/at91sam9m10g45ek.dts | 14
> > > ++++++++++++++
> > > > arch/arm/boot/dts/at91sam9n12ek.dts | 14
> > > ++++++++++++++
> > > > arch/arm/boot/dts/at91sam9x5ek.dtsi | 14
> > ++++++++++++++
> > > > 5 files changed, 70 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/at91sam9263ek.dts
> > > b/arch/arm/boot/dts/at91sam9263ek.dts
> > > > index 1eb0872..63ba57b 100644
> > > > --- a/arch/arm/boot/dts/at91sam9263ek.dts
> > > > +++ b/arch/arm/boot/dts/at91sam9263ek.dts
> > > > @@ -79,6 +79,20 @@
> > > > };
> > > > };
> > > > };
> > > > +
> > > > + spi0: spi at fffa4000 {
> > > > + status = "okay";
> > > > + cs-gpios = <&pioA 5 0
> > > > + &pioA 3 0
> > > > + &pioA 4 0
> > > > + &pioB 11 0
> > > NACK
> > >
> > > we no use that much as cs-gpios on this hw
> >
> > Thanks for your feedback.
> >
> > Listing the all choices for cs-gpios, one cs-gpio is selected by reg value.
> > Maybe listing one cs-gpio is OK.
> > I will try it.
> >
> > I am going to dig the feasibility of removing cs-gpios.
>
> I need remain the list of cs-gpios, because "master->num_chipselect" is got from the number of item of this list.
> If this list is removed, only the cs-gpio for used chip-select is provided , it works for CS0 chip-select, but it fails to work for other than CS0, e.g. CS1.
>
I did the cs-gpios support you can not expect to do not have it on at91
but you need to ONLY provide the used gpio not ALL
Best Regards,
J.
> Could you give me some idea?
> Thank you in advance.
>
> >
> > > > + >;
> > > > + mtd_dataflash at 0 {
> > > > + compatible = "atmel,at45", "atmel,dataflash";
> > > > + spi-max-frequency = <50000000>;
> > > > + reg = <0>;
> > > > + };
> > > > + };
> > > > };
> > > >
> > > > nand0: nand at 40000000 {
> > > > diff --git a/arch/arm/boot/dts/at91sam9g20ek_common.dtsi
> > > b/arch/arm/boot/dts/at91sam9g20ek_common.dtsi
> > > > index da15e83..49ad49e 100644
> > > > --- a/arch/arm/boot/dts/at91sam9g20ek_common.dtsi
> > > > +++ b/arch/arm/boot/dts/at91sam9g20ek_common.dtsi
> > > > @@ -96,6 +96,20 @@
> > > > status = "okay";
> > > > pinctrl-0 = <&pinctrl_ssc0_tx>;
> > > > };
> > > > +
> > > > + spi0: spi at fffc8000 {
> > > > + status = "okay";
> > > > + cs-gpios = <&pioA 3 0
> > > > + &pioC 11 0
> > > > + &pioC 16 0
> > > > + &pioC 17 0
> > > ditto and so on
> > >
> > > you must only provife the gpio use by the hw
> > > > + >;
> > > > + mtd_dataflash at 0 {
> > > > + compatible = "atmel,at45", "atmel,dataflash";
> > > > + spi-max-frequency = <50000000>;
> > > > + reg = <1>;
> > > > + };
> > > > + };
> > > > };
> > > >
> > > > nand0: nand at 40000000 {
> > > > diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts
> > > b/arch/arm/boot/dts/at91sam9m10g45ek.dts
> > > > index 20c3191..275f22d 100644
> > > > --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts
> > > > +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts
> > > > @@ -102,6 +102,20 @@
> > > > };
> > > > };
> > > > };
> > > > +
> > > > + spi0: spi at fffa4000{
> > > > + status = "okay";
> > > > + cs-gpios = <&pioB 3 0
> > > > + &pioB 18 0
> > > > + &pioB 19 0
> > > > + &pioD 27 0
> > > > + >;
> > > > + mtd_dataflash at 0 {
> > > > + compatible = "atmel,at45", "atmel,dataflash";
> > > > + spi-max-frequency = <13000000>;
> > > > + reg = <0>;
> > > > + };
> > > > + };
> > > > };
> > > >
> > > > nand0: nand at 40000000 {
> > > > diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts
> > > b/arch/arm/boot/dts/at91sam9n12ek.dts
> > > > index 0376bf4..4eeca7b 100644
> > > > --- a/arch/arm/boot/dts/at91sam9n12ek.dts
> > > > +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
> > > > @@ -67,6 +67,20 @@
> > > > };
> > > > };
> > > > };
> > > > +
> > > > + spi0: spi at f0000000 {
> > > > + status = "okay";
> > > > + cs-gpios = <&pioA 14 0
> > > > + &pioA 7 0
> > > > + &pioA 1 0
> > > > + &pioB 3 0
> > > > + >;
> > > > + m25p80 at 0 {
> > > > + compatible = "atmel,at25df321a";
> > > > + spi-max-frequency = <50000000>;
> > > > + reg = <0>;
> > > > + };
> > > > + };
> > > > };
> > > >
> > > > nand0: nand at 40000000 {
> > > > diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi
> > > b/arch/arm/boot/dts/at91sam9x5ek.dtsi
> > > > index 8a7cf1d..ca0a056 100644
> > > > --- a/arch/arm/boot/dts/at91sam9x5ek.dtsi
> > > > +++ b/arch/arm/boot/dts/at91sam9x5ek.dtsi
> > > > @@ -84,6 +84,20 @@
> > > > };
> > > > };
> > > > };
> > > > +
> > > > + spi0: spi at f0000000 {
> > > > + status = "okay";
> > > > + cs-gpios = <&pioA 14 0
> > > > + &pioA 7 0
> > > > + &pioA 1 0
> > > > + &pioB 3 0
> > > > + >;
> > > > + m25p80 at 0 {
> > > > + compatible = "atmel,at25df321a";
> > > > + spi-max-frequency = <50000000>;
> > > > + reg = <0>;
> > > > + };
> > > > + };
> > > > };
> > > >
> > > > usb0: ohci at 00600000 {
> > > > --
> > > > 1.7.9.5
> > > >
> >
> > Best Regards,
> > Wenyou Yang
>
> Best Regards,
> Wenyou Yang
next prev parent reply other threads:[~2013-02-08 16:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 7:34 [v4 PATCH 00/12] atmel spi controller with dmaengine and device tree support Wenyou Yang
2013-01-14 7:34 ` [v4 PATCH 01/12] spi/atmel_spi: add physical base address Wenyou Yang
2013-01-14 7:34 ` [v4 PATCH 02/12] spi/atmel_spi: call unmapping on transfers buffers Wenyou Yang
2013-01-14 7:34 ` [v4 PATCH 03/12] spi/atmel_spi: status information passed through controller data Wenyou Yang
2013-01-14 7:34 ` [v4 PATCH 04/12] spi/atmel_spi: add flag to controller data for lock operations Wenyou Yang
2013-01-14 7:34 ` [v4 PATCH 05/12] spi/atmel_spi: update the dt support Wenyou Yang
2013-02-05 20:04 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-06 1:19 ` Yang, Wenyou
2013-01-14 7:34 ` [v4 PATCH 06/12] spi/atmel_spi: add dmaengine support Wenyou Yang
2013-01-23 16:25 ` Richard Genoud
2013-01-24 0:44 ` Yang, Wenyou
2013-01-14 7:34 ` [v4 PATCH 07/12] spi/atmel_spi: fix spi-atmel driver to adapt to slave_config changes Wenyou Yang
2013-01-14 7:34 ` [v4 PATCH 08/12] spi/atmel_spi: correct 16 bits transfers using PIO Wenyou Yang
2013-01-14 7:34 ` [v4 PATCH 09/12] spi/atmel_spi: correct 16 bits transfer with DMA Wenyou Yang
2013-01-14 7:34 ` [v4 PATCH 10/12] ARM: at91: add clocks for spi dt entries Wenyou Yang
2013-01-14 7:34 ` [v4 PATCH 11/12] ARM: dts: add spi nodes for atmel SoC Wenyou Yang
2013-02-05 19:51 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-06 1:35 ` Yang, Wenyou
2013-02-06 9:40 ` Nicolas Ferre
2013-01-14 7:34 ` [v4 PATCH 12/12] ARM: dts: add spi nodes for the atmel boards Wenyou Yang
2013-02-05 19:50 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-06 1:34 ` Yang, Wenyou
2013-02-08 1:51 ` Yang, Wenyou
2013-02-08 16:55 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-01-18 8:46 ` [v4 PATCH 00/12] atmel spi controller with dmaengine and device tree support Richard Genoud
2013-01-18 9:31 ` Yang, Wenyou
2013-02-05 14:14 ` Grant Likely
2013-02-05 20:06 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-06 8:33 ` Yang, Wenyou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208165530.GG30595@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox