* [patch] pinctrl: rockchip: missing unlock on error in rockchip_set_pull()
@ 2013-11-14 8:22 Dan Carpenter
2013-11-14 15:51 ` Heiko Stübner
2013-11-19 8:39 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-11-14 8:22 UTC (permalink / raw)
To: linux-arm-kernel
We need to unlock here before returning -EINVAL.
Fixes: 6ca5274d1d12 ('pinctrl: rockchip: add rk3188 specifics')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index e939c28..bfd1824 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -504,6 +504,7 @@ static int rockchip_set_pull(struct rockchip_pin_bank *bank,
data |= (3 << bit);
break;
default:
+ spin_unlock_irqrestore(&bank->slock, flags);
dev_err(info->dev, "unsupported pull setting %d\n",
pull);
return -EINVAL;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [patch] pinctrl: rockchip: missing unlock on error in rockchip_set_pull()
2013-11-14 8:22 [patch] pinctrl: rockchip: missing unlock on error in rockchip_set_pull() Dan Carpenter
@ 2013-11-14 15:51 ` Heiko Stübner
2013-11-19 8:39 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2013-11-14 15:51 UTC (permalink / raw)
To: linux-arm-kernel
Am Donnerstag, 14. November 2013, 09:22:54 schrieb Dan Carpenter:
> We need to unlock here before returning -EINVAL.
I seem to say this a lot recently: thanks for the catch :-)
> Fixes: 6ca5274d1d12 ('pinctrl: rockchip: add rk3188 specifics')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c
> b/drivers/pinctrl/pinctrl-rockchip.c index e939c28..bfd1824 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -504,6 +504,7 @@ static int rockchip_set_pull(struct rockchip_pin_bank
> *bank, data |= (3 << bit);
> break;
> default:
> + spin_unlock_irqrestore(&bank->slock, flags);
> dev_err(info->dev, "unsupported pull setting %d\n",
> pull);
> return -EINVAL;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [patch] pinctrl: rockchip: missing unlock on error in rockchip_set_pull()
2013-11-14 8:22 [patch] pinctrl: rockchip: missing unlock on error in rockchip_set_pull() Dan Carpenter
2013-11-14 15:51 ` Heiko Stübner
@ 2013-11-19 8:39 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-11-19 8:39 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 14, 2013 at 9:22 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We need to unlock here before returning -EINVAL.
>
> Fixes: 6ca5274d1d12 ('pinctrl: rockchip: add rk3188 specifics')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied with Heiko's ACK.
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-19 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-14 8:22 [patch] pinctrl: rockchip: missing unlock on error in rockchip_set_pull() Dan Carpenter
2013-11-14 15:51 ` Heiko Stübner
2013-11-19 8:39 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox