* [PATCH] ARM: tegra: add missing break to fuse initialization code
@ 2013-12-06 20:33 Stephen Warren
2013-12-06 21:09 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Warren @ 2013-12-06 20:33 UTC (permalink / raw)
To: linux-arm-kernel
From: Stephen Warren <swarren@nvidia.com>
Add a missing break to the switch in tegra_init_fuse() which determines
which SoC the code is running on. This prevents the Tegra30+ fuse
handling code from running on Tegra20.
Fixes: 3bd1ae57f7bb ("ARM: tegra: add fuses as device randomness")
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
This is a fix for 3.13.
arch/arm/mach-tegra/fuse.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-tegra/fuse.c b/arch/arm/mach-tegra/fuse.c
index 9a4e910c3796..13995b0be9d9 100644
--- a/arch/arm/mach-tegra/fuse.c
+++ b/arch/arm/mach-tegra/fuse.c
@@ -198,6 +198,7 @@ void __init tegra_init_fuse(void)
switch (tegra_chip_id) {
case TEGRA20:
tegra20_fuse_init_randomness();
+ break;
case TEGRA30:
case TEGRA114:
default:
--
1.8.1.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM: tegra: add missing break to fuse initialization code
2013-12-06 20:33 [PATCH] ARM: tegra: add missing break to fuse initialization code Stephen Warren
@ 2013-12-06 21:09 ` Thierry Reding
2013-12-12 1:08 ` Olof Johansson
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2013-12-06 21:09 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 06, 2013 at 01:33:50PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Add a missing break to the switch in tegra_init_fuse() which determines
> which SoC the code is running on. This prevents the Tegra30+ fuse
> handling code from running on Tegra20.
>
> Fixes: 3bd1ae57f7bb ("ARM: tegra: add fuses as device randomness")
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> This is a fix for 3.13.
>
> arch/arm/mach-tegra/fuse.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-tegra/fuse.c b/arch/arm/mach-tegra/fuse.c
> index 9a4e910c3796..13995b0be9d9 100644
> --- a/arch/arm/mach-tegra/fuse.c
> +++ b/arch/arm/mach-tegra/fuse.c
> @@ -198,6 +198,7 @@ void __init tegra_init_fuse(void)
> switch (tegra_chip_id) {
> case TEGRA20:
> tegra20_fuse_init_randomness();
> + break;
> case TEGRA30:
> case TEGRA114:
> default:
The code that follows here also doesn't have a break. While not strictly
necessary it might be good to have one for consistency. Either way,
though:
Reviewed-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131206/55e25ca4/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ARM: tegra: add missing break to fuse initialization code
2013-12-06 21:09 ` Thierry Reding
@ 2013-12-12 1:08 ` Olof Johansson
0 siblings, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2013-12-12 1:08 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 06, 2013 at 10:09:57PM +0100, Thierry Reding wrote:
> On Fri, Dec 06, 2013 at 01:33:50PM -0700, Stephen Warren wrote:
> > From: Stephen Warren <swarren@nvidia.com>
> >
> > Add a missing break to the switch in tegra_init_fuse() which determines
> > which SoC the code is running on. This prevents the Tegra30+ fuse
> > handling code from running on Tegra20.
> >
> > Fixes: 3bd1ae57f7bb ("ARM: tegra: add fuses as device randomness")
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
> > ---
> > This is a fix for 3.13.
> >
> > arch/arm/mach-tegra/fuse.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/mach-tegra/fuse.c b/arch/arm/mach-tegra/fuse.c
> > index 9a4e910c3796..13995b0be9d9 100644
> > --- a/arch/arm/mach-tegra/fuse.c
> > +++ b/arch/arm/mach-tegra/fuse.c
> > @@ -198,6 +198,7 @@ void __init tegra_init_fuse(void)
> > switch (tegra_chip_id) {
> > case TEGRA20:
> > tegra20_fuse_init_randomness();
> > + break;
> > case TEGRA30:
> > case TEGRA114:
> > default:
>
> The code that follows here also doesn't have a break. While not strictly
> necessary it might be good to have one for consistency. Either way,
> though:
>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
Applied, thanks.
-Olof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-12 1:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-06 20:33 [PATCH] ARM: tegra: add missing break to fuse initialization code Stephen Warren
2013-12-06 21:09 ` Thierry Reding
2013-12-12 1:08 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox