[PATCH] arm: spear6xx: add labels to various nodes in spear600.dtsi

[PATCH] arm: spear6xx: add labels to various nodes in spear600.dtsi

[Thomas Petazzoni]

Having labels allows to more easily reference nodes in .dts files
including spear600.dtsi.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm/boot/dts/spear600.dtsi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/spear600.dtsi b/arch/arm/boot/dts/spear600.dtsi
index 9f60a7b..55b23f5 100644
--- a/arch/arm/boot/dts/spear600.dtsi
+++ b/arch/arm/boot/dts/spear600.dtsi
@@ -57,7 +57,7 @@
 			status = "disabled";
 		};
 
-		dma at fc400000 {
+		dmac: dma at fc400000 {
 			compatible = "arm,pl080", "arm,primecell";
 			reg = <0xfc400000 0x1000>;
 			interrupt-parent = <&vic1>;
@@ -97,7 +97,7 @@
 			status = "disabled";
 		};
 
-		ehci at e1800000 {
+		ehci_usb0: ehci at e1800000 {
 			compatible = "st,spear600-ehci", "usb-ehci";
 			reg = <0xe1800000 0x1000>;
 			interrupt-parent = <&vic1>;
@@ -105,7 +105,7 @@
 			status = "disabled";
 		};
 
-		ehci at e2000000 {
+		ehci_usb1: ehci at e2000000 {
 			compatible = "st,spear600-ehci", "usb-ehci";
 			reg = <0xe2000000 0x1000>;
 			interrupt-parent = <&vic1>;
@@ -113,7 +113,7 @@
 			status = "disabled";
 		};
 
-		ohci at e1900000 {
+		ohci_usb0: ohci at e1900000 {
 			compatible = "st,spear600-ohci", "usb-ohci";
 			reg = <0xe1900000 0x1000>;
 			interrupt-parent = <&vic1>;
@@ -121,7 +121,7 @@
 			status = "disabled";
 		};
 
-		ohci at e2100000 {
+		ohci_usb1: ohci at e2100000 {
 			compatible = "st,spear600-ohci", "usb-ohci";
 			reg = <0xe2100000 0x1000>;
 			interrupt-parent = <&vic1>;
@@ -135,7 +135,7 @@
 			compatible = "simple-bus";
 			ranges = <0xd0000000 0xd0000000 0x30000000>;
 
-			serial at d0000000 {
+			uart0: serial at d0000000 {
 				compatible = "arm,pl011", "arm,primecell";
 				reg = <0xd0000000 0x1000>;
 				interrupt-parent = <&vic0>;
@@ -143,7 +143,7 @@
 				status = "disabled";
 			};
 
-			serial at d0080000 {
+			uart1: serial at d0080000 {
 				compatible = "arm,pl011", "arm,primecell";
 				reg = <0xd0080000 0x1000>;
 				interrupt-parent = <&vic0>;
-- 
2.7.4

[PATCH] arm: spear6xx: add labels to various nodes in spear600.dtsi

[Viresh Kumar]

On 21-03-17, 11:07, Thomas Petazzoni wrote:
> Having labels allows to more easily reference nodes in .dts files
> including spear600.dtsi.

And who is going to use these labels? If you already have some code
using them, then please send that as well. This patch by itself
doesn't provide any benefits.

-- 
viresh

[PATCH] arm: spear6xx: add labels to various nodes in spear600.dtsi

[Thomas Petazzoni]

Hello,

Thanks for the quick feedback!

On Tue, 21 Mar 2017 15:40:09 +0530, Viresh Kumar wrote:

> And who is going to use these labels? If you already have some code
> using them, then please send that as well. This patch by itself
> doesn't provide any benefits.

I'm using it for a custom platform that doesn't make sense to upstream
the support for.

However, if you would like them to be used mainline, I can send a patch
that updates spear600-evb.dts to use those labels. Would this make
sense?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[PATCH] arm: spear6xx: add labels to various nodes in spear600.dtsi

[Viresh Kumar]

On 21-03-17, 11:17, Thomas Petazzoni wrote:
> On Tue, 21 Mar 2017 15:40:09 +0530, Viresh Kumar wrote:
> 
> > And who is going to use these labels? If you already have some code
> > using them, then please send that as well. This patch by itself
> > doesn't provide any benefits.
> 
> I'm using it for a custom platform that doesn't make sense to upstream
> the support for.

What about keeping this patch as well out of tree then? I don't see
any value in adding labels if we aren't going to use them in mainline.
And some newbie may try to send a patch coming forward to get rid of
them, which we wouldn't be able to oppose then :)

> However, if you would like them to be used mainline, I can send a patch
> that updates spear600-evb.dts to use those labels. Would this make
> sense?

If we can use the labels, then yes those can be added and no one will
oppose them.

-- 
viresh