* [PATCH] arm64: mm: Clarify a printk in data_abort_decode()
@ 2017-10-05 12:59 Dan Carpenter
2017-10-05 13:04 ` Mark Rutland
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2017-10-05 12:59 UTC (permalink / raw)
To: linux-arm-kernel
The 0x in front of a base 10 number is misleading so I removed it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
index 89993c4be1be..a5382e90418c 100644
--- a/arch/arm64/mm/fault.c
+++ b/arch/arm64/mm/fault.c
@@ -97,7 +97,7 @@ static void data_abort_decode(unsigned int esr)
(esr & ESR_ELx_SF) >> ESR_ELx_SF_SHIFT,
(esr & ESR_ELx_AR) >> ESR_ELx_AR_SHIFT);
} else {
- pr_alert(" ISV = 0, ISS = 0x%08lu\n", esr & ESR_ELx_ISS_MASK);
+ pr_alert(" ISV = 0, ISS = %08lu\n", esr & ESR_ELx_ISS_MASK);
}
pr_alert(" CM = %lu, WnR = %lu\n",
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] arm64: mm: Clarify a printk in data_abort_decode()
2017-10-05 12:59 [PATCH] arm64: mm: Clarify a printk in data_abort_decode() Dan Carpenter
@ 2017-10-05 13:04 ` Mark Rutland
2017-10-05 13:22 ` Dan Carpenter
2017-10-05 15:05 ` Catalin Marinas
0 siblings, 2 replies; 5+ messages in thread
From: Mark Rutland @ 2017-10-05 13:04 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Thu, Oct 05, 2017 at 03:59:14PM +0300, Dan Carpenter wrote:
> The 0x in front of a base 10 number is misleading so I removed it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 89993c4be1be..a5382e90418c 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -97,7 +97,7 @@ static void data_abort_decode(unsigned int esr)
> (esr & ESR_ELx_SF) >> ESR_ELx_SF_SHIFT,
> (esr & ESR_ELx_AR) >> ESR_ELx_AR_SHIFT);
> } else {
> - pr_alert(" ISV = 0, ISS = 0x%08lu\n", esr & ESR_ELx_ISS_MASK);
> + pr_alert(" ISV = 0, ISS = %08lu\n", esr & ESR_ELx_ISS_MASK);
A fix has already been queued [0,1], ensuring this is printed as hex.
Catalin, I see that hasn't been pushed out to the arm64 fixes/core
branch. Is that deliberate?
Thanks,
Mark.
[0] https://lkml.kernel.org/r/1506944520-21998-1-git-send-email-mark.rutland at arm.com
[1] https://lkml.kernel.org/r/20171002140632.alqo4u5dn5uenjt7 at armageddon.cambridge.arm.com
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] arm64: mm: Clarify a printk in data_abort_decode()
2017-10-05 13:04 ` Mark Rutland
@ 2017-10-05 13:22 ` Dan Carpenter
2017-10-05 13:29 ` Mark Rutland
2017-10-05 15:05 ` Catalin Marinas
1 sibling, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2017-10-05 13:22 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 05, 2017 at 02:04:36PM +0100, Mark Rutland wrote:
> Hi,
>
> On Thu, Oct 05, 2017 at 03:59:14PM +0300, Dan Carpenter wrote:
> > The 0x in front of a base 10 number is misleading so I removed it.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> > index 89993c4be1be..a5382e90418c 100644
> > --- a/arch/arm64/mm/fault.c
> > +++ b/arch/arm64/mm/fault.c
> > @@ -97,7 +97,7 @@ static void data_abort_decode(unsigned int esr)
> > (esr & ESR_ELx_SF) >> ESR_ELx_SF_SHIFT,
> > (esr & ESR_ELx_AR) >> ESR_ELx_AR_SHIFT);
> > } else {
> > - pr_alert(" ISV = 0, ISS = 0x%08lu\n", esr & ESR_ELx_ISS_MASK);
> > + pr_alert(" ISV = 0, ISS = %08lu\n", esr & ESR_ELx_ISS_MASK);
>
> A fix has already been queued [0,1], ensuring this is printed as hex.
>
> Catalin, I see that hasn't been pushed out to the arm64 fixes/core
> branch. Is that deliberate?
>
Stephen is on vacation so there is no linux-next and I'm on ancient code
anyway. :/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] arm64: mm: Clarify a printk in data_abort_decode()
2017-10-05 13:22 ` Dan Carpenter
@ 2017-10-05 13:29 ` Mark Rutland
0 siblings, 0 replies; 5+ messages in thread
From: Mark Rutland @ 2017-10-05 13:29 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 05, 2017 at 04:22:42PM +0300, Dan Carpenter wrote:
> On Thu, Oct 05, 2017 at 02:04:36PM +0100, Mark Rutland wrote:
> > Hi,
> >
> > On Thu, Oct 05, 2017 at 03:59:14PM +0300, Dan Carpenter wrote:
> > > The 0x in front of a base 10 number is misleading so I removed it.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > >
> > > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> > > index 89993c4be1be..a5382e90418c 100644
> > > --- a/arch/arm64/mm/fault.c
> > > +++ b/arch/arm64/mm/fault.c
> > > @@ -97,7 +97,7 @@ static void data_abort_decode(unsigned int esr)
> > > (esr & ESR_ELx_SF) >> ESR_ELx_SF_SHIFT,
> > > (esr & ESR_ELx_AR) >> ESR_ELx_AR_SHIFT);
> > > } else {
> > > - pr_alert(" ISV = 0, ISS = 0x%08lu\n", esr & ESR_ELx_ISS_MASK);
> > > + pr_alert(" ISV = 0, ISS = %08lu\n", esr & ESR_ELx_ISS_MASK);
> >
> > A fix has already been queued [0,1], ensuring this is printed as hex.
> >
> > Catalin, I see that hasn't been pushed out to the arm64 fixes/core
> > branch. Is that deliberate?
>
> Stephen is on vacation so there is no linux-next and I'm on ancient code
> anyway. :/
Sure; it's just easier to peek at fixes/core than to trawl the list when
it's up-to-date. ;)
Thanks,
Mark.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: mm: Clarify a printk in data_abort_decode()
2017-10-05 13:04 ` Mark Rutland
2017-10-05 13:22 ` Dan Carpenter
@ 2017-10-05 15:05 ` Catalin Marinas
1 sibling, 0 replies; 5+ messages in thread
From: Catalin Marinas @ 2017-10-05 15:05 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 05, 2017 at 02:04:36PM +0100, Mark Rutland wrote:
> On Thu, Oct 05, 2017 at 03:59:14PM +0300, Dan Carpenter wrote:
> > The 0x in front of a base 10 number is misleading so I removed it.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> > index 89993c4be1be..a5382e90418c 100644
> > --- a/arch/arm64/mm/fault.c
> > +++ b/arch/arm64/mm/fault.c
> > @@ -97,7 +97,7 @@ static void data_abort_decode(unsigned int esr)
> > (esr & ESR_ELx_SF) >> ESR_ELx_SF_SHIFT,
> > (esr & ESR_ELx_AR) >> ESR_ELx_AR_SHIFT);
> > } else {
> > - pr_alert(" ISV = 0, ISS = 0x%08lu\n", esr & ESR_ELx_ISS_MASK);
> > + pr_alert(" ISV = 0, ISS = %08lu\n", esr & ESR_ELx_ISS_MASK);
>
> A fix has already been queued [0,1], ensuring this is printed as hex.
>
> Catalin, I see that hasn't been pushed out to the arm64 fixes/core
> branch. Is that deliberate?
No. Only that my tests took about a day to complete. I'll push the
patches out today.
--
Catalin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-05 15:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-05 12:59 [PATCH] arm64: mm: Clarify a printk in data_abort_decode() Dan Carpenter
2017-10-05 13:04 ` Mark Rutland
2017-10-05 13:22 ` Dan Carpenter
2017-10-05 13:29 ` Mark Rutland
2017-10-05 15:05 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox