* [PATCH] pinctrl: sunxi: a83t: Fix IRQ offset typo for PH11
@ 2018-12-04 9:04 Chen-Yu Tsai
2018-12-04 9:12 ` Maxime Ripard
2018-12-07 12:32 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2018-12-04 9:04 UTC (permalink / raw)
To: Linus Walleij, Maxime Ripard
Cc: linux-sunxi, stable, linux-kernel, linux-gpio, Chen-Yu Tsai,
linux-arm-kernel
Pin PH11 is used on various A83T board to detect a change in the OTG
port's ID pin, as in when an OTG host cable is plugged in.
The incorrect offset meant the gpiochip/irqchip was activating the wrong
pin for interrupts.
Fixes: 4730f33f0d82 ("pinctrl: sunxi: add allwinner A83T PIO controller support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
drivers/pinctrl/sunxi/pinctrl-sun8i-a83t.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-a83t.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-a83t.c
index 6624499eae72..4ada80317a3b 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sun8i-a83t.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-a83t.c
@@ -568,7 +568,7 @@ static const struct sunxi_desc_pin sun8i_a83t_pins[] = {
SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 11),
SUNXI_FUNCTION(0x0, "gpio_in"),
SUNXI_FUNCTION(0x1, "gpio_out"),
- SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 1)), /* PH_EINT11 */
+ SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 11)), /* PH_EINT11 */
};
static const struct sunxi_pinctrl_desc sun8i_a83t_pinctrl_data = {
--
2.20.0.rc1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: sunxi: a83t: Fix IRQ offset typo for PH11
2018-12-04 9:04 [PATCH] pinctrl: sunxi: a83t: Fix IRQ offset typo for PH11 Chen-Yu Tsai
@ 2018-12-04 9:12 ` Maxime Ripard
2018-12-07 12:32 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2018-12-04 9:12 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Linus Walleij, linux-kernel, stable, linux-gpio, linux-sunxi,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 624 bytes --]
On Tue, Dec 04, 2018 at 05:04:57PM +0800, Chen-Yu Tsai wrote:
> Pin PH11 is used on various A83T board to detect a change in the OTG
> port's ID pin, as in when an OTG host cable is plugged in.
>
> The incorrect offset meant the gpiochip/irqchip was activating the wrong
> pin for interrupts.
>
> Fixes: 4730f33f0d82 ("pinctrl: sunxi: add allwinner A83T PIO controller support")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: sunxi: a83t: Fix IRQ offset typo for PH11
2018-12-04 9:04 [PATCH] pinctrl: sunxi: a83t: Fix IRQ offset typo for PH11 Chen-Yu Tsai
2018-12-04 9:12 ` Maxime Ripard
@ 2018-12-07 12:32 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-12-07 12:32 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Maxime Ripard, linux-kernel@vger.kernel.org, stable,
open list:GPIO SUBSYSTEM, linux-sunxi, Linux ARM
On Tue, Dec 4, 2018 at 10:05 AM Chen-Yu Tsai <wens@csie.org> wrote:
> Pin PH11 is used on various A83T board to detect a change in the OTG
> port's ID pin, as in when an OTG host cable is plugged in.
>
> The incorrect offset meant the gpiochip/irqchip was activating the wrong
> pin for interrupts.
>
> Fixes: 4730f33f0d82 ("pinctrl: sunxi: add allwinner A83T PIO controller support")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Patch applied for fixes with Maxime's ACK.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-07 12:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-04 9:04 [PATCH] pinctrl: sunxi: a83t: Fix IRQ offset typo for PH11 Chen-Yu Tsai
2018-12-04 9:12 ` Maxime Ripard
2018-12-07 12:32 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox