[PATCH] net: dwmac-sun8i: fix a missing check of of_get_phy_mode

* [PATCH] net: dwmac-sun8i: fix a missing check of of_get_phy_mode
@ 2019-03-12  7:50 Kangjie Lu
  2019-03-12  8:07 ` Maxime Ripard
  2019-03-12 21:54 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Kangjie Lu @ 2019-03-12  7:50 UTC (permalink / raw)
  To: kjlu
  Cc: Alexandre Torgue, Maxime Ripard, netdev, linux-kernel,
	linux-stm32, Chen-Yu Tsai, Jose Abreu, Maxime Coquelin, pakki001,
	Giuseppe Cavallaro, David S. Miller, linux-arm-kernel

of_get_phy_mode may fail and return a negative error code;
the fix checks the return value of of_get_phy_mode and
returns -EINVAL of it fails.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
index 0f660af01a4b..195669f550f0 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
@@ -1147,7 +1147,10 @@ static int sun8i_dwmac_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	plat_dat->interface = of_get_phy_mode(dev->of_node);
+	ret = of_get_phy_mode(dev->of_node);
+	if (ret < 0)
+		return -EINVAL;
+	plat_dat->interface = ret;
 
 	/* platform data specifying hardware features and callbacks.
 	 * hardware features were copied from Allwinner drivers.
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread