Re: [PATCH mvebu-dt64 1/1] arm64: dts: armada-3720-turris-mox: convert usb-phy to phy-supply

["Marek Behún" <marek.behun@nic.cz>]

Gregory,

I communicated with Miquel when I first discovered this regression, see
https://marc.info/?l=linux-usb&m=156966328310472&w=2

In this mail Miquel is mentioning a patch
(https://patchwork.kernel.org/patch/11067687/) which does the same for
Armada 7k/8k. He says his patch should enter next release, but since on
Mox this caused a regression, I would like it to be merged now.

Anyway if you want to still wait for Miquels review to be sure, I am ok
with that.

What do you think about the "arm64: dts: armada-3720-turris-mox: add
firmware node" which I sent last month?

Marek

On Tue, 08 Oct 2019 18:37:03 +0200
Gregory CLEMENT <gregory.clement@bootlin.com> wrote:

> Hi Marek,
> 
> > Update Turris Mox device tree to use the phy-supply property of the
> > generic PHY framework instead of the legacy usb-phy property.
> >
> > This is needed since it caused a regression on Turris Mox since
> > commit eb6c2eb6c7fb ("usb: host: xhci-plat: Prevent an
> > abnormally..."). 
> 
> I am not against this patch and if it the right fix for the
> regression I will applied it on my mvebu/fixes branch to be part of
> v5.4. However I'd like to have the feedback from Miquel on this one,
> as for me it is not obvious that it is te correct fix.
> 
> Gregory
> 
> > Signed-off-by: Marek Behún <marek.behun@nic.cz>
> > Fixes: eb6c2eb6c7fb ("usb: host: xhci-plat: Prevent an
> > abnormally...") Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> > Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> > Cc: Andrew Lunn <andrew@lunn.ch>
> > ---
> >  .../boot/dts/marvell/armada-3720-turris-mox.dts     | 13
> > +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> > b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts index
> > d105986c6be1..5f350cc71a2f 100644 ---
> > a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts +++
> > b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts @@ -60,11
> > +60,6 @@ gpio = <&gpiosb 0 GPIO_ACTIVE_HIGH>;
> >  	};
> >  
> > -	usb3_phy: usb3-phy {
> > -		compatible = "usb-nop-xceiv";
> > -		vcc-supply = <&exp_usb3_vbus>;
> > -	};
> > -
> >  	vsdc_reg: vsdc-reg {
> >  		compatible = "regulator-gpio";
> >  		regulator-name = "vsdc";
> > @@ -255,10 +250,16 @@
> >  	status = "okay";
> >  };
> >  
> > +&comphy2 {
> > +	connector {
> > +		compatible = "usb-a-connector";
> > +		phy-supply = <&exp_usb3_vbus>;
> > +	};
> > +};
> > +
> >  &usb3 {
> >  	status = "okay";
> >  	phys = <&comphy2 0>;
> > -	usb-phy = <&usb3_phy>;
> >  };
> >  
> >  &mdio {
> > -- 
> > 2.21.0
> >  
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel