From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Marek Behún" <marek.behun@nic.cz>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH mvebu-dt64 1/1] arm64: dts: armada-3720-turris-mox: convert usb-phy to phy-supply
Date: Tue, 08 Oct 2019 18:37:03 +0200 [thread overview]
Message-ID: <871rvntcr4.fsf@FE-laptop> (raw)
In-Reply-To: <20191008145944.21659-1-marek.behun@nic.cz>
Hi Marek,
> Update Turris Mox device tree to use the phy-supply property of the
> generic PHY framework instead of the legacy usb-phy property.
>
> This is needed since it caused a regression on Turris Mox since commit
> eb6c2eb6c7fb ("usb: host: xhci-plat: Prevent an abnormally...").
>
I am not against this patch and if it the right fix for the regression I
will applied it on my mvebu/fixes branch to be part of v5.4. However I'd
like to have the feedback from Miquel on this one, as for me it is not
obvious that it is te correct fix.
Gregory
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> Fixes: eb6c2eb6c7fb ("usb: host: xhci-plat: Prevent an abnormally...")
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> Cc: Andrew Lunn <andrew@lunn.ch>
> ---
> .../boot/dts/marvell/armada-3720-turris-mox.dts | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> index d105986c6be1..5f350cc71a2f 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> @@ -60,11 +60,6 @@
> gpio = <&gpiosb 0 GPIO_ACTIVE_HIGH>;
> };
>
> - usb3_phy: usb3-phy {
> - compatible = "usb-nop-xceiv";
> - vcc-supply = <&exp_usb3_vbus>;
> - };
> -
> vsdc_reg: vsdc-reg {
> compatible = "regulator-gpio";
> regulator-name = "vsdc";
> @@ -255,10 +250,16 @@
> status = "okay";
> };
>
> +&comphy2 {
> + connector {
> + compatible = "usb-a-connector";
> + phy-supply = <&exp_usb3_vbus>;
> + };
> +};
> +
> &usb3 {
> status = "okay";
> phys = <&comphy2 0>;
> - usb-phy = <&usb3_phy>;
> };
>
> &mdio {
> --
> 2.21.0
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2019-10-08 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191008145944.21659-1-marek.behun@nic.cz>
2019-10-08 16:37 ` Gregory CLEMENT [this message]
2019-10-08 16:49 ` [PATCH mvebu-dt64 1/1] arm64: dts: armada-3720-turris-mox: convert usb-phy to phy-supply Marek Behún
2019-10-08 16:54 ` Miquel Raynal
2019-10-08 16:58 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rvntcr4.fsf@FE-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marek.behun@nic.cz \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox