From: Will Deacon <will@kernel.org>
To: Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
Frank Li <frank.li@nxp.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] perf/imx_ddr: add enhanced AXI ID filter support
Date: Wed, 30 Oct 2019 15:36:40 +0000 [thread overview]
Message-ID: <20191030153640.GB19096@willie-the-truck> (raw)
In-Reply-To: <DB7PR04MB4618B90121FE884B8864E7AFE6610@DB7PR04MB4618.eurprd04.prod.outlook.com>
Hi Joakim,
Please can you try to configure your email client correctly, so that you
don't have to prefix your replies with '[Joakim]'? I use mutt, which works
pretty well, but you can look at Documentation/process/email-clients.rst
for hints about using other clients.
On Tue, Oct 29, 2019 at 07:02:28AM +0000, Joakim Zhang wrote:
> > From: Will Deacon <will@kernel.org>
> > On Fri, Sep 06, 2019 at 08:26:55AM +0000, Joakim Zhang wrote:
> > > diff --git a/drivers/perf/fsl_imx8_ddr_perf.c
> > > b/drivers/perf/fsl_imx8_ddr_perf.c
> > > index ce7345745b42..5f70dbfa9607 100644
> > > --- a/drivers/perf/fsl_imx8_ddr_perf.c
> > > +++ b/drivers/perf/fsl_imx8_ddr_perf.c
> > > @@ -45,7 +45,8 @@
> > > static DEFINE_IDA(ddr_ida);
> > >
> > > /* DDR Perf hardware feature */
> > > -#define DDR_CAP_AXI_ID_FILTER 0x1 /* support AXI ID
> > filter */
> > > +#define DDR_CAP_AXI_ID_FILTER BIT(1) /* support AXI ID
> > filter */
> >
> > Is this a deliberate change from the previous code and, if so, why?
>
> [Joakim] DDR PMU integrated in various SoCs may have different
> features(extend more features), use BIT(1)/BIT(2)/BIT(3)... instead of
> 0x1/0x2/0x4..., I think it is more easier. This deliberate change from
> previous code has no functional effect.
My point was that I don't think BIT(1) == 0x1.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-30 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 8:26 [PATCH 1/2] perf/imx_ddr: add enhanced AXI ID filter support Joakim Zhang
2019-09-06 8:26 ` [PATCH 2/2] doc/perf: add DDR_CAP_AXI_ID_FILTER_ENHANCED quirk explanation Joakim Zhang
2019-09-16 8:34 ` [PATCH 1/2] perf/imx_ddr: add enhanced AXI ID filter support Joakim Zhang
2019-10-28 14:54 ` Will Deacon
2019-10-29 7:02 ` Joakim Zhang
2019-10-30 15:36 ` Will Deacon [this message]
2019-10-31 1:42 ` Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030153640.GB19096@willie-the-truck \
--to=will@kernel.org \
--cc=frank.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=qiangqing.zhang@nxp.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox