public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* Re: [PATCH] dmaengine: imx-sdma: Fix: Remove 'always true' comparison
       [not found] <20200621155730.28766-1-festevam@gmail.com>
@ 2020-06-24  5:46 ` Vinod Koul
  0 siblings, 0 replies; only message in thread
From: Vinod Koul @ 2020-06-24  5:46 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: dmaengine, linux-imx, frieder.schrempf, linux-arm-kernel

On 21-06-20, 12:57, Fabio Estevam wrote:
> event_id0 is defined as 'unsigned int', so it is always greater or
> equal to zero.
> 
> Remove the unneeded comparisons to fix the following W=1 build
> warning:
> 
> drivers/dma/imx-sdma.c: In function 'sdma_free_chan_resources':
> drivers/dma/imx-sdma.c:1334:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
> 1334 |  if (sdmac->event_id0 >= 0)
> |                       ^~
> drivers/dma/imx-sdma.c: In function 'sdma_config':
> drivers/dma/imx-sdma.c:1635:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
> 1635 |  if (sdmac->event_id0 >= 0) {
> |               

Applied, thanks

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-24  5:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20200621155730.28766-1-festevam@gmail.com>
2020-06-24  5:46 ` [PATCH] dmaengine: imx-sdma: Fix: Remove 'always true' comparison Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox