public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Ian Rogers" <irogers@google.com>, "Al Grant" <Al.Grant@arm.com>,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	"Kemeng Shi" <shikemeng@huawei.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Wei Li" <liwei391@huawei.com>,
	"John Garry" <john.garry@huawei.com>,
	linux-kernel@vger.kernel.org,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"James Clark" <james.clark@arm.com>,
	"André Przywara" <andre.przywara@arm.com>,
	"Namhyung Kim" <namhyung@kernel.org>,
	"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
	"Will Deacon" <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/9] perf mem: Support new memory event PERF_MEM_EVENTS__LOAD_STORE
Date: Mon, 2 Nov 2020 17:38:48 +0800	[thread overview]
Message-ID: <20201102093848.GA6633@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20201031202307.GB3380099@krava>

On Sat, Oct 31, 2020 at 09:23:07PM +0100, Jiri Olsa wrote:
> On Wed, Oct 28, 2020 at 02:38:07PM +0800, Leo Yan wrote:
> 
> SNIP
> 
> >  		struct stat st;
> >  
> > +		/*
> > +		 * If the event entry isn't valid, skip initialization
> > +		 * and "e->supported" will keep false.
> > +		 */
> > +		if (!e->tag)
> > +			continue;
> > +
> >  		scnprintf(path, PATH_MAX, "%s/devices/%s",
> >  			  mnt, e->sysfs_name);
> >  
> > @@ -123,7 +134,7 @@ void perf_mem_events__list(void)
> >  		struct perf_mem_event *e = perf_mem_events__ptr(j);
> >  
> >  		fprintf(stderr, "%-13s%-*s%s\n",
> > -			e->tag,
> > +			e->tag ? e->tag : "",
> 
> nit, could be:          e->tag ?: "",

Will do.

Thanks,
Leo

> >  			verbose > 0 ? 25 : 0,
> >  			verbose > 0 ? perf_mem_events__name(j) : "",
> >  			e->supported ? ": available" : "");
> > diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
> > index 726a9c8103e4..5ef178278909 100644
> > --- a/tools/perf/util/mem-events.h
> > +++ b/tools/perf/util/mem-events.h
> > @@ -28,6 +28,7 @@ struct mem_info {
> >  enum {
> >  	PERF_MEM_EVENTS__LOAD,
> >  	PERF_MEM_EVENTS__STORE,
> > +	PERF_MEM_EVENTS__LOAD_STORE,
> >  	PERF_MEM_EVENTS__MAX,
> >  };
> >  
> > -- 
> > 2.17.1
> > 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-11-02  9:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28  6:38 [PATCH v3 0/9] perf mem/c2c: Support AUX trace Leo Yan
2020-10-28  6:38 ` [PATCH v3 1/9] perf mem: Search event name with more flexible path Leo Yan
2020-10-28  6:38 ` [PATCH v3 2/9] perf mem: Introduce weak function perf_mem_events__ptr() Leo Yan
2020-10-28  6:38 ` [PATCH v3 3/9] perf mem: Support new memory event PERF_MEM_EVENTS__LOAD_STORE Leo Yan
2020-10-31 20:23   ` Jiri Olsa
2020-11-02  9:38     ` Leo Yan [this message]
2020-10-28  6:38 ` [PATCH v3 4/9] perf mem: Only initialize memory event for recording Leo Yan
2020-10-30  1:04   ` Ian Rogers
2020-10-28  6:38 ` [PATCH v3 5/9] perf mem: Support AUX trace Leo Yan
2020-10-28  6:38 ` [PATCH v3 6/9] perf c2c: " Leo Yan
2020-10-31 20:21   ` Jiri Olsa
2020-11-02 10:08     ` Leo Yan
2020-11-02 16:35       ` Jiri Olsa
2020-10-28  6:38 ` [PATCH v3 7/9] perf mem: Support Arm SPE events Leo Yan
2020-10-28  6:38 ` [PATCH v3 8/9] perf mem: Return NULL for event 'ldst' on PowerPC Leo Yan
2020-10-28  9:35   ` Naveen N. Rao
2020-10-28  6:38 ` [PATCH v3 9/9] perf mem: Document event type 'ldst' Leo Yan
2020-10-30  1:10   ` Ian Rogers
2020-10-30  1:49     ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102093848.GA6633@leoy-ThinkPad-X240s \
    --to=leo.yan@linaro.org \
    --cc=Al.Grant@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andre.przywara@arm.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=john.garry@huawei.com \
    --cc=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liwei391@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=shikemeng@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox