* [PATCH] iio: adc: exynos: drop unneeded variable assignment
@ 2021-04-10 16:47 Krzysztof Kozlowski
2021-04-11 12:55 ` Alim Akhtar
2021-04-11 14:00 ` Jonathan Cameron
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-04-10 16:47 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen, Krzysztof Kozlowski,
linux-iio, linux-arm-kernel, linux-samsung-soc, linux-kernel
The initialization of 'ret' variable in probe function is shortly after
overwritten. This initialization is simply not used.
Addresses-Coverity: Unused value
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/iio/adc/exynos_adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index 784c10deeb1a..2d8e36408f0e 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -794,7 +794,7 @@ static int exynos_adc_probe(struct platform_device *pdev)
struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
struct iio_dev *indio_dev = NULL;
bool has_ts = false;
- int ret = -ENODEV;
+ int ret;
int irq;
indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(struct exynos_adc));
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: exynos: drop unneeded variable assignment
2021-04-10 16:47 [PATCH] iio: adc: exynos: drop unneeded variable assignment Krzysztof Kozlowski
@ 2021-04-11 12:55 ` Alim Akhtar
2021-04-11 14:00 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Alim Akhtar @ 2021-04-11 12:55 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Jonathan Cameron, Lars-Peter Clausen, linux-iio, linux-arm-kernel,
linux-samsung-soc, open list
On Sat, Apr 10, 2021 at 10:18 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The initialization of 'ret' variable in probe function is shortly after
> overwritten. This initialization is simply not used.
>
> Addresses-Coverity: Unused value
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
Thanks Krzysztof,
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/iio/adc/exynos_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> index 784c10deeb1a..2d8e36408f0e 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -794,7 +794,7 @@ static int exynos_adc_probe(struct platform_device *pdev)
> struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
> struct iio_dev *indio_dev = NULL;
> bool has_ts = false;
> - int ret = -ENODEV;
> + int ret;
> int irq;
>
> indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(struct exynos_adc));
> --
> 2.25.1
>
--
Regards,
Alim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: exynos: drop unneeded variable assignment
2021-04-10 16:47 [PATCH] iio: adc: exynos: drop unneeded variable assignment Krzysztof Kozlowski
2021-04-11 12:55 ` Alim Akhtar
@ 2021-04-11 14:00 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2021-04-11 14:00 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lars-Peter Clausen, linux-iio, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On Sat, 10 Apr 2021 18:47:28 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote:
> The initialization of 'ret' variable in probe function is shortly after
> overwritten. This initialization is simply not used.
>
> Addresses-Coverity: Unused value
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Too late for this cycle, but I've queued it up for the next one.
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see if we missed anything.
Thanks,
Jonathan
> ---
> drivers/iio/adc/exynos_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> index 784c10deeb1a..2d8e36408f0e 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -794,7 +794,7 @@ static int exynos_adc_probe(struct platform_device *pdev)
> struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
> struct iio_dev *indio_dev = NULL;
> bool has_ts = false;
> - int ret = -ENODEV;
> + int ret;
> int irq;
>
> indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(struct exynos_adc));
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-11 14:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-10 16:47 [PATCH] iio: adc: exynos: drop unneeded variable assignment Krzysztof Kozlowski
2021-04-11 12:55 ` Alim Akhtar
2021-04-11 14:00 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox