public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, boqun.feng@gmail.com,
	catalin.marinas@arm.com, peterz@infradead.org
Subject: Re: [PATCH 1/5] arm64: atomics: format whitespace consistently
Date: Mon, 13 Dec 2021 19:20:17 +0000	[thread overview]
Message-ID: <20211213192017.GA12868@willie-the-truck> (raw)
In-Reply-To: <20211210151410.2782645-2-mark.rutland@arm.com>

On Fri, Dec 10, 2021 at 03:14:06PM +0000, Mark Rutland wrote:
> The code for the atomic ops is formatted inconsistently, and while this
> is not a functional problem it is rather distracting when working on
> them.
> 
> Some have ops have consistent indentation, e.g.
> 
> | #define ATOMIC_OP_ADD_RETURN(name, mb, cl...)                           \
> | static inline int __lse_atomic_add_return##name(int i, atomic_t *v)     \
> | {                                                                       \
> |         u32 tmp;                                                        \
> |                                                                         \
> |         asm volatile(                                                   \
> |         __LSE_PREAMBLE                                                  \
> |         "       ldadd" #mb "    %w[i], %w[tmp], %[v]\n"                 \
> |         "       add     %w[i], %w[i], %w[tmp]"                          \
> |         : [i] "+r" (i), [v] "+Q" (v->counter), [tmp] "=&r" (tmp)        \
> |         : "r" (v)                                                       \
> |         : cl);                                                          \
> |                                                                         \
> |         return i;                                                       \
> | }
> 
> While others have negative indentation for some lines, and/or have
> misaligned trailing backslashes, e.g.
> 
> | static inline void __lse_atomic_##op(int i, atomic_t *v)                        \
> | {                                                                       \
> |         asm volatile(                                                   \
> |         __LSE_PREAMBLE                                                  \
> | "       " #asm_op "     %w[i], %[v]\n"                                  \
> |         : [i] "+r" (i), [v] "+Q" (v->counter)                           \
> |         : "r" (v));                                                     \
> | }
> 
> This patch makes the indentation consistent and also aligns the trailing
> backslashes. This makes the code easier to read for those (like myself)
> who are easily distracted by these inconsistencies.
> 
> This is intended as a cleanup.
> There should be no functional change as a result of this patch.

Looks the same to me:

Acked-by: Will Deacon <will@kernel.org>

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-13 19:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 15:14 [PATCH 0/5] arm64: atomics: cleanups and codegen improvements Mark Rutland
2021-12-10 15:14 ` [PATCH 1/5] arm64: atomics: format whitespace consistently Mark Rutland
2021-12-13 19:20   ` Will Deacon [this message]
2021-12-10 15:14 ` [PATCH 2/5] arm64: atomics lse: define SUBs in terms of ADDs Mark Rutland
2021-12-13 19:27   ` Will Deacon
2021-12-10 15:14 ` [PATCH 3/5] arm64: atomics: lse: define ANDs in terms of ANDNOTs Mark Rutland
2021-12-13 19:29   ` Will Deacon
2021-12-10 15:14 ` [PATCH 4/5] arm64: atomics: lse: improve constraints for simple ops Mark Rutland
2021-12-13 19:40   ` Will Deacon
2021-12-14 13:04     ` Mark Rutland
2021-12-10 15:14 ` [PATCH 5/5] arm64: atomics: lse: define RETURN ops in terms of FETCH ops Mark Rutland
2021-12-10 22:19   ` Peter Zijlstra
2021-12-13 16:49     ` Mark Rutland
2021-12-13 19:43   ` Will Deacon
2021-12-10 22:26 ` [PATCH 0/5] arm64: atomics: cleanups and codegen improvements Peter Zijlstra
2021-12-14 16:54 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211213192017.GA12868@willie-the-truck \
    --to=will@kernel.org \
    --cc=boqun.feng@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox