Re: [PATCH v2] hwmon: (sun4i-lradc) Add driver for LRADC found on Allwinner A13/A20 SoC

From: Maxime Ripard <maxime@cerno.tech>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Ruslan Zalata <rz@fabmicro.ru>, Jean Delvare <jdelvare@suse.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2] hwmon: (sun4i-lradc) Add driver for LRADC found on Allwinner A13/A20 SoC
Date: Mon, 2 May 2022 15:39:27 +0200	[thread overview]
Message-ID: <20220502133927.4wqhru4es32gws2b@houat> (raw)
In-Reply-To: <21a89ae0-7152-49eb-7500-7d46dfb259f6@roeck-us.net>

[-- Attachment #1.1: Type: text/plain, Size: 2789 bytes --]

On Mon, May 02, 2022 at 06:31:56AM -0700, Guenter Roeck wrote:
> On 5/2/22 04:00, Maxime Ripard wrote:
> > Hi,
> > 
> > On Thu, Apr 28, 2022 at 09:09:03PM +0000, Ruslan Zalata wrote:
> > > Some Allwinner SoCs like A13, A20 or T2 are equipped with two-channel
> > > low rate (6 bit) ADC that is often used for extra keys. There's a driver
> > > for that already implementing standard input device, but it has these
> > > limitations: 1) it cannot be used for general ADC data equisition, and
> > > 2) it uses only one LRADC channel of two available.
> > > 
> > > This driver provides basic hwmon interface to both channels of LRADC on
> > > such Allwinner SoCs.
> > > 
> > > Signed-off-by: Ruslan Zalata <rz@fabmicro.ru>
> > > ---
> > >   MAINTAINERS                       |   6 +
> > >   drivers/hwmon/Kconfig             |  13 ++
> > >   drivers/hwmon/Makefile            |   1 +
> > >   drivers/hwmon/sun4i-lradc-hwmon.c | 280 ++++++++++++++++++++++++++++++
> > >   4 files changed, 300 insertions(+)
> > >   create mode 100644 drivers/hwmon/sun4i-lradc-hwmon.c
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 5e8c2f61176..d9c71e94133 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -18861,6 +18861,12 @@ S:	Maintained
> > >   F:	Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
> > >   F:	drivers/input/keyboard/sun4i-lradc-keys.c
> > > +SUN4I LOW RES ADC HWMON DRIVER
> > > +M:	Ruslan Zalata <rz@fabmicro.ru>
> > > +L:	linux-hwmon@vger.kernel.org
> > > +S:	Maintained
> > > +F:	drivers/hwmon/sun4i-lradc-hwmon.c
> > > +
> > >   SUNDANCE NETWORK DRIVER
> > >   M:	Denis Kirjanov <kda@linux-powerpc.org>
> > >   L:	netdev@vger.kernel.org
> > > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> > > index 68a8a27ab3b..86776488a81 100644
> > > --- a/drivers/hwmon/Kconfig
> > > +++ b/drivers/hwmon/Kconfig
> > > @@ -1691,6 +1691,19 @@ config SENSORS_SIS5595
> > >   	  This driver can also be built as a module. If so, the module
> > >   	  will be called sis5595.
> > > +config SENSORS_SUN4I_LRADC
> > > +	tristate "Allwinner A13/A20 LRADC hwmon"
> > > +	depends on ARCH_SUNXI && !KEYBOARD_SUN4I_LRADC
> > > +	help
> > > +	  Say y here to support the LRADC found in Allwinner A13/A20 SoCs.
> > > +	  Both channels are supported.
> > > +
> > > +	  This driver can also be built as module. If so, the module
> > > +	  will be called sun4i-lradc-hwmon.
> > > +
> > > +	  This option is not compatible with KEYBOARD_SUN4I_LRADC, one
> > > +	  of these must be used at a time.
> > 
> > How do you plan on enforcing that?
> > 
> 	depends on ARCH_SUNXI && !KEYBOARD_SUN4I_LRADC

Right, but that just doesn't fly for any generic distro / build-system.

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel