From: Maxime Ripard <maxime@cerno.tech>
To: Ruslan Zalata <rz@fabmicro.ru>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2] hwmon: (sun4i-lradc) Add driver for LRADC found on Allwinner A13/A20 SoC
Date: Tue, 3 May 2022 18:07:13 +0200 [thread overview]
Message-ID: <20220503160713.7kdikhd5kkgkotcp@houat> (raw)
In-Reply-To: <6009fbef45a8b77caa4fc137093a1e23@fabmicro.ru>
[-- Attachment #1.1: Type: text/plain, Size: 867 bytes --]
Hi,
On Tue, May 03, 2022 at 01:50:39PM +0500, Ruslan Zalata wrote:
> > I guess a better path forward would be to either register an hwmon
> > device in the original driver, or convert that driver to iio and use
> > iio-hwmon.
>
> My first idea was to add hwmon to sun4i-lradc-keys.c driver. But soon as I
> began hacking the driver I quickly realized that it would be a mess since
> keyboard and hwmon belong to two different subsystems.
That's not really an issue in itself. There's plenty of drivers in Linux
that register into two frameworks.
> Besides we would need to invent a way to control which way the driver
> works (new bindings?).
I got confused there, and thought you were adding temperature reading
that is in another ADC on those SoCs, sorry. Yeah, that doesn't make
much sense to have both in the same drivers here.
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-05-03 16:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220428210906.29527-1-rz@fabmicro.ru>
2022-04-28 21:30 ` [PATCH v2] hwmon: (sun4i-lradc) Add driver for LRADC found on Allwinner A13/A20 SoC Guenter Roeck
2022-04-29 0:28 ` Ruslan Zalata
2022-04-29 5:32 ` Guenter Roeck
2022-04-29 6:03 ` Guenter Roeck
2022-05-02 23:47 ` Ruslan Zalata
2022-04-29 13:24 ` Jonathan Cameron
2022-05-02 23:20 ` Ruslan Zalata
2022-05-02 11:00 ` Maxime Ripard
2022-05-02 11:15 ` Icenowy Zheng
2022-05-02 11:21 ` Maxime Ripard
2022-05-03 2:02 ` Guenter Roeck
2022-05-03 15:26 ` Ruslan Zalata
2022-05-03 16:14 ` Maxime Ripard
2022-05-03 21:37 ` Ruslan Zalata
2022-05-04 14:12 ` Maxime Ripard
2022-05-02 13:31 ` Guenter Roeck
2022-05-02 13:39 ` Maxime Ripard
2022-05-02 16:21 ` Guenter Roeck
2022-05-03 8:50 ` Ruslan Zalata
2022-05-03 16:07 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503160713.7kdikhd5kkgkotcp@houat \
--to=maxime@cerno.tech \
--cc=jdelvare@suse.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux@roeck-us.net \
--cc=rz@fabmicro.ru \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox