From: Will Deacon <will@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Melody Olvera <quic_molvera@quicinc.com>,
Joerg Roedel <joro@8bytes.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] drivers: arm-smmu-impl: Add QDU1000 and QRU1000 iommu implementation
Date: Mon, 14 Nov 2022 14:42:21 +0000 [thread overview]
Message-ID: <20221114144220.GA31043@willie-the-truck> (raw)
In-Reply-To: <0ae09be0-cb1b-dc27-943b-db64ca97b8c7@linaro.org>
On Mon, Nov 14, 2022 at 03:28:15PM +0100, Krzysztof Kozlowski wrote:
> On 26/10/2022 21:05, Melody Olvera wrote:
> > Add compatible for Qualcomm QDU1000 and QRU1000 SoCs to add iommu
> > support for them.
> >
> > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> > ---
> > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> > index b2708de25ea3..0580a381a04b 100644
> > --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> > @@ -426,6 +426,7 @@ static struct arm_smmu_device *qcom_smmu_create(struct arm_smmu_device *smmu,
> > static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = {
> > { .compatible = "qcom,msm8998-smmu-v2" },
> > { .compatible = "qcom,qcm2290-smmu-500" },
> > + { .compatible = "qcom,qdu1000-smmu-500" },
>
> The patch was applied but it contradicts work here:
> https://lore.kernel.org/all/20221102184420.534094-12-dmitry.baryshkov@linaro.org/
> which explicitly asks not to add such compatibles...
Sure, but we've been adding new compatibles for years so I don't mind
picking up the last few now before we stop accepting new ones.
I already asked Dmitry to respin his series as there are some open comments
from others anyway.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-14 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 19:05 [PATCH v3 0/2] Add smmu support for QDU1000/QRU1000 SoCs Melody Olvera
2022-10-26 19:05 ` [PATCH v3 1/2] dt-bindings: arm-smmu: Add compatible bindings for QDU1000 and QRU1000 Melody Olvera
2022-10-27 15:26 ` Krzysztof Kozlowski
2022-10-26 19:05 ` [PATCH v3 2/2] drivers: arm-smmu-impl: Add QDU1000 and QRU1000 iommu implementation Melody Olvera
2022-11-14 14:28 ` Krzysztof Kozlowski
2022-11-14 14:42 ` Will Deacon [this message]
2022-11-14 15:53 ` Krzysztof Kozlowski
2022-11-14 14:20 ` [PATCH v3 0/2] Add smmu support for QDU1000/QRU1000 SoCs Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114144220.GA31043@willie-the-truck \
--to=will@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_molvera@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox