* [PATCH v3 1/2] dt-bindings: arm-smmu: Add compatible bindings for QDU1000 and QRU1000
2022-10-26 19:05 [PATCH v3 0/2] Add smmu support for QDU1000/QRU1000 SoCs Melody Olvera
@ 2022-10-26 19:05 ` Melody Olvera
2022-10-27 15:26 ` Krzysztof Kozlowski
2022-10-26 19:05 ` [PATCH v3 2/2] drivers: arm-smmu-impl: Add QDU1000 and QRU1000 iommu implementation Melody Olvera
2022-11-14 14:20 ` [PATCH v3 0/2] Add smmu support for QDU1000/QRU1000 SoCs Will Deacon
2 siblings, 1 reply; 8+ messages in thread
From: Melody Olvera @ 2022-10-26 19:05 UTC (permalink / raw)
To: Will Deacon, Joerg Roedel, Rob Herring, Krzysztof Kozlowski
Cc: Robin Murphy, linux-arm-kernel, iommu, devicetree, linux-kernel,
Melody Olvera
Add compatible bindings for Qualcomm QDU1000 and QRU1000 platforms.
Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
index 9066e6df1ba1..6258302ed9e7 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
@@ -34,6 +34,7 @@ properties:
items:
- enum:
- qcom,qcm2290-smmu-500
+ - qcom,qdu1000-smmu-500
- qcom,sc7180-smmu-500
- qcom,sc7280-smmu-500
- qcom,sc8180x-smmu-500
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v3 1/2] dt-bindings: arm-smmu: Add compatible bindings for QDU1000 and QRU1000
2022-10-26 19:05 ` [PATCH v3 1/2] dt-bindings: arm-smmu: Add compatible bindings for QDU1000 and QRU1000 Melody Olvera
@ 2022-10-27 15:26 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-27 15:26 UTC (permalink / raw)
To: Melody Olvera, Will Deacon, Joerg Roedel, Rob Herring,
Krzysztof Kozlowski
Cc: Robin Murphy, linux-arm-kernel, iommu, devicetree, linux-kernel
On 26/10/2022 15:05, Melody Olvera wrote:
> Add compatible bindings for Qualcomm QDU1000 and QRU1000 platforms.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
Drop second, redundant "bindings" from subject.
This applies to all your patches and all your patchsets which are for
the bindings subsystem.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 2/2] drivers: arm-smmu-impl: Add QDU1000 and QRU1000 iommu implementation
2022-10-26 19:05 [PATCH v3 0/2] Add smmu support for QDU1000/QRU1000 SoCs Melody Olvera
2022-10-26 19:05 ` [PATCH v3 1/2] dt-bindings: arm-smmu: Add compatible bindings for QDU1000 and QRU1000 Melody Olvera
@ 2022-10-26 19:05 ` Melody Olvera
2022-11-14 14:28 ` Krzysztof Kozlowski
2022-11-14 14:20 ` [PATCH v3 0/2] Add smmu support for QDU1000/QRU1000 SoCs Will Deacon
2 siblings, 1 reply; 8+ messages in thread
From: Melody Olvera @ 2022-10-26 19:05 UTC (permalink / raw)
To: Will Deacon, Joerg Roedel, Rob Herring, Krzysztof Kozlowski
Cc: Robin Murphy, linux-arm-kernel, iommu, devicetree, linux-kernel,
Melody Olvera
Add compatible for Qualcomm QDU1000 and QRU1000 SoCs to add iommu
support for them.
Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
index b2708de25ea3..0580a381a04b 100644
--- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
+++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
@@ -426,6 +426,7 @@ static struct arm_smmu_device *qcom_smmu_create(struct arm_smmu_device *smmu,
static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = {
{ .compatible = "qcom,msm8998-smmu-v2" },
{ .compatible = "qcom,qcm2290-smmu-500" },
+ { .compatible = "qcom,qdu1000-smmu-500" },
{ .compatible = "qcom,sc7180-smmu-500" },
{ .compatible = "qcom,sc7280-smmu-500" },
{ .compatible = "qcom,sc8180x-smmu-500" },
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v3 2/2] drivers: arm-smmu-impl: Add QDU1000 and QRU1000 iommu implementation
2022-10-26 19:05 ` [PATCH v3 2/2] drivers: arm-smmu-impl: Add QDU1000 and QRU1000 iommu implementation Melody Olvera
@ 2022-11-14 14:28 ` Krzysztof Kozlowski
2022-11-14 14:42 ` Will Deacon
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-14 14:28 UTC (permalink / raw)
To: Melody Olvera, Will Deacon, Joerg Roedel, Rob Herring,
Krzysztof Kozlowski
Cc: Robin Murphy, linux-arm-kernel, iommu, devicetree, linux-kernel
On 26/10/2022 21:05, Melody Olvera wrote:
> Add compatible for Qualcomm QDU1000 and QRU1000 SoCs to add iommu
> support for them.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> index b2708de25ea3..0580a381a04b 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> @@ -426,6 +426,7 @@ static struct arm_smmu_device *qcom_smmu_create(struct arm_smmu_device *smmu,
> static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = {
> { .compatible = "qcom,msm8998-smmu-v2" },
> { .compatible = "qcom,qcm2290-smmu-500" },
> + { .compatible = "qcom,qdu1000-smmu-500" },
The patch was applied but it contradicts work here:
https://lore.kernel.org/all/20221102184420.534094-12-dmitry.baryshkov@linaro.org/
which explicitly asks not to add such compatibles...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3 2/2] drivers: arm-smmu-impl: Add QDU1000 and QRU1000 iommu implementation
2022-11-14 14:28 ` Krzysztof Kozlowski
@ 2022-11-14 14:42 ` Will Deacon
2022-11-14 15:53 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: Will Deacon @ 2022-11-14 14:42 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Melody Olvera, Joerg Roedel, Rob Herring, Krzysztof Kozlowski,
Robin Murphy, linux-arm-kernel, iommu, devicetree, linux-kernel
On Mon, Nov 14, 2022 at 03:28:15PM +0100, Krzysztof Kozlowski wrote:
> On 26/10/2022 21:05, Melody Olvera wrote:
> > Add compatible for Qualcomm QDU1000 and QRU1000 SoCs to add iommu
> > support for them.
> >
> > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> > ---
> > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> > index b2708de25ea3..0580a381a04b 100644
> > --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> > @@ -426,6 +426,7 @@ static struct arm_smmu_device *qcom_smmu_create(struct arm_smmu_device *smmu,
> > static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = {
> > { .compatible = "qcom,msm8998-smmu-v2" },
> > { .compatible = "qcom,qcm2290-smmu-500" },
> > + { .compatible = "qcom,qdu1000-smmu-500" },
>
> The patch was applied but it contradicts work here:
> https://lore.kernel.org/all/20221102184420.534094-12-dmitry.baryshkov@linaro.org/
> which explicitly asks not to add such compatibles...
Sure, but we've been adding new compatibles for years so I don't mind
picking up the last few now before we stop accepting new ones.
I already asked Dmitry to respin his series as there are some open comments
from others anyway.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3 2/2] drivers: arm-smmu-impl: Add QDU1000 and QRU1000 iommu implementation
2022-11-14 14:42 ` Will Deacon
@ 2022-11-14 15:53 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-14 15:53 UTC (permalink / raw)
To: Will Deacon
Cc: Melody Olvera, Joerg Roedel, Rob Herring, Krzysztof Kozlowski,
Robin Murphy, linux-arm-kernel, iommu, devicetree, linux-kernel
On 14/11/2022 15:42, Will Deacon wrote:
> On Mon, Nov 14, 2022 at 03:28:15PM +0100, Krzysztof Kozlowski wrote:
>> On 26/10/2022 21:05, Melody Olvera wrote:
>>> Add compatible for Qualcomm QDU1000 and QRU1000 SoCs to add iommu
>>> support for them.
>>>
>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>> ---
>>> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>> index b2708de25ea3..0580a381a04b 100644
>>> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>> @@ -426,6 +426,7 @@ static struct arm_smmu_device *qcom_smmu_create(struct arm_smmu_device *smmu,
>>> static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = {
>>> { .compatible = "qcom,msm8998-smmu-v2" },
>>> { .compatible = "qcom,qcm2290-smmu-500" },
>>> + { .compatible = "qcom,qdu1000-smmu-500" },
>>
>> The patch was applied but it contradicts work here:
>> https://lore.kernel.org/all/20221102184420.534094-12-dmitry.baryshkov@linaro.org/
>> which explicitly asks not to add such compatibles...
>
> Sure, but we've been adding new compatibles for years so I don't mind
> picking up the last few now before we stop accepting new ones.
>
> I already asked Dmitry to respin his series as there are some open comments
> from others anyway.
OK. This also solves my other comment for other patch.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 0/2] Add smmu support for QDU1000/QRU1000 SoCs
2022-10-26 19:05 [PATCH v3 0/2] Add smmu support for QDU1000/QRU1000 SoCs Melody Olvera
2022-10-26 19:05 ` [PATCH v3 1/2] dt-bindings: arm-smmu: Add compatible bindings for QDU1000 and QRU1000 Melody Olvera
2022-10-26 19:05 ` [PATCH v3 2/2] drivers: arm-smmu-impl: Add QDU1000 and QRU1000 iommu implementation Melody Olvera
@ 2022-11-14 14:20 ` Will Deacon
2 siblings, 0 replies; 8+ messages in thread
From: Will Deacon @ 2022-11-14 14:20 UTC (permalink / raw)
To: Rob Herring, Melody Olvera, Krzysztof Kozlowski, Joerg Roedel
Cc: catalin.marinas, kernel-team, Will Deacon, linux-kernel, iommu,
devicetree, linux-arm-kernel, Robin Murphy
On Wed, 26 Oct 2022 12:05:32 -0700, Melody Olvera wrote:
> This patchset adds smmu bindings and driver support for the QDU1000
> and QRU1000 SoCs.
>
> The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit
> 1000 are new SoCs meant for enabling Open RAN solutions. See more at
> https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf
>
> [...]
Applied to arm64 (for-joerg/arm-smmu/bindings), thanks!
[1/2] dt-bindings: arm-smmu: Add compatible bindings for QDU1000 and QRU1000
https://git.kernel.org/arm64/c/6313f4b5a438
[2/2] drivers: arm-smmu-impl: Add QDU1000 and QRU1000 iommu implementation
https://git.kernel.org/arm64/c/7b52f53ce191
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread