From: Will Deacon <will@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: James Morse <james.morse@arm.com>,
linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH 29/38] arm64/sysreg: Convert ID_PFR0_EL1 to automatic generation
Date: Mon, 14 Nov 2022 15:02:37 +0000 [thread overview]
Message-ID: <20221114150236.GA31141@willie-the-truck> (raw)
In-Reply-To: <Y1wOvIoNUyP4GFjE@sirena.org.uk>
On Fri, Oct 28, 2022 at 06:17:48PM +0100, Mark Brown wrote:
> On Fri, Oct 28, 2022 at 05:54:17PM +0100, James Morse wrote:
>
> > Convert ID_PFR0_EL1 to be automatically generated as per DDI0487I.a,
> > no functional changes.
>
> > +Enum 19:16 CSV2
> > + 0b0000 IMP
> > + 0b0001 IMP
> > + 0b0010 CSV2p1
> > +EndEnum
>
> Should 0b0000 not be something like UNDISCLOSED (DDI0487I.a says "The
> implementation does not disclose whether FEAT_CSV2 is implemented.")?
>
> (I'm vaugely surprised the compiler didn't moan about the redefinition
> of the constant.)
I'm not fussed about the name, but the duplicate field definitely needs
fixing otherwise defconfig is really noisy:
./arch/arm64/include/generated/asm/sysreg-defs.h:42:9: warning: 'ID_PFR0_EL1_CSV2_IMP' macro redefined [-Wmacro-redefined]
#define ID_PFR0_EL1_CSV2_IMP UL(0b0001)
^
./arch/arm64/include/generated/asm/sysreg-defs.h:41:9: note: previous definition is here
#define ID_PFR0_EL1_CSV2_IMP UL(0b0000)
^
James -- please can you spin a v2 with this fixed?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-14 15:03 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 16:53 [PATCH 00/38] arm64/sysreg: Convert aarch32 id regs James Morse
2022-10-28 16:53 ` [PATCH 01/38] arm64/sysreg: Standardise naming for ID_MMFR0_EL1 James Morse
2022-10-28 16:53 ` [PATCH 02/38] arm64/sysreg: Standardise naming for ID_MMFR4_EL1 James Morse
2022-10-28 16:53 ` [PATCH 03/38] arm64/sysreg: Standardise naming for ID_MMFR5_EL1 James Morse
2022-10-28 16:53 ` [PATCH 04/38] arm64/sysreg: Standardise naming for ID_ISAR0_EL1 James Morse
2022-10-28 16:53 ` [PATCH 05/38] arm64/sysreg: Standardise naming for ID_ISAR4_EL1 James Morse
2022-10-28 16:53 ` [PATCH 06/38] arm64/sysreg: Standardise naming for ID_ISAR5_EL1 James Morse
2022-10-28 16:53 ` [PATCH 07/38] arm64/sysreg: Standardise naming for ID_ISAR6_EL1 James Morse
2022-10-28 16:53 ` [PATCH 08/38] arm64/sysreg: Standardise naming for ID_PFR0_EL1 James Morse
2022-10-28 16:53 ` [PATCH 09/38] arm64/sysreg: Standardise naming for ID_PFR1_EL1 James Morse
2022-10-28 16:53 ` [PATCH 10/38] arm64/sysreg: Standardise naming for ID_PFR2_EL1 James Morse
2022-10-28 16:53 ` [PATCH 11/38] arm64/sysreg: Standardise naming for ID_DFR0_EL1 James Morse
2022-10-28 16:54 ` [PATCH 12/38] arm64/sysreg: Standardise naming for ID_DFR1_EL1 James Morse
2022-10-28 16:54 ` [PATCH 13/38] arm64/sysreg: Standardise naming for MVFR0_EL1 James Morse
2022-10-28 16:54 ` [PATCH 14/38] arm64/sysreg: Standardise naming for MVFR1_EL1 James Morse
2022-10-28 16:54 ` [PATCH 15/38] arm64/sysreg: Standardise naming for MVFR2_EL1 James Morse
2022-10-28 16:54 ` [PATCH 16/38] arm64/sysreg: Extend the maximum width of a register and symbol name James Morse
2022-10-28 16:54 ` [PATCH 17/38] arm64/sysreg: Convert ID_MMFR0_EL1 to automatic generation James Morse
2022-10-28 16:54 ` [PATCH 18/38] arm64/sysreg: Convert ID_MMFR1_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 19/38] arm64/sysreg: Convert ID_MMFR2_EL1 " James Morse
2022-10-28 17:12 ` Mark Brown
2022-10-28 16:54 ` [PATCH 20/38] arm64/sysreg: Convert ID_MMFR3_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 21/38] arm64/sysreg: Convert ID_MMFR4_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 22/38] arm64/sysreg: Convert ID_ISAR0_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 23/38] arm64/sysreg: Convert ID_ISAR1_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 24/38] arm64/sysreg: Convert ID_ISAR2_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 25/38] arm64/sysreg: Convert ID_ISAR3_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 26/38] arm64/sysreg: Convert ID_ISAR4_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 27/38] arm64/sysreg: Convert ID_ISAR5_EL1 " James Morse
2022-10-28 17:14 ` Mark Brown
2022-10-28 16:54 ` [PATCH 28/38] arm64/sysreg: Convert ID_ISAR6_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 29/38] arm64/sysreg: Convert ID_PFR0_EL1 " James Morse
2022-10-28 17:17 ` Mark Brown
2022-11-14 15:02 ` Will Deacon [this message]
2022-11-30 17:16 ` James Morse
2022-10-28 16:54 ` [PATCH 30/38] arm64/sysreg: Convert ID_PFR1_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 31/38] arm64/sysreg: Convert ID_PFR2_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 32/38] arm64/sysreg: Convert MVFR0_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 33/38] arm64/sysreg: Convert MVFR1_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 34/38] arm64/sysreg: Convert MVFR2_EL1 " James Morse
2022-10-28 17:19 ` Mark Brown
2022-10-28 16:54 ` [PATCH 35/38] arm64/sysreg: Convert ID_MMFR5_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 36/38] arm64/sysreg: Convert ID_AFR0_EL1 " James Morse
2022-10-28 16:54 ` [PATCH 37/38] arm64/sysreg: Convert ID_DFR0_EL1 " James Morse
2022-10-28 17:22 ` Mark Brown
2022-11-30 17:17 ` James Morse
2022-10-28 16:54 ` [PATCH 38/38] arm64/sysreg: Convert ID_DFR1_EL1 " James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114150236.GA31141@willie-the-truck \
--to=will@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox