From: Sudeep Holla <sudeep.holla@arm.com>
To: Kazuki <kazukih0205@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>
Subject: Re: s2idle breaks on machines without cpuidle support
Date: Wed, 8 Feb 2023 15:03:06 +0000 [thread overview]
Message-ID: <20230208150306.ve2pnt3pvlmf5wbu@bogus> (raw)
In-Reply-To: <20230208144327.3ftjxnquwhsdykfc@kazuki-mac>
On Wed, Feb 08, 2023 at 11:43:27PM +0900, Kazuki wrote:
> On Wed, Feb 08, 2023 at 02:16:58PM +0000, Sudeep Holla wrote:
[...]
> > I was about ask you earlier as why can't you implement just system
> > suspend in PSCI where the last cpu just calls WFI if you are interested
> > in system sleep state. Or you can implement CPU_SUSPEND with an additional
> > retention state which enters PSCI implementation just to make sure there is
> > an active cpuidle driver and the s2idle state machinery works as expected.
>
> The machine I have (Macbook with Apple M1) doesn't have PSCI.
Well, if we are allowing to boot on such a system, then we must allow
adding a platform specific idle driver. It may be useful once we info
to add deeper than WFI states.
> I guess we should ensure that systems without a cpuidle driver
> will not suspend maybe around here then.
>
Are we ? I thought were making changes to enable it. Or are you saying
we allow to enter into such a state and render the system unusable, if
so we need to fix it.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-08 15:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 15:27 s2idle breaks on machines without cpuidle support Kazuki
2023-02-06 10:12 ` Sudeep Holla
2023-02-07 19:48 ` Kazuki
2023-02-08 10:35 ` Sudeep Holla
2023-02-08 11:20 ` Kazuki
2023-02-08 14:16 ` Sudeep Holla
2023-02-08 14:43 ` Kazuki
2023-02-08 15:03 ` Sudeep Holla [this message]
2023-02-08 15:19 ` Kazuki
2023-02-08 15:34 ` Sudeep Holla
2023-02-08 15:42 ` Kazuki
2023-02-08 14:52 ` Kazuki
2023-02-08 15:42 ` Hector Martin
2023-02-08 16:18 ` Sudeep Holla
2023-02-08 16:45 ` Hector Martin
2023-09-07 19:11 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208150306.ve2pnt3pvlmf5wbu@bogus \
--to=sudeep.holla@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=kazukih0205@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=marcan@marcan.st \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox