From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Umang Jain <umang.jain@ideasonboard.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Stefan Wahren <wahrenst@gmx.net>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Dave Stevenson <dave.stevenson@raspberrypi.org>,
detule <ogjoneski@gmail.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: vc04_services: vchiq_arm: Fix initialisation check
Date: Fri, 14 Jun 2024 08:50:08 +0200 [thread overview]
Message-ID: <2024061436-twister-survival-a05c@gregkh> (raw)
In-Reply-To: <20240613194150.2915202-2-kieran.bingham@ideasonboard.com>
On Thu, Jun 13, 2024 at 08:41:46PM +0100, Kieran Bingham wrote:
> The vchiq_state used to be obtained through an accessor
> which would validate that the VCHIQ had been initialised
> correctly with the remote.
>
> In commit 42a2f6664e18 ("staging: vc04_services: Move global g_state to
> vchiq_state") the global state was moved to the vchiq_mgnt structures
> stored as a vchiq instance specific context. This conversion removed the
> helpers and instead replaced users of this helper with the assumption
> that the state is always available and the remote connected.
>
> Fix this broken assumption by re-introducing the logic that was lost
> during the conversion.
>
> Fixes: 42a2f6664e18 ("staging: vc04_services: Move global g_state to vchiq_state")
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
> .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++--
> .../staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 5 +++++
> .../staging/vc04_services/interface/vchiq_arm/vchiq_dev.c | 7 ++++++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
You sent 2 different patches here, both with the same subject, which one
is correct?
Please send a v2 so that I know what to apply, I've dropped this one
from my queue now, thanks.
greg k-h
next prev parent reply other threads:[~2024-06-14 6:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 19:41 [PATCH] staging: vc04_services: vchiq_arm: Fix initialisation check Kieran Bingham
2024-06-13 19:41 ` Kieran Bingham
2024-06-13 20:01 ` Stefan Wahren
[not found] ` <171836496531.2248009.11650291484570726735@ping.linuxembedded.co.uk>
2024-06-14 11:52 ` Stefan Wahren
2024-06-14 12:00 ` Kieran Bingham
2024-06-14 6:50 ` Greg Kroah-Hartman [this message]
2024-06-13 19:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024061436-twister-survival-a05c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.carpenter@linaro.org \
--cc=dave.stevenson@raspberrypi.org \
--cc=florian.fainelli@broadcom.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=ogjoneski@gmail.com \
--cc=umang.jain@ideasonboard.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox