* [PATCH] iio: adc: aspeed: Use of_property_present()
@ 2024-07-31 19:12 Rob Herring (Arm)
2024-08-01 1:43 ` Andrew Jeffery
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-07-31 19:12 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen, Joel Stanley,
Andrew Jeffery
Cc: linux-iio, linux-arm-kernel, linux-aspeed, linux-kernel
Use of_property_present() to test for property presence rather than
of_find_property(). This is part of a larger effort to remove callers
of of_find_property() and similar functions. of_find_property() leaks
the DT struct property and data pointers which is a problem for
dynamically allocated nodes which may be freed.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
drivers/iio/adc/aspeed_adc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
index 090416c0d622..064cddaf6399 100644
--- a/drivers/iio/adc/aspeed_adc.c
+++ b/drivers/iio/adc/aspeed_adc.c
@@ -555,8 +555,7 @@ static int aspeed_adc_probe(struct platform_device *pdev)
if (ret)
return ret;
- if (of_find_property(data->dev->of_node, "aspeed,battery-sensing",
- NULL)) {
+ if (of_property_present(data->dev->of_node, "aspeed,battery-sensing")) {
if (data->model_data->bat_sense_sup) {
data->battery_sensing = 1;
if (readl(data->base + ASPEED_REG_ENGINE_CONTROL) &
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: adc: aspeed: Use of_property_present()
2024-07-31 19:12 [PATCH] iio: adc: aspeed: Use of_property_present() Rob Herring (Arm)
@ 2024-08-01 1:43 ` Andrew Jeffery
2024-08-03 11:19 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Jeffery @ 2024-08-01 1:43 UTC (permalink / raw)
To: Rob Herring (Arm), Jonathan Cameron, Lars-Peter Clausen,
Joel Stanley
Cc: linux-iio, linux-arm-kernel, linux-aspeed, linux-kernel
On Wed, 2024-07-31 at 13:12 -0600, Rob Herring (Arm) wrote:
> Use of_property_present() to test for property presence rather than
> of_find_property(). This is part of a larger effort to remove callers
> of of_find_property() and similar functions. of_find_property() leaks
> the DT struct property and data pointers which is a problem for
> dynamically allocated nodes which may be freed.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: aspeed: Use of_property_present()
2024-08-01 1:43 ` Andrew Jeffery
@ 2024-08-03 11:19 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2024-08-03 11:19 UTC (permalink / raw)
To: Andrew Jeffery
Cc: Rob Herring (Arm), Lars-Peter Clausen, Joel Stanley, linux-iio,
linux-arm-kernel, linux-aspeed, linux-kernel
On Thu, 01 Aug 2024 11:13:50 +0930
Andrew Jeffery <andrew@codeconstruct.com.au> wrote:
> On Wed, 2024-07-31 at 13:12 -0600, Rob Herring (Arm) wrote:
> > Use of_property_present() to test for property presence rather than
> > of_find_property(). This is part of a larger effort to remove callers
> > of of_find_property() and similar functions. of_find_property() leaks
> > the DT struct property and data pointers which is a problem for
> > dynamically allocated nodes which may be freed.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
>
> Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au>
>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-03 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-31 19:12 [PATCH] iio: adc: aspeed: Use of_property_present() Rob Herring (Arm)
2024-08-01 1:43 ` Andrew Jeffery
2024-08-03 11:19 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox