* [PATCH v2] mtd: nand: raw: atmel: Add message on DMA usage
@ 2024-08-21 14:20 Alexander Dahl
2024-08-22 15:54 ` Nicolas Ferre
2024-08-23 17:28 ` Miquel Raynal
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Dahl @ 2024-08-21 14:20 UTC (permalink / raw)
To: linux-mtd
Cc: Alexandre Belloni, open list, Vignesh Raghavendra, Kees Cook,
Richard Weinberger, Claudiu Beznea, Tudor Ambarus, Miquel Raynal,
moderated list:ARM/Microchip AT91 SoC support
Like for other atmel drivers (serial, crypto, mmc, …), too.
Signed-off-by: Alexander Dahl <ada@thorsis.com>
---
Notes:
v1 -> v2:
- make info message conditional (thanks Miquel)
drivers/mtd/nand/raw/atmel/nand-controller.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
index dc75d50d52e8..f9ccfd02e804 100644
--- a/drivers/mtd/nand/raw/atmel/nand-controller.c
+++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
@@ -2049,7 +2049,10 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc,
dma_cap_set(DMA_MEMCPY, mask);
nc->dmac = dma_request_channel(mask, NULL, NULL);
- if (!nc->dmac)
+ if (nc->dmac)
+ dev_info(nc->dev, "using %s for DMA transfers\n",
+ dma_chan_name(nc->dmac));
+ else
dev_err(nc->dev, "Failed to request DMA channel\n");
}
base-commit: 47ac09b91befbb6a235ab620c32af719f8208399
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mtd: nand: raw: atmel: Add message on DMA usage
2024-08-21 14:20 [PATCH v2] mtd: nand: raw: atmel: Add message on DMA usage Alexander Dahl
@ 2024-08-22 15:54 ` Nicolas Ferre
2024-08-23 17:28 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2024-08-22 15:54 UTC (permalink / raw)
To: Alexander Dahl, linux-mtd
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Alexandre Belloni, Claudiu Beznea, Kees Cook, Tudor Ambarus,
moderated list:ARM/Microchip (AT91) SoC support, open list
On 21/08/2024 at 16:20, Alexander Dahl wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Like for other atmel drivers (serial, crypto, mmc, …), too.
>
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
>
> Notes:
> v1 -> v2:
> - make info message conditional (thanks Miquel)
>
> drivers/mtd/nand/raw/atmel/nand-controller.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
> index dc75d50d52e8..f9ccfd02e804 100644
> --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> @@ -2049,7 +2049,10 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc,
> dma_cap_set(DMA_MEMCPY, mask);
>
> nc->dmac = dma_request_channel(mask, NULL, NULL);
> - if (!nc->dmac)
> + if (nc->dmac)
> + dev_info(nc->dev, "using %s for DMA transfers\n",
> + dma_chan_name(nc->dmac));
> + else
> dev_err(nc->dev, "Failed to request DMA channel\n");
> }
>
>
> base-commit: 47ac09b91befbb6a235ab620c32af719f8208399
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mtd: nand: raw: atmel: Add message on DMA usage
2024-08-21 14:20 [PATCH v2] mtd: nand: raw: atmel: Add message on DMA usage Alexander Dahl
2024-08-22 15:54 ` Nicolas Ferre
@ 2024-08-23 17:28 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2024-08-23 17:28 UTC (permalink / raw)
To: Alexander Dahl
Cc: Alexandre Belloni, open list, Vignesh Raghavendra, Kees Cook,
Richard Weinberger, Claudiu Beznea, Tudor Ambarus, linux-mtd,
moderated list:ARM/Microchip AT91 SoC support
Hi Alexander,
ada@thorsis.com wrote on Wed, 21 Aug 2024 16:20:05 +0200:
> Like for other atmel drivers (serial, crypto, mmc, …), too.
I was about to take the patch but I figured out the prefix was wrong,
please change it to "mtd: rawnand: atmel:" (and don't forget to collect
Nicola's tag).
>
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> ---
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-23 17:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-21 14:20 [PATCH v2] mtd: nand: raw: atmel: Add message on DMA usage Alexander Dahl
2024-08-22 15:54 ` Nicolas Ferre
2024-08-23 17:28 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox