Re: [PATCH] perf: arm-ccn: remove unused macros

[Will Deacon <will@kernel.org>]

On Mon, Oct 14, 2024 at 04:40:52PM +0100, Robin Murphy wrote:
> On 14/10/2024 10:19 am, Mark Rutland wrote:
> > On Sat, Oct 12, 2024 at 05:16:29PM +0800, Ba Jing wrote:
> > > By reading the code, I found these marcos are never
> > > referenced in the code. Just remove them.
> > > 
> > > Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
> > 
> > These are control bit values, so I don't see a strong reason to delete
> > them unless we're certain we're not going to use them in future.
> > 
> > Anyhow, Robin Murphy wrote this driver, so its up to him. Please Cc him
> > for any changes to this driver in future.
> 
> Er, this is CCN - FWIW I didn't claim this one, nor CCI, as supported in my
> maintainers entry largely because active development on them has long
> finished, but also because I *didn't* write them, so wouldn't claim to
> understand them much better than you or Will do ;)
> 
> However, I'd agree that there doesn't seem to be any significant benefit to
> removing these (certainly showing at a glance that ALL_ERRORS_DISABLE is
> composed equivalently to PMU_EVENTS_DISABLE seems like no bad thing.)

Yup. FWIW, I wasn't intending to take any of the patches removing unused
#defines in the PMU drivers. I'll pick the one removing an unused
'list_head', though, as that at least makes a structure a bit smaller.

Will