public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Ba Jing <bajing@cmss.chinamobile.com>
Cc: will@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] perf: arm-ccn: remove unused macros
Date: Mon, 14 Oct 2024 10:19:23 +0100	[thread overview]
Message-ID: <ZwziGzex9RmVlcNa@J2N7QTR9R3> (raw)
In-Reply-To: <20241012091629.2369-1-bajing@cmss.chinamobile.com>

On Sat, Oct 12, 2024 at 05:16:29PM +0800, Ba Jing wrote:
> By reading the code, I found these marcos are never
> referenced in the code. Just remove them.
> 
> Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>

These are control bit values, so I don't see a strong reason to delete
them unless we're certain we're not going to use them in future.

Anyhow, Robin Murphy wrote this driver, so its up to him. Please Cc him
for any changes to this driver in future.

Mark.

> ---
>  drivers/perf/arm-ccn.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c
> index 5c66b9278862..ea878b025d32 100644
> --- a/drivers/perf/arm-ccn.c
> +++ b/drivers/perf/arm-ccn.c
> @@ -28,12 +28,7 @@
>  
>  #define CCN_MN_ERRINT_STATUS		0x0008
>  #define CCN_MN_ERRINT_STATUS__INTREQ__DESSERT		0x11
> -#define CCN_MN_ERRINT_STATUS__ALL_ERRORS__ENABLE	0x02
> -#define CCN_MN_ERRINT_STATUS__ALL_ERRORS__DISABLED	0x20
>  #define CCN_MN_ERRINT_STATUS__ALL_ERRORS__DISABLE	0x22
> -#define CCN_MN_ERRINT_STATUS__CORRECTED_ERRORS_ENABLE	0x04
> -#define CCN_MN_ERRINT_STATUS__CORRECTED_ERRORS_DISABLED	0x40
> -#define CCN_MN_ERRINT_STATUS__CORRECTED_ERRORS_DISABLE	0x44
>  #define CCN_MN_ERRINT_STATUS__PMU_EVENTS__ENABLE	0x08
>  #define CCN_MN_ERRINT_STATUS__PMU_EVENTS__DISABLED	0x80
>  #define CCN_MN_ERRINT_STATUS__PMU_EVENTS__DISABLE	0x88
> -- 
> 2.33.0
> 
> 
> 


  reply	other threads:[~2024-10-14  9:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-12  9:16 [PATCH] perf: arm-ccn: remove unused macros Ba Jing
2024-10-14  9:19 ` Mark Rutland [this message]
2024-10-14 15:40   ` Robin Murphy
2024-10-14 16:05     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZwziGzex9RmVlcNa@J2N7QTR9R3 \
    --to=mark.rutland@arm.com \
    --cc=bajing@cmss.chinamobile.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox