Re: [PATCH 2/3] ARM: dts: imx: Add devicetree for Kobo Clara 2E

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

On Tue, Oct 22, 2024 at 07:42:21PM +0200, Andreas Kemnade wrote:
> Am Tue, 22 Oct 2024 17:59:10 +0100
> schrieb Conor Dooley <conor@kernel.org>:
> > On Mon, Oct 21, 2024 at 07:36:30PM +0200, Andreas Kemnade wrote:
> > > +&i2c2 {
> > > +	/* EPD PMIC SY7636 at 0x62 */  
> > 
> > Could you explain what you're doing here, please?
> >
> I am not sure what you are really after with this question...
> So I am guessing a bit.
> I describe the hardware as good as possible. The sy7636a (apparently
> =sy7636) driver could probably be used here but the driver and its
> bindings needs to be extended to specify an input supply and some gpios.
> So at the moment I could not use a machine-readable way of fully
> describe the stuff here. But I want to put a human-readable mark here
> so if someone extends the driver, he/she might be aware that there are
> some possible users and candidates for a Tested-by here.
> For the JD9930 it is even worse. No driver in kernel. I have a pretty
> dirty one requiring some rounds with the brush before sending it.
> So the mark is good for information what is missing and for teaming up.

Your guess was accurate. Please note in the commit message why you're
doing this, so that it's obvious why you've put comments rather than
device nodes in the file. Thanks for explaining.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]